From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.10896.1572833565051344288 for ; Sun, 03 Nov 2019 18:12:45 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: zhichao.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Nov 2019 18:12:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,265,1569308400"; d="scan'208";a="231905238" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 03 Nov 2019 18:12:44 -0800 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 3 Nov 2019 18:12:43 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 3 Nov 2019 18:12:43 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.213]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.60]) with mapi id 14.03.0439.000; Mon, 4 Nov 2019 10:12:41 +0800 From: "Gao, Zhichao" To: Sudipto Paul , Sami Mujawar , Krzysztof Koch , "devel@edk2.groups.io" CC: "Carsey, Jaben" , "Ni, Ray" , "Kinney, Michael D" , "Gao, Liming" , Matteo Carlini , nd , Deepak Pandey Subject: Re: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3 Thread-Topic: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3 Thread-Index: AQHVIUlhIK5L26igv0O8JERXQAKSIadlij0AgBEmMwCABHbTIA== Date: Mon, 4 Nov 2019 02:12:40 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B86C284@SHSMSX101.ccr.corp.intel.com> References: <20190612141021.40640-1-krzysztof.koch@arm.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjY2NDBlYTctNGI5ZS00NjQwLThmYmUtYjA4ZGQyZjJkMWRlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVTU1dmdSZ2k1NmRMOWNJRHpmVG9wbDlvRmc3WEZOZHFTUVdpbERsXC9wOXZFS1FFSmVQRm50YXMrU1JlVVd3YTYifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for the T-B. But the patch has conflict now, can you help to address it? As I know the p= revious change aims to remove the declaration of the internal used function= . So I suggest to remove the declaration of the new added function and move= the definition to the location of the declaration. Thanks, Zhichao > -----Original Message----- > From: Sudipto Paul > Sent: Friday, November 1, 2019 9:59 PM > To: Sami Mujawar ; Krzysztof Koch > ; devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; G= ao, > Zhichao ; Kinney, Michael D > ; Gao, Liming ; Matteo > Carlini ; nd ; Deepak Pandey > > Subject: RE: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3 >=20 > Tested-by: Sudipto Paul =20 > This patch has been tested on N1SDP. This is a public Neoverse branded co= res > System Development Platform. > https://community.arm.com/developer/tools-software/oss- > platforms/w/docs/440/neoverse-n1-sdp >=20 >=20 > -Sudipto >=20 > -----Original Message----- > From: Sami Mujawar > Sent: 21 October 2019 17:06 > To: Krzysztof Koch ; devel@edk2.groups.io > Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com; > michael.d.kinney@intel.com; liming.gao@intel.com; Matteo Carlini > ; nd ; Deepak Pandey > ; Sudipto Paul > Subject: RE: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3 >=20 > Reviewed-by: Sami Mujawar >=20 > Regards, >=20 > Sami Mujawar >=20 > -----Original Message----- > From: Krzysztof Koch > Sent: 12 June 2019 03:10 PM > To: devel@edk2.groups.io > Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com; > michael.d.kinney@intel.com; liming.gao@intel.com; Sami Mujawar > ; Matteo Carlini ; > Stephanie Hughes-Fitt ; nd > Subject: [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3 >=20 > This patch adds a number of definitions to the ACPI 6.3 header file for t= he > purpose of parsing Revision 3 of the System Resource Affinity Table > (SRAT) in the Acpiview UEFI shell tool. >=20 > By defining the Generic Initiator Affinity Structure's Type ID and the al= lowed > Device Handle Types for the structure, it is possible to dump and validat= e the > contents of the latest version of the SRAT table in acpiview. >=20 > References: > - ACPI 6.3 January 2019, Section 5.2.16.6 >=20 > Changes can be seen at: > https://github.com/KrzysztofKoch1/edk2/tree/582_acpiview_6_3_srat_v1 >=20 > Krzysztof Koch (2): > MdePkg: Add Generic Initiator Affinity Structure definitions to SRAT > ShellPkg: acpiview: Update SRAT parser to ACPI 6.3 >=20 > MdePkg/Include/IndustryStandard/Acpi63.h |= 11 +- > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c |= 35 ++- > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h |= 16 ++ > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c | > 256 +++++++++++++++++++- > 4 files changed, 309 insertions(+), 9 deletions(-) >=20 > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >=20 >=20 >=20 > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended reci= pient, > please notify the sender immediately and do not disclose the contents to = any > other person, use it for any purpose, or store or copy the information in= any > medium. Thank you.