From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"sami.mujawar@arm.com" <sami.mujawar@arm.com>
Cc: "Ni, Ray" <ray.ni@intel.com>,
"Matteo.Carlini@arm.com" <Matteo.Carlini@arm.com>,
"Laura.Moretta@arm.com" <Laura.Moretta@arm.com>,
"nd@arm.com" <nd@arm.com>
Subject: Re: [edk2-devel] [PATCH v2 1/1] ShellPkg: acpiview: IORT Spec Rev D updates
Date: Tue, 26 Nov 2019 01:57:27 +0000 [thread overview]
Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B87AB4D@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20191125091814.5216-1-sami.mujawar@arm.com>
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Sami
> Mujawar
> Sent: Monday, November 25, 2019 5:18 PM
> To: devel@edk2.groups.io
> Cc: Sami Mujawar <sami.mujawar@arm.com>; Ni, Ray <ray.ni@intel.com>; Gao,
> Zhichao <zhichao.gao@intel.com>; Matteo.Carlini@arm.com;
> Laura.Moretta@arm.com; nd@arm.com
> Subject: [edk2-devel] [PATCH v2 1/1] ShellPkg: acpiview: IORT Spec Rev D
> updates
>
> Updated IORT parser to conform to the IO Remapping Table, Platform Design
> Document, Revision D, March 2018.
>
> The following structure parsers have been updated:
> 1. SMMUv3 - added proximity domain and device Id
> mapping index.
> 2. RootComplex - added memory address size limit.
> 2. PMCG - added page 1 support.
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> ---
>
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/667_acpiview_iort_rev_c_v1
>
> Notes:
> v2:
> - Fixed patch check failure in commit message, [SAMI]
> changed 'CC' to 'Cc'. No code change.
> v1:
> - Update parser to support IORT specification Rev D updates [SAMI]
>
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c | 13
> +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
> index
> f1cdb9ac01d848f22ab588d8f824886387c5983d..72289c7680bc3cd5c444481e8d
> 6a719803202a9b 100644
> --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
> +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortPars
> +++ er.c
> @@ -5,7 +5,7 @@
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> @par Reference(s):
> - - IO Remapping Table, Platform Design Document, Revision C, 15 May 2017
> + - IO Remapping Table, Platform Design Document, Revision D, March
> + 2018
> **/
>
> #include <IndustryStandard/IoRemappingTable.h>
> @@ -193,7 +193,9 @@ STATIC CONST ACPI_PARSER IortNodeSmmuV3Parser[]
> = {
> {L"Event", 4, 44, L"0x%x", NULL, NULL, NULL, NULL},
> {L"PRI", 4, 48, L"0x%x", NULL, NULL, NULL, NULL},
> {L"GERR", 4, 52, L"0x%x", NULL, NULL, NULL, NULL},
> - {L"Sync", 4, 56, L"0x%x", NULL, NULL, NULL, NULL}
> + {L"Sync", 4, 56, L"0x%x", NULL, NULL, NULL, NULL}, {L"Proximity
> + domain", 4, 60, L"0x%x", NULL, NULL, NULL, NULL}, {L"Device ID
> + mapping index", 4, 64, L"%d", NULL, NULL, NULL, NULL}
> };
>
> /**
> @@ -231,7 +233,9 @@ STATIC CONST ACPI_PARSER
> IortNodeRootComplexParser[] = {
> PARSE_IORT_NODE_HEADER (NULL, NULL),
> {L"Memory access properties", 8, 16, L"0x%lx", NULL, NULL, NULL, NULL},
> {L"ATS Attribute", 4, 24, L"0x%x", NULL, NULL, NULL, NULL},
> - {L"PCI Segment number", 4, 28, L"0x%x", NULL, NULL, NULL, NULL}
> + {L"PCI Segment number", 4, 28, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Memory access size limit", 1, 32, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Reserved", 3, 33, L"%x %x %x", Dump3Chars, NULL, NULL, NULL}
> };
>
> /**
> @@ -239,9 +243,10 @@ STATIC CONST ACPI_PARSER
> IortNodeRootComplexParser[] = { **/ STATIC CONST ACPI_PARSER
> IortNodePmcgParser[] = {
> PARSE_IORT_NODE_HEADER (ValidatePmcgIdMappingCount, NULL),
> - {L"Base Address", 8, 16, L"0x%lx", NULL, NULL, NULL, NULL},
> + {L"Page 0 Base Address", 8, 16, L"0x%lx", NULL, NULL, NULL, NULL},
> {L"Overflow interrupt GSIV", 4, 24, L"0x%x", NULL, NULL, NULL, NULL},
> {L"Node reference", 4, 28, L"0x%x", NULL, NULL, NULL, NULL},
> + {L"Page 1 Base Address", 8, 32, L"0x%lx", NULL, NULL, NULL, NULL}
> };
>
> /**
> --
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
>
>
>
>
prev parent reply other threads:[~2019-11-26 1:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 9:18 [PATCH v2 1/1] ShellPkg: acpiview: IORT Spec Rev D updates Sami Mujawar
2019-11-26 1:57 ` Gao, Zhichao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CE959C139B4C44DBEA1810E3AA6F9000B87AB4D@SHSMSX101.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox