From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.5842.1574733450428999456 for ; Mon, 25 Nov 2019 17:57:30 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: zhichao.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Nov 2019 17:57:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,243,1571727600"; d="scan'208";a="206319312" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga008.fm.intel.com with ESMTP; 25 Nov 2019 17:57:29 -0800 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 25 Nov 2019 17:57:29 -0800 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 25 Nov 2019 17:57:28 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.213]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.41]) with mapi id 14.03.0439.000; Tue, 26 Nov 2019 09:57:27 +0800 From: "Gao, Zhichao" To: "devel@edk2.groups.io" , "sami.mujawar@arm.com" CC: "Ni, Ray" , "Matteo.Carlini@arm.com" , "Laura.Moretta@arm.com" , "nd@arm.com" Subject: Re: [edk2-devel] [PATCH v2 1/1] ShellPkg: acpiview: IORT Spec Rev D updates Thread-Topic: [edk2-devel] [PATCH v2 1/1] ShellPkg: acpiview: IORT Spec Rev D updates Thread-Index: AQHVo3Fb6jSU6EoPvkCJS73dQ3RSFKecsrDA Date: Tue, 26 Nov 2019 01:57:27 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B87AB4D@SHSMSX101.ccr.corp.intel.com> References: <20191125091814.5216-1-sami.mujawar@arm.com> In-Reply-To: <20191125091814.5216-1-sami.mujawar@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zhichao Gao > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Sa= mi > Mujawar > Sent: Monday, November 25, 2019 5:18 PM > To: devel@edk2.groups.io > Cc: Sami Mujawar ; Ni, Ray ; Gao= , > Zhichao ; Matteo.Carlini@arm.com; > Laura.Moretta@arm.com; nd@arm.com > Subject: [edk2-devel] [PATCH v2 1/1] ShellPkg: acpiview: IORT Spec Rev D > updates >=20 > Updated IORT parser to conform to the IO Remapping Table, Platform Desig= n > Document, Revision D, March 2018. >=20 > The following structure parsers have been updated: > 1. SMMUv3 - added proximity domain and device Id > mapping index. > 2. RootComplex - added memory address size limit. > 2. PMCG - added page 1 support. >=20 > Cc: Ray Ni > Cc: Zhichao Gao > Signed-off-by: Sami Mujawar > --- >=20 > The changes can be seen at: > https://github.com/samimujawar/edk2/tree/667_acpiview_iort_rev_c_v1 >=20 > Notes: > v2: > - Fixed patch check failure in commit message, [SAM= I] > changed 'CC' to 'Cc'. No code change. > v1: > - Update parser to support IORT specification Rev D updates [SAM= I] >=20 > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c = | 13 > +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) >=20 > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c > index > f1cdb9ac01d848f22ab588d8f824886387c5983d..72289c7680bc3cd5c444481e8d > 6a719803202a9b 100644 > --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortPars= er.c > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortPars > +++ er.c > @@ -5,7 +5,7 @@ > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @par Reference(s): > - - IO Remapping Table, Platform Design Document, Revision C, 15 May = 2017 > + - IO Remapping Table, Platform Design Document, Revision D, March > + 2018 > **/ >=20 > #include > @@ -193,7 +193,9 @@ STATIC CONST ACPI_PARSER IortNodeSmmuV3Parser[] > =3D { > {L"Event", 4, 44, L"0x%x", NULL, NULL, NULL, NULL}, > {L"PRI", 4, 48, L"0x%x", NULL, NULL, NULL, NULL}, > {L"GERR", 4, 52, L"0x%x", NULL, NULL, NULL, NULL}, > - {L"Sync", 4, 56, L"0x%x", NULL, NULL, NULL, NULL} > + {L"Sync", 4, 56, L"0x%x", NULL, NULL, NULL, NULL}, {L"Proximity > + domain", 4, 60, L"0x%x", NULL, NULL, NULL, NULL}, {L"Device ID > + mapping index", 4, 64, L"%d", NULL, NULL, NULL, NULL} > }; >=20 > /** > @@ -231,7 +233,9 @@ STATIC CONST ACPI_PARSER > IortNodeRootComplexParser[] =3D { > PARSE_IORT_NODE_HEADER (NULL, NULL), > {L"Memory access properties", 8, 16, L"0x%lx", NULL, NULL, NULL, NULL= }, > {L"ATS Attribute", 4, 24, L"0x%x", NULL, NULL, NULL, NULL}, > - {L"PCI Segment number", 4, 28, L"0x%x", NULL, NULL, NULL, NULL} > + {L"PCI Segment number", 4, 28, L"0x%x", NULL, NULL, NULL, NULL}, > + {L"Memory access size limit", 1, 32, L"0x%x", NULL, NULL, NULL, NULL}, > + {L"Reserved", 3, 33, L"%x %x %x", Dump3Chars, NULL, NULL, NULL} > }; >=20 > /** > @@ -239,9 +243,10 @@ STATIC CONST ACPI_PARSER > IortNodeRootComplexParser[] =3D { **/ STATIC CONST ACPI_PARSER > IortNodePmcgParser[] =3D { > PARSE_IORT_NODE_HEADER (ValidatePmcgIdMappingCount, NULL), > - {L"Base Address", 8, 16, L"0x%lx", NULL, NULL, NULL, NULL}, > + {L"Page 0 Base Address", 8, 16, L"0x%lx", NULL, NULL, NULL, NULL}, > {L"Overflow interrupt GSIV", 4, 24, L"0x%x", NULL, NULL, NULL, NULL}, > {L"Node reference", 4, 28, L"0x%x", NULL, NULL, NULL, NULL}, > + {L"Page 1 Base Address", 8, 32, L"0x%lx", NULL, NULL, NULL, NULL} > }; >=20 > /** > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >=20 >=20 >=20 >=20