public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"xypron.glpk@gmx.de" <xypron.glpk@gmx.de>,
	"Gao, Liming" <liming.gao@intel.com>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Ni, Ray" <ray.ni@intel.com>
Subject: Re: [edk2-devel] [edk2] [PATCH] ShellPkg/edit: typo "%d Lines Wrote"
Date: Tue, 3 Dec 2019 01:42:57 +0000	[thread overview]
Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B88D366@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20191124103320.21348-1-xypron.glpk@gmx.de>

Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Heinrich Schuchardt
> Sent: Sunday, November 24, 2019 6:33 PM
> To: EDK II Development <devel@edk2.groups.io>; Gao, Liming
> <liming.gao@intel.com>
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Heinrich Schuchardt
> <xypron.glpk@gmx.de>
> Subject: [edk2-devel] [edk2] [PATCH] ShellPkg/edit: typo "%d Lines Wrote"
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2379
> 
> When a file is saved in the edit command a status message L"%d Lines Wrote"
> is displayed. The hexedit command suffers from the same typo.
> 
> Change the message to L"%d Lines Written".
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c   | 2 +-
>  ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/FileImage.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> index 12235e4e4b..71036a7487 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c
> @@ -1608,7 +1608,7 @@ FileBufferSave (
>    //   // set status string   //-  Str = CatSPrint (NULL, L"%d Lines Wrote",
> NumLines);+  Str = CatSPrint (NULL, L"%d Lines Written", NumLines);   if (Str ==
> NULL) {     return EFI_OUT_OF_RESOURCES;   }diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/FileImage.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/FileImage.c
> index b393f2a423..bb324ceafc 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/FileImage.c
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/FileImage.c
> @@ -368,7 +368,7 @@ HFileImageSave (
>    //   // set status string   //-  Str = CatSPrint(NULL, L"%d Lines Wrote",
> NumLines);+  Str = CatSPrint(NULL, L"%d Lines Written", NumLines);
> StatusBarSetStatusString (Str);   FreePool (Str); --
> 2.24.0
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> 
> View/Reply Online (#51206): https://edk2.groups.io/g/devel/message/51206
> Mute This Topic: https://groups.io/mt/61873155/1768756
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub  [zhichao.gao@intel.com] -
> =-=-=-=-=-=


      parent reply	other threads:[~2019-12-03  1:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-24 10:33 [edk2] [PATCH] ShellPkg/edit: typo "%d Lines Wrote" Heinrich Schuchardt
2019-11-25  8:09 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-12-03  1:42 ` Gao, Zhichao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CE959C139B4C44DBEA1810E3AA6F9000B88D366@SHSMSX101.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox