Re: [PATCH V2 0/2] MdePkg/UefiDevicePathLib: Separate the lib instances

["Gao, Zhichao" <zhichao.gao@intel.com>]

Actually I didn't do the functionality test of Mandatory one, only do the build test and logic check. It is part of the Optional one. I assume the optional one is working fine. Then there would be no problem with Mandatory one.
I would write a test for both of them to make sure they are both fine.

Thanks,
Zhichao

> -----Original Message-----
> From: Gao, Liming
> Sent: Thursday, December 12, 2019 1:05 PM
> To: Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Vitaly Cheptsov
> <vit9696@protonmail.com>
> Subject: RE: [PATCH V2 0/2] MdePkg/UefiDevicePathLib: Separate the lib
> instances
> 
> Zhichao:
>    The change is good. What functionality test is done?
> 
> Thanks
> Liming
> >-----Original Message-----
> >From: Gao, Zhichao
> >Sent: Thursday, December 12, 2019 10:09 AM
> >To: devel@edk2.groups.io
> >Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> ><liming.gao@intel.com>; Vitaly Cheptsov <vit9696@protonmail.com>
> >Subject: [PATCH V2 0/2] MdePkg/UefiDevicePathLib: Separate the lib
> >instances
> >
> >REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2298
> >
> >The UefiDevicePathLibOptionalDevicePathProtocolConstructor's
> >implementation
> >isn't match with its instance name.
> >Remove the ASSERT and depex of the gEfiDevicePathUtilitiesProtocolGuid
> >because of "Optional".
> >
> >Add a mandatory instance to force using the DevicePathUtilities,
> >DevicePathToText and DevicePathFromText protocol with the ASSERT and
> >depex.
> >
> >V2:
> >The optional lib instance's construction should return success all the
> >time.
> >Change the desciption of the optional lib uni file.
> >Change the copyright date of the mandatory one's uni file.
> >
> >Cc: Michael D Kinney <michael.d.kinney@intel.com>
> >Cc: Liming Gao <liming.gao@intel.com>
> >Cc: Vitaly Cheptsov <vit9696@protonmail.com>
> >Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> >
> >Zhichao Gao (2):
> >  MdePkg/UefiDevicePathLib: Separate the device path lib
> >  MdePkg/dsc: Add UefiDevicePathLibMandatoryDevicePathProtocol for
> >build
> >
> > ...DevicePathLibMandatoryDevicePathProtocol.c | 469
> >++++++++++++++++++
> > ...vicePathLibMandatoryDevicePathProtocol.inf |  86 ++++
> >...vicePathLibMandatoryDevicePathProtocol.uni |  18 +
> > ...iDevicePathLibOptionalDevicePathProtocol.c |   9 +-
> > ...evicePathLibOptionalDevicePathProtocol.inf |   5 +-
> > ...evicePathLibOptionalDevicePathProtocol.uni |   6 +-
> > MdePkg/MdePkg.dsc                             |   3 +-
> > 7 files changed, 582 insertions(+), 14 deletions(-)  create mode
> >100644
> >MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibMandatoryDevicePa
> th
> >Protocol.c
> > create mode 100644
> >MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibMandatoryDevicePa
> th
> >Protocol.inf
> > create mode 100644
> >MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibMandatoryDevicePa
> th
> >Protocol.uni
> >
> >--
> >2.21.0.windows.1