From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web09.2849.1576128545172671849 for ; Wed, 11 Dec 2019 21:29:05 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: zhichao.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2019 21:29:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,304,1571727600"; d="scan'208";a="210960019" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga007.fm.intel.com with ESMTP; 11 Dec 2019 21:29:04 -0800 Received: from fmsmsx163.amr.corp.intel.com (10.18.125.72) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 11 Dec 2019 21:29:04 -0800 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx163.amr.corp.intel.com (10.18.125.72) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 11 Dec 2019 21:29:03 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.19]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.195]) with mapi id 14.03.0439.000; Thu, 12 Dec 2019 13:28:59 +0800 From: "Gao, Zhichao" To: "Gao, Liming" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , Vitaly Cheptsov Subject: Re: [PATCH V2 0/2] MdePkg/UefiDevicePathLib: Separate the lib instances Thread-Topic: [PATCH V2 0/2] MdePkg/UefiDevicePathLib: Separate the lib instances Thread-Index: AQHVsJFtAsQcHkGstkyXy62X5jj7nqe18j8wgAAEvYA= Date: Thu, 12 Dec 2019 05:28:59 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B89359E@SHSMSX101.ccr.corp.intel.com> References: <20191212020922.14620-1-zhichao.gao@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E564B61@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E564B61@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Actually I didn't do the functionality test of Mandatory one, only do the b= uild test and logic check. It is part of the Optional one. I assume the opt= ional one is working fine. Then there would be no problem with Mandatory on= e. I would write a test for both of them to make sure they are both fine. Thanks, Zhichao > -----Original Message----- > From: Gao, Liming > Sent: Thursday, December 12, 2019 1:05 PM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Kinney, Michael D ; Vitaly Cheptsov > > Subject: RE: [PATCH V2 0/2] MdePkg/UefiDevicePathLib: Separate the lib > instances >=20 > Zhichao: > The change is good. What functionality test is done? >=20 > Thanks > Liming > >-----Original Message----- > >From: Gao, Zhichao > >Sent: Thursday, December 12, 2019 10:09 AM > >To: devel@edk2.groups.io > >Cc: Kinney, Michael D ; Gao, Liming > >; Vitaly Cheptsov > >Subject: [PATCH V2 0/2] MdePkg/UefiDevicePathLib: Separate the lib > >instances > > > >REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2298 > > > >The UefiDevicePathLibOptionalDevicePathProtocolConstructor's > >implementation > >isn't match with its instance name. > >Remove the ASSERT and depex of the gEfiDevicePathUtilitiesProtocolGuid > >because of "Optional". > > > >Add a mandatory instance to force using the DevicePathUtilities, > >DevicePathToText and DevicePathFromText protocol with the ASSERT and > >depex. > > > >V2: > >The optional lib instance's construction should return success all the > >time. > >Change the desciption of the optional lib uni file. > >Change the copyright date of the mandatory one's uni file. > > > >Cc: Michael D Kinney > >Cc: Liming Gao > >Cc: Vitaly Cheptsov > >Signed-off-by: Zhichao Gao > > > >Zhichao Gao (2): > > MdePkg/UefiDevicePathLib: Separate the device path lib > > MdePkg/dsc: Add UefiDevicePathLibMandatoryDevicePathProtocol for > >build > > > > ...DevicePathLibMandatoryDevicePathProtocol.c | 469 > >++++++++++++++++++ > > ...vicePathLibMandatoryDevicePathProtocol.inf | 86 ++++ > >...vicePathLibMandatoryDevicePathProtocol.uni | 18 + > > ...iDevicePathLibOptionalDevicePathProtocol.c | 9 +- > > ...evicePathLibOptionalDevicePathProtocol.inf | 5 +- > > ...evicePathLibOptionalDevicePathProtocol.uni | 6 +- > > MdePkg/MdePkg.dsc | 3 +- > > 7 files changed, 582 insertions(+), 14 deletions(-) create mode > >100644 > >MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibMandatoryDevicePa > th > >Protocol.c > > create mode 100644 > >MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibMandatoryDevicePa > th > >Protocol.inf > > create mode 100644 > >MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibMandatoryDevicePa > th > >Protocol.uni > > > >-- > >2.21.0.windows.1