From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.4276.1576142095652675796 for ; Thu, 12 Dec 2019 01:14:55 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: zhichao.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Dec 2019 01:14:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,305,1571727600"; d="scan'208";a="245642415" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 12 Dec 2019 01:14:54 -0800 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 12 Dec 2019 01:14:54 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 12 Dec 2019 01:14:53 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.19]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.214]) with mapi id 14.03.0439.000; Thu, 12 Dec 2019 17:14:52 +0800 From: "Gao, Zhichao" To: "devel@edk2.groups.io" , "Gao, Zhichao" , "Gao, Liming" CC: "Kinney, Michael D" , Vitaly Cheptsov Subject: Re: [edk2-devel] [PATCH V2 0/2] MdePkg/UefiDevicePathLib: Separate the lib instances Thread-Topic: [edk2-devel] [PATCH V2 0/2] MdePkg/UefiDevicePathLib: Separate the lib instances Thread-Index: AQHVsJFtAsQcHkGstkyXy62X5jj7nqe18j8wgAAEvYCAAD+KcA== Date: Thu, 12 Dec 2019 09:14:51 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B8936F5@SHSMSX101.ccr.corp.intel.com> References: <20191212020922.14620-1-zhichao.gao@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E564B61@SHSMSX104.ccr.corp.intel.com> <15DF888FBF57C8A4.14754@groups.io> In-Reply-To: <15DF888FBF57C8A4.14754@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I have ported a test case from SCT to test the interfaces in UefiDevicePath= LibMandatoryDevicePathProtocol.c and UefiDevicePathLibOptionalDevicePathPro= tocol.c only. And I do the test on Ovmf environment for two configuration: one is includ= e DevicePathDxe, and the other is not. Optional one lib test cases would always passed. Mandatory one lib test case would passed with Ovmf with DevicePathDxe, and= ASSERT with the other. The test result is expected. Tested-by: Zhichao Gao Thanks, Zhichao > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Gao, Zhichao > Sent: Thursday, December 12, 2019 1:29 PM > To: Gao, Liming ; devel@edk2.groups.io > Cc: Kinney, Michael D ; Vitaly Cheptsov > > Subject: Re: [edk2-devel] [PATCH V2 0/2] MdePkg/UefiDevicePathLib: > Separate the lib instances >=20 > Actually I didn't do the functionality test of Mandatory one, only do th= e build > test and logic check. It is part of the Optional one. I assume the optio= nal one > is working fine. Then there would be no problem with Mandatory one. > I would write a test for both of them to make sure they are both fine. >=20 > Thanks, > Zhichao >=20 > > -----Original Message----- > > From: Gao, Liming > > Sent: Thursday, December 12, 2019 1:05 PM > > To: Gao, Zhichao ; devel@edk2.groups.io > > Cc: Kinney, Michael D ; Vitaly Cheptsov > > > > Subject: RE: [PATCH V2 0/2] MdePkg/UefiDevicePathLib: Separate the lib > > instances > > > > Zhichao: > > The change is good. What functionality test is done? > > > > Thanks > > Liming > > >-----Original Message----- > > >From: Gao, Zhichao > > >Sent: Thursday, December 12, 2019 10:09 AM > > >To: devel@edk2.groups.io > > >Cc: Kinney, Michael D ; Gao, Liming > > >; Vitaly Cheptsov > > >Subject: [PATCH V2 0/2] MdePkg/UefiDevicePathLib: Separate the lib > > >instances > > > > > >REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2298 > > > > > >The UefiDevicePathLibOptionalDevicePathProtocolConstructor's > > >implementation > > >isn't match with its instance name. > > >Remove the ASSERT and depex of the > > >gEfiDevicePathUtilitiesProtocolGuid > > >because of "Optional". > > > > > >Add a mandatory instance to force using the DevicePathUtilities, > > >DevicePathToText and DevicePathFromText protocol with the ASSERT and > > >depex. > > > > > >V2: > > >The optional lib instance's construction should return success all > > >the time. > > >Change the desciption of the optional lib uni file. > > >Change the copyright date of the mandatory one's uni file. > > > > > >Cc: Michael D Kinney > > >Cc: Liming Gao > > >Cc: Vitaly Cheptsov > > >Signed-off-by: Zhichao Gao > > > > > >Zhichao Gao (2): > > > MdePkg/UefiDevicePathLib: Separate the device path lib > > > MdePkg/dsc: Add UefiDevicePathLibMandatoryDevicePathProtocol for > > >build > > > > > > ...DevicePathLibMandatoryDevicePathProtocol.c | 469 > > >++++++++++++++++++ > > > ...vicePathLibMandatoryDevicePathProtocol.inf | 86 ++++ > > >...vicePathLibMandatoryDevicePathProtocol.uni | 18 + > > > ...iDevicePathLibOptionalDevicePathProtocol.c | 9 +- > > > ...evicePathLibOptionalDevicePathProtocol.inf | 5 +- > > > ...evicePathLibOptionalDevicePathProtocol.uni | 6 +- > > > MdePkg/MdePkg.dsc | 3 +- > > > 7 files changed, 582 insertions(+), 14 deletions(-) create mode > > >100644 > > > >MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibMandatoryDevicePa > > th > > >Protocol.c > > > create mode 100644 > > > >MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibMandatoryDevicePa > > th > > >Protocol.inf > > > create mode 100644 > > > >MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibMandatoryDevicePa > > th > > >Protocol.uni > > > > > >-- > > >2.21.0.windows.1 >=20 >=20 >=20