public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: Philippe Mathieu-Daude <philmd@redhat.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [PATCH v2 0/2] ShellPkg: Document the use of EFI_INVALID_PARAMETER by two functions
Date: Tue, 7 Jan 2020 07:01:52 +0000	[thread overview]
Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B8BF8A5@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20191219140932.25428-1-philmd@redhat.com>

Sorry for late response:

> -----Original Message-----
> From: Philippe Mathieu-Daude <philmd@redhat.com>
> Sent: Thursday, December 19, 2019 10:10 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>;
> Philippe Mathieu-Daude <philmd@redhat.com>
> Subject: [PATCH v2 0/2] ShellPkg: Document the use of
> EFI_INVALID_PARAMETER by two functions
> 
> Complete the list of values the functios ParseCommandLineToArgs() and
> UpdateArgcArgv() can return.
> 
> The documentation was found to be incomplete while reviewing BZ#2395:
> https://edk2.groups.io/g/devel/message/51512
> 
> v2:
> - Shortened patch #1 subject to fit 72 chars

The subject should be less than 72 chars (do not include 72 chars).

Thanks,
Zhichao

> - Added Zhichao Gao R-b tag
> 
> Regards,
> 
> Phil.
> 
> Philippe Mathieu-Daude (2):
>   ShellPkg: Document ParseCommandLineToArgs returns
>     EFI_INVALID_PARAMETER
>   ShellPkg: Document UpdateArgcArgv returns EFI_INVALID_PARAMETER
> 
>  ShellPkg/Application/Shell/ShellParametersProtocol.h | 2 ++
> ShellPkg/Application/Shell/ShellParametersProtocol.c | 2 ++
>  2 files changed, 4 insertions(+)
> 
> --
> 2.21.0


  parent reply	other threads:[~2020-01-07  7:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-19 14:09 [PATCH v2 0/2] ShellPkg: Document the use of EFI_INVALID_PARAMETER by two functions Philippe Mathieu-Daudé
2019-12-19 14:09 ` [PATCH v2 1/2] ShellPkg: Document ParseCommandLineToArgs returns EFI_INVALID_PARAMETER Philippe Mathieu-Daudé
2019-12-19 14:09 ` [PATCH v2 2/2] ShellPkg: Document UpdateArgcArgv " Philippe Mathieu-Daudé
2020-01-07  7:01 ` Gao, Zhichao [this message]
2020-01-07  7:09   ` [PATCH v2 0/2] ShellPkg: Document the use of EFI_INVALID_PARAMETER by two functions Philippe Mathieu-Daudé
2020-01-07  7:37     ` Gao, Zhichao
2020-01-21 11:24       ` Philippe Mathieu-Daudé
2020-01-31  5:31         ` [edk2-devel] " Gao, Zhichao
2020-02-04 23:04           ` Philippe Mathieu-Daudé
2020-02-11 12:16             ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CE959C139B4C44DBEA1810E3AA6F9000B8BF8A5@SHSMSX101.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox