public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Ard Biesheuvel <ardb@kernel.org>, Nhi Pham <nhi@os.amperecomputing.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"quic_llindhol@quicinc.com" <quic_llindhol@quicinc.com>,
	"ardb+tianocore@kernel.org" <ardb+tianocore@kernel.org>,
	"quic_rcran@quicinc.com" <quic_rcran@quicinc.com>,
	"patches@amperecomputing.com" <patches@amperecomputing.com>,
	nd <nd@arm.com>
Subject: Re: [PATCH v2 0/6] ArmPkg/SMBIOS fixes and improvements
Date: Wed, 7 Sep 2022 10:49:14 +0000	[thread overview]
Message-ID: <3E51D88E-C099-4962-960E-7DB3299B7B6E@arm.com> (raw)
In-Reply-To: <CAMj1kXH4wn-CqO5kbEaRgFJyvxuv_nSkeO5+boTgrZr=zK0fww@mail.gmail.com>

Hi Nhi,

I was building this patch series and realised that merging this patch series will break the SbsaQemu platform builds.
Would you be submitting a patch to update SbsaQemu platform to match this series, please?

Also, can you check if this patch breaks any other platform.

Regards,

Sami Mujawar

On 05/09/2022, 12:57, "Ard Biesheuvel" <ardb@kernel.org> wrote:

    On Wed, 24 Aug 2022 at 18:51, Nhi Pham <nhi@os.amperecomputing.com> wrote:
    >
    > This patchset is to update the ArmPkg/SMBIOS for fixes and improvements.
    >
    > Changes since v1:
    >     + Change PartNumber to ProcessorVersion [Sami]
    >
    > Minh Nguyen (5):
    >   ArmPkg/ProcessorSubClassDxe: Get processor version from OemMiscLib
    >   ArmPkg: Correct return value of "SMCCC_ARCH_SOC_ID" Function ID call
    >   ArmPkg/SmbiosMiscDxe: Fix typo of "AssetTagType02"
    >   ArmPkg/SmbiosMiscDxe: Remove redundant updates in SMBIOS Type 2
    >   ArmPkg/SmbiosMiscDxe: Get SMBIOS information from OemMiscLib
    >
    > Nhi Pham (1):
    >   ArmPkg/SmbiosMiscDxe: Support fetching System UUID
    >

    As Sami appears to be happy with this series,

    Acked-by: Ard Biesheuvel <ardb@kernel.org>

    >  ArmPkg/Include/Library/OemMiscLib.h                                              | 37 +++++++++++++++-
    >  ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c                              | 46 ++++++++++++++++++++
    >  ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c                 |  8 +++-
    >  ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c          |  6 +--
    >  ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c            | 32 +++++++++-----
    >  ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c    |  3 +-
    >  ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c | 13 +-----
    >  7 files changed, 117 insertions(+), 28 deletions(-)
    >
    > --
    > 2.25.1
    >


  reply	other threads:[~2022-09-07 10:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-24 16:50 [PATCH v2 0/6] ArmPkg/SMBIOS fixes and improvements Nhi Pham
2022-08-24 16:50 ` [PATCH v2 1/6] ArmPkg/ProcessorSubClassDxe: Get processor version from OemMiscLib Nhi Pham
2022-09-01 10:48   ` [edk2-devel] " Sami Mujawar
2022-09-05  4:46     ` Nhi Pham
2022-09-05  7:32       ` Sami Mujawar
2022-08-24 16:50 ` [PATCH v2 2/6] ArmPkg: Correct return value of "SMCCC_ARCH_SOC_ID" Function ID call Nhi Pham
2022-08-24 16:50 ` [PATCH v2 3/6] ArmPkg/SmbiosMiscDxe: Support fetching System UUID Nhi Pham
2022-08-24 16:50 ` [PATCH v2 4/6] ArmPkg/SmbiosMiscDxe: Fix typo of "AssetTagType02" Nhi Pham
2022-08-24 16:50 ` [PATCH v2 5/6] ArmPkg/SmbiosMiscDxe: Remove redundant updates in SMBIOS Type 2 Nhi Pham
2022-08-24 16:50 ` [PATCH v2 6/6] ArmPkg/SmbiosMiscDxe: Get SMBIOS information from OemMiscLib Nhi Pham
2022-09-05 11:57 ` [PATCH v2 0/6] ArmPkg/SMBIOS fixes and improvements Ard Biesheuvel
2022-09-07 10:49   ` Sami Mujawar [this message]
2022-09-07 11:29     ` Nhi Pham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E51D88E-C099-4962-960E-7DB3299B7B6E@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox