public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Michael Kinney <michael.d.kinney@intel.com>, edk2-devel@lists.01.org
Cc: Jordan Justen <jordan.l.justen@intel.com>,
	Liming Gao <liming.gao@intel.com>,
	Kevin W Shaw <kevin.w.shaw@intel.com>
Subject: Re: [edk2-CCodingStandardsSpecification PATCH V2] Clarify format of multi-line function calls
Date: Mon, 12 Jun 2017 23:50:13 +0200	[thread overview]
Message-ID: <3a0154f3-214e-2f60-d0e6-755222c882de@redhat.com> (raw)
In-Reply-To: <1497303553-19160-2-git-send-email-michael.d.kinney@intel.com>

On 06/12/17 23:39, Michael Kinney wrote:

> +* One argument per line, including the first argument on its own line.
> +* Indent each argument 2 spaces from the start of the function name. If a
> +  function is called through a structure or union member, of type
> +  function-to-pointer, then indent each argument 2 spaces from the start of the

I think we should say "pointer-to-function" here, not "function-to-pointer".

> +DEBUG ((
> +  DEBUG_INFO,
> +  "The addresses of the 4 buffers are %p, %p, %p, and %p",
> +  Buffer1,
> +  Buffer2,
> +  Buffer3,
> +  Buffer4
> +  ));
>  ```

Just to be consistent with actual code, I suggest appending "\n" to the
format string.

With those:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks!
Laszlo


      reply	other threads:[~2017-06-12 21:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-12 21:39 [edk2-CCodingStandardsSpecification PATCH V2] Clarify format of multi-line function calls Michael Kinney
2017-06-12 21:39 ` Michael Kinney
2017-06-12 21:50   ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a0154f3-214e-2f60-d0e6-755222c882de@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox