From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 2697821AE30D0
 for <edk2-devel@lists.01.org>; Mon, 12 Jun 2017 14:49:02 -0700 (PDT)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com
 [10.5.11.15])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 78EDDC057FA5;
 Mon, 12 Jun 2017 21:50:15 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 78EDDC057FA5
Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com;
 dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com;
 spf=pass smtp.mailfrom=lersek@redhat.com
DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 78EDDC057FA5
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-168.phx2.redhat.com
 [10.3.116.168])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 557C877EB7;
 Mon, 12 Jun 2017 21:50:14 +0000 (UTC)
To: Michael Kinney <michael.d.kinney@intel.com>, edk2-devel@lists.01.org
Cc: Jordan Justen <jordan.l.justen@intel.com>,
 Liming Gao <liming.gao@intel.com>, Kevin W Shaw <kevin.w.shaw@intel.com>
References: <1497303553-19160-1-git-send-email-michael.d.kinney@intel.com>
 <1497303553-19160-2-git-send-email-michael.d.kinney@intel.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <3a0154f3-214e-2f60-d0e6-755222c882de@redhat.com>
Date: Mon, 12 Jun 2017 23:50:13 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <1497303553-19160-2-git-send-email-michael.d.kinney@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.32]); Mon, 12 Jun 2017 21:50:15 +0000 (UTC)
Subject: Re: [edk2-CCodingStandardsSpecification PATCH V2] Clarify format of multi-line function calls
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Jun 2017 21:49:02 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 06/12/17 23:39, Michael Kinney wrote:

> +* One argument per line, including the first argument on its own line.
> +* Indent each argument 2 spaces from the start of the function name. If a
> +  function is called through a structure or union member, of type
> +  function-to-pointer, then indent each argument 2 spaces from the start of the

I think we should say "pointer-to-function" here, not "function-to-pointer".

> +DEBUG ((
> +  DEBUG_INFO,
> +  "The addresses of the 4 buffers are %p, %p, %p, and %p",
> +  Buffer1,
> +  Buffer2,
> +  Buffer3,
> +  Buffer4
> +  ));
>  ```

Just to be consistent with actual code, I suggest appending "\n" to the
format string.

With those:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks!
Laszlo