From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [216.205.24.74]) by mx.groups.io with SMTP id smtpd.web10.15856.1585154018340080204 for ; Wed, 25 Mar 2020 09:33:38 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Rq6eC87B; spf=pass (domain: redhat.com, ip: 216.205.24.74, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585154017; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/ivPO3zupMwbZ3y6xwXbXJKPBCscp8cS6xmjWvluqYQ=; b=Rq6eC87BCGm5Mz5AG/ILG9d0ceuRa9nCp/U71l58QYuL9N5YFoqzHxIqvhAg0u0JjVUQPP w6ZoI0tIU+yYtyfAhQiwvF+KCiYFvqUrSNZVDhkJ00UHh/N/Wek+vQPReMLjO/yUwafbaX RYBQ5T3nhuHtyEqD9MvTIjK+BnphWDs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-29-J5NkPlS2P-m6UuR2R0NyUw-1; Wed, 25 Mar 2020 12:33:33 -0400 X-MC-Unique: J5NkPlS2P-m6UuR2R0NyUw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C9F6966F; Wed, 25 Mar 2020 16:33:31 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-153.ams2.redhat.com [10.36.113.153]) by smtp.corp.redhat.com (Postfix) with ESMTP id 29A62BBBC2; Wed, 25 Mar 2020 16:33:29 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib DXE: Add PCD to control AP status check interval To: "Wu, Hao A" , "Ni, Ray" , "Kinney, Michael D" , "Zeng, Star" , "devel@edk2.groups.io" Cc: "Dong, Eric" , "Brian J . Johnson" References: <20200324063328.8812-1-hao.a.wu@intel.com> <0C09AFA07DD0434D9E2A0C6AEB048310405D4087@shsmsx102.ccr.corp.intel.com> <0C09AFA07DD0434D9E2A0C6AEB048310405D411B@shsmsx102.ccr.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5C4AA5E3@SHSMSX104.ccr.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5C4ACE08@SHSMSX104.ccr.corp.intel.com> From: "Laszlo Ersek" Message-ID: <3a077caf-23e7-9d99-1161-0f96e48d8ce3@redhat.com> Date: Wed, 25 Mar 2020 17:33:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 03/25/20 02:24, Wu, Hao A wrote: >> -----Original Message----- >> From: Ni, Ray >> Sent: Wednesday, March 25, 2020 8:46 AM >> To: Kinney, Michael D; Zeng, Star; Wu, Hao A; devel@edk2.groups.io >> Cc: Dong, Eric; Laszlo Ersek; Brian J . Johnson >> Subject: RE: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib DXE: Add PCD to >> control AP status check interval >> >> Mike, Hao, >> I searched all edk2 code using regex pattern "Pcd.*Timeout.*", "Pcd.*Timer.*", >> "Pcd.*Delay.*" >> and found below PCDs: >> >> gEfiMdePkgTokenSpaceGuid.PcdSpinLockTimeout: in tick unit depending on the >> TimerLib used >> gEfiMdePkgTokenSpaceGuid.PcdUsbTransferTimeoutValue: in 1ms unit >> gPcAtChipsetPkgTokenSpaceGuid.PcdHpetDefaultTimerPeriod: in 100ns unit >> >> gEfiMdeModulePkgTokenSpaceGuid.PcdSataSpinUpDelayInSecForRecoveryPat >> h: in 1s unit >> gUefiCpuPkgTokenSpaceGuid.PcdCpuInitIpiDelayInMicroSeconds: in 1us unit >> gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmApSyncTimeout: in 1us unit >> gEfiSourceLevelDebugPkgTokenSpaceGuid.PcdUsbXhciDebugDetectTimeout: in >> 1us unit >> >> 1 uses timer ticks as unit. >> 1 uses as unit. >> 1 uses ms as unit. >> 3 use us as unit. >> 1 uses 100ns as unit. >> >> UefiCpuPkg uses us consistently as the unit. >> So how about using us for this PCD as well? >> And don't forget to name the PCD as >> "PcdCpuApStatusCheckIntervalInMicroSeconds" so developers who set the PCD >> can be aware by reading the name. > > > Hello Ray, > > Agree with your suggestion. > I will follow up with this approach and provide a new version of the patch. Works for me, too. Thanks! Laszlo