From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web11.4249.1590580098308366519 for ; Wed, 27 May 2020 04:48:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=g3rcMtgO; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590580097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7sZdc/C+10w/IqH/S4ju3HttbbizgAnIZkOn7VFm+Sg=; b=g3rcMtgOGQ7vMqOemDeSPXQF0MjrFpBc+KBdaFpXvNhmPGONQppiSkYnmNmS25pUU8GPWX ZQVBQGzKMFFksflmkEatUxdS7LWErBAt14b0l10KPDPb96anKCyt7+BZUj4mRJy5Xrs/QE NY7r5gHhFlYiIWB0LTIroXPEhYX/0/o= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-189-KL5ECkcTO6SI8kbEgDTKFg-1; Wed, 27 May 2020 07:48:16 -0400 X-MC-Unique: KL5ECkcTO6SI8kbEgDTKFg-1 Received: by mail-ej1-f70.google.com with SMTP id ng1so8767494ejb.22 for ; Wed, 27 May 2020 04:48:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=7sZdc/C+10w/IqH/S4ju3HttbbizgAnIZkOn7VFm+Sg=; b=D3BqPanF62WsPEtIjtEGgp6de89TeNsathV8IqlQ8Ex3HiutI1PSW2BH4Xo0EaFTGo FxMxcdK5+Vg8Jl1uQVXIVsu9NIcg/I0lwaGHHVrRx2JBcUzO77JsSHnJWZThl+1HyVm/ 4LimYa5eFJLevVeYKHz3X2FdlKAEAqEcmjyLiVCGIOAZnq4EdKUuvQ9gaZq0KCb0Zs4O CaCuiS+/D21nVZ0c3+c4rGvCTteOIRIehNdR8nsMr7v8LlowsT8pyZZDqls20jnS3w9v dlpTf9TZL2XY7k1PIKUBzykpNDC/gXCvBC2sBerhPSk2AVNrjcJfu5q2u6r0ADXqX+dw ZlyA== X-Gm-Message-State: AOAM531E30Q1UNNnIgDfiRaD0QiUOiGZgOfRvXioh4f3FCHXiZ2qmCl8 dO7aB02wB/BQRUD+5JBXU2ecBAhDHTuQVeMB0KeXZsD0uGeuHZUvN6AlYXgwJmylWg759+DdFJX rzqt6+mM1VcXBkw== X-Received: by 2002:a17:906:b293:: with SMTP id q19mr3516733ejz.412.1590580093875; Wed, 27 May 2020 04:48:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyW2CUrlUREDr8u1gD6uFlK2uL+t48G2qZ/LQswRasb+wuP4Ew7usacLird4d5kbsGrvIBZPA== X-Received: by 2002:a17:906:b293:: with SMTP id q19mr3516707ejz.412.1590580093597; Wed, 27 May 2020 04:48:13 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (71.red-88-21-204.staticip.rima-tde.net. [88.21.204.71]) by smtp.gmail.com with ESMTPSA id p10sm2589791ejn.64.2020.05.27.04.48.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 May 2020 04:48:13 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH v1 05/11] ArmPlatformPkg: Dynamic flash variable base To: devel@edk2.groups.io, sami.mujawar@arm.com Cc: ard.biesheuvel@arm.com, leif@nuviainc.com, Alexandru.Elisei@arm.com, Andre.Przywara@arm.com, Matteo.Carlini@arm.com, Laura.Moretta@arm.com, nd@arm.com References: <20200514084019.71368-1-sami.mujawar@arm.com> <20200514084019.71368-6-sami.mujawar@arm.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: <3a0b1732-d7a9-526f-1f99-bedf7302470d@redhat.com> Date: Wed, 27 May 2020 13:48:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200514084019.71368-6-sami.mujawar@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 5/14/20 10:40 AM, Sami Mujawar wrote: > Some virtual machine managers like kvmtool can relocate > the devices in the system memory map. The information > about the devices location in memory is described in the > device tree. Therefore, the CFI memory region and the > associated Non volatile storage variables need to be > adjusted accordingly. > > To support such use cases the non-volatile storage > variable base PCD PcdFlashNvStorageVariableBase has > been defined as a dynamic PCD. > > The NOR flash driver was using the Flash non-volatile > storage variable base PCD as a fixed PCD, thereby > preventing runtime resolution of the variable base > address. > > Therefore update the NOR flash driver to load the > PCD using PcdGet32 instead of FixedPcdGet32. > > Signed-off-by: Sami Mujawar > --- > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashFvbDxe.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashFvbDxe.c b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashFvbDxe.c > index e248fdf6db94191648b5d33bf1a9263f446ee141..9cdd85096a463f69b3b864cecdeaf247e65f4f73 100644 > --- a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashFvbDxe.c > +++ b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashFvbDxe.c > @@ -1,6 +1,6 @@ > /*++ @file NorFlashFvbDxe.c > > - Copyright (c) 2011 - 2014, ARM Ltd. All rights reserved.
> + Copyright (c) 2011 - 2020, ARM Ltd. All rights reserved.
> > SPDX-License-Identifier: BSD-2-Clause-Patent > > @@ -736,7 +736,7 @@ NorFlashFvbInitialize ( > EFI_MEMORY_UC | EFI_MEMORY_RUNTIME); > ASSERT_EFI_ERROR (Status); > > - mFlashNvStorageVariableBase = FixedPcdGet32 (PcdFlashNvStorageVariableBase); > + mFlashNvStorageVariableBase = PcdGet32 (PcdFlashNvStorageVariableBase); > > // Set the index of the first LBA for the FVB > Instance->StartLba = (PcdGet32 (PcdFlashNvStorageVariableBase) - Instance->RegionBaseAddress) / Instance->Media.BlockSize; > Reviewed-by: Philippe Mathieu-Daude