From: "wenyi,xie" <xiewenyi2@huawei.com>
To: "Chang, Abner (HPS SW/FW Technologist)" <abner.chang@hpe.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Wang, Nickle (Server BIOS)" <nickle.wang@hpe.com>
Cc: "songdongkuang@huawei.com" <songdongkuang@huawei.com>
Subject: Re: [PATCH EDK2 v1 0/1] RedfishPkg/RedfishRestExDxe:Simplify status check
Date: Thu, 20 Jan 2022 20:01:14 +0800 [thread overview]
Message-ID: <3a28d165-ed93-d932-886c-82d5617dfccd@huawei.com> (raw)
In-Reply-To: <PH7PR84MB1885C8781C634D38B77E1811FF5A9@PH7PR84MB1885.NAMPRD84.PROD.OUTLOOK.COM>
On 2022/1/20 10:30, Chang, Abner (HPS SW/FW Technologist) wrote:
> Hi Wenyi,
> Could you please create PR for this change? So we can have core CI on this patch and I can also merge this patch later when the core CI is finished successfully.
> Just send me the link to PR once you create it.
>
Sure, here's the link.
https://github.com/tianocore/edk2/pull/2429
Thanks
Wenyi
> Thanks
> Abner
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> *From:* xiewenyi (A) <xiewenyi2@huawei.com>
> *Sent:* Wednesday, January 19, 2022 3:39 PM
> *To:* Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; devel@edk2.groups.io <devel@edk2.groups.io>; Wang, Nickle (Server BIOS) <nickle.wang@hpe.com>
> *Cc:* songdongkuang@huawei.com <songdongkuang@huawei.com>
> *Subject:* Re: [PATCH EDK2 v1 0/1] RedfishPkg/RedfishRestExDxe:Simplify status check
>
>
>
> On 2022/1/19 15:29, Chang, Abner (HPS SW/FW Technologist) wrote:
>> Hi Wenyi,
>> May I know what is the problem you encountered and what environment causes the issue? Is that under edk2 emulation or the real Redfish service?
>>
> Hi Abner,
> I didn't encounter any issue and there's no functional change in this patch, just try to simplify the code. Please review whether it's OK or not.
>
> Thanks
> Wenyi
>> Thanks
>> Abner
>> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>> *From:* Wenyi Xie <xiewenyi2@huawei.com>
>> *Sent:* Wednesday, January 19, 2022 2:12 PM
>> *To:* devel@edk2.groups.io <devel@edk2.groups.io>; Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>; Wang, Nickle (Server BIOS) <nickle.wang@hpe.com>
>> *Cc:* songdongkuang@huawei.com <songdongkuang@huawei.com>; xiewenyi2@huawei.com <xiewenyi2@huawei.com>
>> *Subject:* [PATCH EDK2 v1 0/1] RedfishPkg/RedfishRestExDxe:Simplify status check
>>
>> Main Changes :
>> 1.Remove redundant if statement.
>>
>> Wenyi Xie (1):
>> RedfishPkg/RedfishRestExDxe:Simplify status check
>>
>> RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c | 38 +++++++++-----------
>> 1 file changed, 17 insertions(+), 21 deletions(-)
>>
>> --
>> 2.20.1.windows.1
>>
next prev parent reply other threads:[~2022-01-20 12:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 6:12 [PATCH EDK2 v1 0/1] RedfishPkg/RedfishRestExDxe:Simplify status check wenyi,xie
2022-01-19 6:12 ` [PATCH EDK2 v1 1/1] " wenyi,xie
2022-01-19 7:29 ` [PATCH EDK2 v1 0/1] " Abner Chang
2022-01-19 7:39 ` wenyi,xie
2022-01-20 2:30 ` Abner Chang
2022-01-20 12:01 ` wenyi,xie [this message]
2022-01-20 13:37 ` [edk2-devel] " Abner Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a28d165-ed93-d932-886c-82d5617dfccd@huawei.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox