Re: [edk2-devel] [PATCH v2 1/7] MdePkg/BaseLib: AARCH64: Add ArmReadCntPctReg()

["PierreGondois" <pierre.gondois@arm.com>]

On 11/9/23 15:11, Leif Lindholm wrote:
> On Thu, Nov 09, 2023 at 10:23:01 +0100, Pierre Gondois wrote:
>> To enable AARCH64 native instruction support for Openssl,
>> some interfaces must be implemented. OPENSSL_rdtsc() requests
>> an access to a counter to get some non-trusted entropy.
>>
>> Add ArmReadCntPctReg() to read system count.
>> A similar ArmReadCntPct() function is available in the ArmPkg,
>> but the CryptoPkg where OPENSSL_rdtsc will reside cannot rely
>> on the ArmPkg.
> 
> This is patently untrue, as can be discovered by grepping for ArmPkg
> under CryptoPkg already.

Yes right, I will update the serie in that sens,
Regards,
Pierre

> 
> Yes, we have a problematic history around how architectures that
> weren't already in tree when edk2 was first published got
> introduced at a later date. But this bit of contortionism helps no one.
> Please move this to ArmPkg, which is effectively an exclave of MdePkg
> anyway.
> 
> (Yes, there is an argument for moving ArmLib into MdePkg, but that
> quickly escalates through dependencies to moving all of ArmPkg into
> MdePkg, and that's a fairly big task.)
> 
> /
>      Leif
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111023): https://edk2.groups.io/g/devel/message/111023
Mute This Topic: https://groups.io/mt/102482399/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-