From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id EEE22740051 for ; Fri, 10 Nov 2023 09:04:10 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=/S3V8exF4Gs46LCrBNh87icrw7b9iummHFXRErI8RCg=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699607049; v=1; b=Av3FfHAyeyxeVf+OdK3FKx/Qtj7wE9XkXbSJKvlJpofdNf0uSyEC+Qd6nPyNp5yFo/O4nOTQ AwoAOnO1jcfHAb5J8VSCJx90rB6oKvHtDewtDpwAktJCxAAbliDFFOffgLf3DmSAsjb1eWmZ1XZ ywWG4YqZc6YmkzEUAPfx8Bfc= X-Received: by 127.0.0.2 with SMTP id kkabYY7687511xJ7xOZj3kWE; Fri, 10 Nov 2023 01:04:09 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.23676.1699607048931015831 for ; Fri, 10 Nov 2023 01:04:09 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 67817106F; Fri, 10 Nov 2023 01:04:52 -0800 (PST) X-Received: from [192.168.1.25] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A64343F6C4; Fri, 10 Nov 2023 01:04:05 -0800 (PST) Message-ID: <3a3c03c5-1c81-447f-b4c2-f58b1d5cc7fe@arm.com> Date: Fri, 10 Nov 2023 10:04:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v2 1/7] MdePkg/BaseLib: AARCH64: Add ArmReadCntPctReg() To: Leif Lindholm Cc: devel@edk2.groups.io, Jiewen Yao , Yi Li , Xiaoyu Lu , Guomin Jiang , Ard Biesheuvel , Sami Mujawar , Gerd Hoffmann , Michael D Kinney , Liming Gao References: <20231109092307.1770332-1-pierre.gondois@arm.com> <20231109092307.1770332-2-pierre.gondois@arm.com> From: "PierreGondois" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: YWZRNXR65CdluG0P1fOH62jTx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Av3FfHAy; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 11/9/23 15:11, Leif Lindholm wrote: > On Thu, Nov 09, 2023 at 10:23:01 +0100, Pierre Gondois wrote: >> To enable AARCH64 native instruction support for Openssl, >> some interfaces must be implemented. OPENSSL_rdtsc() requests >> an access to a counter to get some non-trusted entropy. >> >> Add ArmReadCntPctReg() to read system count. >> A similar ArmReadCntPct() function is available in the ArmPkg, >> but the CryptoPkg where OPENSSL_rdtsc will reside cannot rely >> on the ArmPkg. >=20 > This is patently untrue, as can be discovered by grepping for ArmPkg > under CryptoPkg already. Yes right, I will update the serie in that sens, Regards, Pierre >=20 > Yes, we have a problematic history around how architectures that > weren't already in tree when edk2 was first published got > introduced at a later date. But this bit of contortionism helps no one. > Please move this to ArmPkg, which is effectively an exclave of MdePkg > anyway. >=20 > (Yes, there is an argument for moving ArmLib into MdePkg, but that > quickly escalates through dependencies to moving all of ArmPkg into > MdePkg, and that's a fairly big task.) >=20 > / > Leif >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111023): https://edk2.groups.io/g/devel/message/111023 Mute This Topic: https://groups.io/mt/102482399/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-