From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out01.mta.xmission.com (out01.mta.xmission.com [166.70.13.231]) by mx.groups.io with SMTP id smtpd.web11.3.1584750758580719716 for ; Fri, 20 Mar 2020 17:32:38 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: bsdio.com, ip: 166.70.13.231, mailfrom: rebecca@bsdio.com) Received: from in02.mta.xmission.com ([166.70.13.52]) by out01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jFS44-0005oV-8E; Fri, 20 Mar 2020 18:32:36 -0600 Received: from mta5.zcs.xmission.com ([166.70.13.69]) by in02.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1jFS43-0000QW-DG; Fri, 20 Mar 2020 18:32:36 -0600 Received: from localhost (localhost [127.0.0.1]) by mta5.zcs.xmission.com (Postfix) with ESMTP id 042D31280803; Fri, 20 Mar 2020 18:32:35 -0600 (MDT) X-Amavis-Modified: Mail body modified (using disclaimer) - mta5.zcs.xmission.com Received: from mta5.zcs.xmission.com ([127.0.0.1]) by localhost (mta5.zcs.xmission.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 4vqVYZFr2Ehw; Fri, 20 Mar 2020 18:32:34 -0600 (MDT) Received: from photon.int.bluestop.org (muon.bluestop.org [65.103.231.193]) by mta5.zcs.xmission.com (Postfix) with ESMTPSA id 7364612806A6; Fri, 20 Mar 2020 18:32:34 -0600 (MDT) To: devel@edk2.groups.io, abner.chang@hpe.com Cc: Bret Barkelew , Sean Brogan , Bob Feng , Leif Lindholm , Michael D Kinney , Liming Gao , Gilbert Chen , Daniel Helmut Schaefer References: <20200309095318.7331-1-abner.chang@hpe.com> <20200309095318.7331-4-abner.chang@hpe.com> From: "Rebecca Cran" Message-ID: <3a585769-cede-f3fb-86a2-6d00c6cde3c4@bsdio.com> Date: Fri, 20 Mar 2020 18:32:33 -0600 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200309095318.7331-4-abner.chang@hpe.com> X-XM-SPF: eid=1jFS43-0000QW-DG;;;mid=<3a585769-cede-f3fb-86a2-6d00c6cde3c4@bsdio.com>;;;hst=in02.mta.xmission.com;;;ip=166.70.13.69;;;frm=rebecca@bsdio.com;;;spf=pass X-SA-Exim-Connect-IP: 166.70.13.69 X-SA-Exim-Mail-From: rebecca@bsdio.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa04.xmission.com X-Spam-Level: X-Spam-Status: No, score=0.8 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,T_TM2_M_HEADER_IN_MSG,T_TooManySym_01, T_TooManySym_02,TooManyTo_001,XMSubLong autolearn=disabled version=3.4.2 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * 0.7 XMSubLong Long Subject * 0.3 TooManyTo_001 Multiple "To" Header Recipients 2x (uncommon) * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa04 1397; IP=ok Body=1 Fuz1=1] [Fuz2=1] * 0.0 T_TooManySym_02 5+ unique symbols in subject * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa04 1397; IP=ok Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ;devel@edk2.groups.io, abner.chang@hpe.com X-Spam-Relay-Country: X-Spam-Timing: total 642 ms - load_scoreonly_sql: 0.06 (0.0%), signal_user_changed: 13 (2.0%), b_tie_ro: 11 (1.8%), parse: 1.05 (0.2%), extract_message_metadata: 3.6 (0.6%), get_uri_detail_list: 0.45 (0.1%), tests_pri_-1000: 2.8 (0.4%), tests_pri_-950: 1.18 (0.2%), tests_pri_-900: 0.94 (0.1%), tests_pri_-90: 55 (8.6%), check_bayes: 54 (8.4%), b_tokenize: 5.0 (0.8%), b_tok_get_all: 6 (0.9%), b_comp_prob: 1.69 (0.3%), b_tok_touch_all: 39 (6.1%), b_finish: 0.71 (0.1%), tests_pri_0: 548 (85.3%), check_dkim_signature: 0.55 (0.1%), check_dkim_adsp: 49 (7.6%), poll_dns_idle: 43 (6.7%), tests_pri_10: 2.4 (0.4%), tests_pri_500: 12 (1.8%), rewrite_mail: 0.00 (0.0%) Subject: Re: [edk2-devel] [edk2/master PATCH RISC-V CI v2 3/5] BaseTools: Enable RISC-V architecture for RISC-V EDK2 CI. X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US On 2020-03-09 03:53, Abner Chang wrote: > @@ -83,3 +90,27 @@ class LinuxGcc5ToolChain(IUefiBuildPlugin): > return -2 > > return 0 > + > + def _check_riscv64(self): > + # check to see if full path already configured > + if shell_environment.GetEnvironment().get_shell_var("GCC5_RISCV64_PREFIX") is not None: > + self.Logger.info("GCC5_RISCV64_PREFIX is already set.") Just a nit: I think the normal Python style is to have two lines between functions, not one. You can check with pyflakes. -- Rebecca Cran