From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web08.6334.1610534569279613586
 for <devel@edk2.groups.io>;
 Wed, 13 Jan 2021 02:42:49 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JzCCI9qW;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1610534568;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=hEt46N7aJYjMp9DnYkhvT7zynUTvvvUs7Zqc0r8ICkA=;
	b=JzCCI9qWGYUvyvCCWXX/wdLkSboWbN27SzwRA4te+IVsxcO5pq9DpSxRngOOK6O7ZGeDvy
	TI1dEewd3agqfR+/UBiWdy2PVe8q7kv6P8vKn2/e5u5sdFAUXfrp4bu2j+siX3PJ5FfmJY
	FYost9z88AYy4hTMw9e/n2zs1O9MPhk=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-63-mebu5oATMLaYRxWSR5fqYw-1; Wed, 13 Jan 2021 05:42:46 -0500
X-MC-Unique: mebu5oATMLaYRxWSR5fqYw-1
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ABF49107ACFA;
	Wed, 13 Jan 2021 10:42:43 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-238.ams2.redhat.com [10.36.112.238])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 5776E60BF1;
	Wed, 13 Jan 2021 10:42:39 +0000 (UTC)
Subject: Re: [PATCH v5 00/10] Add extra pci roots support for Arm
To: Jiahui Cen <cenjiahui@huawei.com>, devel@edk2.groups.io
Cc: Jordan Justen <jordan.l.justen@intel.com>,
 Ard Biesheuvel <ard.biesheuvel@arm.com>, Rebecca Cran <rebecca@bsdio.com>,
 Peter Grehan <grehan@freebsd.org>, Anthony Perard
 <anthony.perard@citrix.com>, Julien Grall <julien@xen.org>,
 Leif Lindholm <leif@nuviainc.com>, Sami Mujawar <sami.mujawar@arm.com>,
 xieyingtai@huawei.com, wu.wubin@huawei.com, Yubo Miao <miaoyubo@huawei.com>
References: <20210113103331.10375-1-cenjiahui@huawei.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <3a5dec3e-9050-8dfc-e64d-1d278b5c7123@redhat.com>
Date: Wed, 13 Jan 2021 11:42:39 +0100
MIME-Version: 1.0
In-Reply-To: <20210113103331.10375-1-cenjiahui@huawei.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 01/13/21 11:33, Jiahui Cen wrote:
> v4->v5:
> * Revert some risky renames.
> * Explicitly list PcdLib dependency.
> * Fix issues reported by PatchCheck.py.

... I wasn't done reviewing v4, I just stopped reviewing the v4 series
for today. (There's only so much review I can perform in a single day --
I spent a bit more than two hours reviewing patches 1-5 in the v4 series.)

I think I'll ignore v5 for now, and continue with the rest of v4
tomorrow (patch #6 and onwards). Then I'll compare v4 <-> v6.

Thanks
Laszlo