From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id CAFC3780091 for ; Thu, 22 Feb 2024 16:29:06 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=D+hrx5X8RaMUMmiB80+hXfUAcvp3bf1BqXREmicFvi0=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1708619345; v=1; b=TeND7dMdeoL6GImnSIfNY9uAR/QlkHJGfx6G+U9DpfRMhomrbGmG7lhLSc08ZFqMthxDOxOt zq5x8NbhFEeW9qxYSwsHFbuzgT7p7kJnSPmOcNwyyEfeq8Y5hz+9Tuo1K2w31ybCUBKhnMoiJg3 fZncQ2CnWieVY7DUltlQG0AE= X-Received: by 127.0.0.2 with SMTP id ct1GYY7687511xmaEYwiB7iR; Thu, 22 Feb 2024 08:29:05 -0800 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (NAM10-MW2-obe.outbound.protection.outlook.com [40.107.94.62]) by mx.groups.io with SMTP id smtpd.web10.17259.1708619344791328606 for ; Thu, 22 Feb 2024 08:29:04 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m+rJRLI4on6tLeimTtglsUvHbaOYGDudDRTqt9knpS3lmzAqGIbvWu2TWVtKArntEuOJ8VxnCDUkzLrgoVP0fF0GPmlOzw8dAOIcSooUxuoQ+2+pQfRlo7vluvRM82oaY9bTh+WdZ5VPKTlK7XOQ3paqZMFz1PfSVj+V01edT1cOXqoVUxEYog4/+dSgEfZPLud5f+K/LFTyj7l3KyVtKbVHJxTzFw378HTZvG4jLw/OldcxTXPBFWkBFsXVttPBQ92tnSJw/PQNbZ/GTi+muAIfL3zp+IzfCZUu3zrbFaec9R3zfr7ZXu1orlvoXeI1DWbuMZLY3gwvhaUO1BCS6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EPaDNc49dtkrO4Xk0Y/h16S5tMtImi87i8ooB4asNjc=; b=n/eUyWe4UeY9ZI2QBn7yLXgnBk7TzFZHZcElTQhoYS/iMD8Vp1ecO8G3apvcm10mHo0FMXhKThD/UsQR+cD/X5+GEPb5x1N+rmvPHfwrlY7q+2D1CP1T0QoTpJe1GClkC4pRf/R3QUJbRPa2y/IbZEa3sgcRH0crUE/6vX0nKiy6ZWjkLBW2/8m0GjwtUrJVy51CHtlTwNYZ1fm9qZH/3bpdHWrCcaPxEulbRWF9nnBJ33jFNz5COSn+RxIBazIwPcKEt/GBl7gvtOH1u61icXxrYuIj6Lpl26r3sX1vTFyEZw3K76Z+/GMuHrnlqikUfwnmUVIMQwM3WFRMD+fxRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from CH2PR15CA0018.namprd15.prod.outlook.com (2603:10b6:610:51::28) by SA1PR12MB8966.namprd12.prod.outlook.com (2603:10b6:806:385::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.22; Thu, 22 Feb 2024 16:29:02 +0000 X-Received: from DS3PEPF000099D9.namprd04.prod.outlook.com (2603:10b6:610:51:cafe::7a) by CH2PR15CA0018.outlook.office365.com (2603:10b6:610:51::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.42 via Frontend Transport; Thu, 22 Feb 2024 16:29:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by DS3PEPF000099D9.mail.protection.outlook.com (10.167.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7292.25 via Frontend Transport; Thu, 22 Feb 2024 16:29:01 +0000 X-Received: from localhost.localdomain (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 22 Feb 2024 10:29:01 -0600 From: "Hsueh, Hong-Chih (Neo) via groups.io" To: CC: , , , , , , "Neo Hsueh" Subject: [edk2-devel] [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarchy leak upon bridge hot-unplug Date: Thu, 22 Feb 2024 10:28:21 -0600 Message-ID: <3a640aa0f5555ccc327588ef7bb8d4ba5941442d.1708619173.git.Hong-Chih.Hsueh@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF000099D9:EE_|SA1PR12MB8966:EE_ X-MS-Office365-Filtering-Correlation-Id: fbebe4cc-c357-4389-5aac-08dc33c36110 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: cDu66QIy0jVDfnW5S+jAxlbCA/898FrP1QF4LnV6VMLl6Q+m+MuwWJsZm6PZHTDEJ0TrDESkibu6W6x0aAv6mdxWZZ9xGiItrCk+SXjOx5JHuLilvUcqKep5nK2B3chhZOCfnOIcrOsBR1oBjBNf15KU+avl0foQr88yHQy5LD1aF9naNf+K9h7iPmFfch5HyL0Fcalh1G8iXCBWReyfpEEUawA/f9tN5tRRnw7hvhHoZMXawlUulAmREmXU4F3Y2XJhUmvPOt9NBkIHtmlUx9Y7dLYWVlBDPnsMNoBRE705Lmb+OTaVtkEAuVC7aEMtu6mTtHaQwWvr/4D/+c+Jgmib/8DtFe8zf8IcqXUZDx0M97lPujIRGlQrNsZEtj21aXIqGz+zKTjCtu9S6cJNgpIVMG1MMXad3HwuqPG4ZDkqK7FiWxmmMJ3cRIvTlidN0hH5OVE07pBDhF/YP4VB/7aSqegZnW5LIKf2LK31fKIoXJi+xbxeDbH2dMZbX6vTLQLWkHSbTLhSHPOgeb1dpyWXl5OVXBdiXsEraUNkcZqL9PFV/3rJZOM4IuzMgbPK7bj26YQNxqTaJZz5eCLa3zq0Ho636XT6TqARfCLeHA9GmYttF0fxS3hury/uH3UHT/Qf0TkafMdCws/cS2KpsPNMMaSc6eG//96e7VEm9QM= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2024 16:29:01.9087 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fbebe4cc-c357-4389-5aac-08dc33c36110 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF000099D9.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8966 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,hong-chih.hsueh@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: d7nqGEYCC3xvxiyDJVoGmsxUx7686176AA= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=TeND7dMd; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io A USB4 or TBT bridge can be plugged or unplugged on USB4 port. The actions = require PciHotPlugRequestNotify to add a root bridge or remove a root bridg= e completely. In the plug-unplug-plug scenerio, PciHotPlugRequestNotify will return with = no-action on second plug because bridge tree shows configured. Destroy Pci Device Tree in function PciHotPlugRequestNotify for unplug even= t to fix this issue. Cc: Feng Ding Cc: Jiangang He Signed-off-by: Neo Hsueh --- MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c b/MdeModulePkg/= Bus/Pci/PciBusDxe/PciEnumerator.c index 3f8c6e6da7..2b7af60e0a 100644 --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumerator.c @@ -2103,6 +2103,8 @@ PciHotPlugRequestNotify ( } } =20 + DestroyPciDeviceTree (Bridge); + // // End for // --=20 2.40.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115833): https://edk2.groups.io/g/devel/message/115833 Mute This Topic: https://groups.io/mt/104511503/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-