From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Thu, 08 Aug 2019 13:57:44 -0700
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 7084F83F3E;
	Thu,  8 Aug 2019 20:57:44 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-122.ams2.redhat.com [10.36.117.122])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 322165C21F;
	Thu,  8 Aug 2019 20:57:42 +0000 (UTC)
Subject: Re: [edk2-devel] [Patch 3/3] BaseTools/PatchCheck: Disable text conversion in 'git show'
To: devel@edk2.groups.io, jordan.l.justen@intel.com,
 "Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Feng, Bob C" <bob.c.feng@intel.com>, "Gao, Liming" <liming.gao@intel.com>
References: <20190802001314.25980-1-michael.d.kinney@intel.com>
 <20190802001314.25980-4-michael.d.kinney@intel.com>
 <156477054101.20290.17514635538979393303@jljusten-skl>
 <8d511f89-f2a8-4d29-65e3-cc76fee12017@redhat.com>
 <E92EE9817A31E24EB0585FDF735412F5B9D83B8A@ORSMSX113.amr.corp.intel.com>
 <156520696314.20973.15022549262963633561@jljusten-skl>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <3a753a0c-8df9-4bf1-94be-b3f2c25c61df@redhat.com>
Date: Thu, 8 Aug 2019 22:57:42 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <156520696314.20973.15022549262963633561@jljusten-skl>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 08 Aug 2019 20:57:44 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 08/07/19 21:42, Jordan Justen wrote:

> I thought adding Laszlo's settings
> to .gitattributes might amount to solving two issues with one change.

Independently of the present patch, I would be very much in favor of
tracking a .gitattributes file in the project root dir, *if* we could
also automate the following setting:

git config diff.ini.xfuncname     '^\[[A-Za-z0-9_., ]+]'

For me as a reviewer, that setting (on the submitter side) makes a huge
difference. I keep asking people to do it manually, and that gets old
really quick. Unfortunately, I don't know how to automate that config
knob from within the source tree. :(

Thanks,
Laszlo