From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.4228.1589239219909614314 for ; Mon, 11 May 2020 16:20:20 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: jeremy.linton@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7491E30E; Mon, 11 May 2020 16:20:18 -0700 (PDT) Received: from [192.168.122.166] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 139F13F68F; Mon, 11 May 2020 16:20:18 -0700 (PDT) Subject: Re: [PATCH edk2-platforms v4 0/9] BCM genet fixes To: Ard Biesheuvel , devel@edk2.groups.io Cc: Pete Batard , Jared McNeill , Andrei Warkentin , Samer El-Haj-Mahmoud References: <20200511145527.23453-1-ard.biesheuvel@arm.com> From: "Jeremy Linton" Message-ID: <3a7f455d-adcc-4aa7-54c1-1d8aff38c5f7@arm.com> Date: Mon, 11 May 2020 18:20:17 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200511145527.23453-1-ard.biesheuvel@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi, Well it looks like you fixed the tx map/unmap issue I noticed yesterday on discord as well as a couple other things that were discussed. So with the fix 2/9, Reviewed-by: Jeremy Linton Thanks, On 5/11/20 9:55 AM, Ard Biesheuvel wrote: > This fixes the multicast/broadcast/promisc handling, and switches to > ordinary page allocations for RX buffers. Patch #1 is cosmetic only. > > Note that these apply on top of the series sent out by Samer, and is > intended to be squashed into that series before merging. > > Changes since v3: > - more cosmetic tweaks in #1 > - move DmaUnmap() for TX buffers to the correct place > - use MemoryFence() instead of DSB for MMIO write ordering > - add unload support to the driver > - remove the Ax88772b driver from the RPi4 build - it is no longer needed, > and misbehaves when no cable is connected. > > Changes since v2: > - fix MDF filter handling (fixes issue reported by Samer) > - add patch to deal with ExitBootServices() so we don't leave the RX DMA > ring running when we enter the OS > > https://github.com/pftf/edk2-platforms/tree/rpi4_genet_v4_ardb > > Cc: Pete Batard > Cc: Jared McNeill > Cc: Andrei Warkentin > Cc: Samer El-Haj-Mahmoud > Cc: Jeremy Linton > > Ard Biesheuvel (9): > Silicon/Broadcom/BcmGenetDxe: whitespace/cosmetic cleanup > Silicon/Broadcom/BcmGenetDxe: add support for broadcast filtering > Silicon/Broadcom/BcmGenetDxe: fix multicast/broadcast handling > Silicon/Broadcom/BcmGenetDxe: avoid uncached memory for streaming DMA > Silicon/Broadcom/BcmGenetDxe: shut down devices on ExitBootServices() > Silicon/Broadcom/BcmGenetDxe: keep TX buffer mapped during DMA > transfer > Silicon/Broadcom/BcmGenetDxe: use MemoryFence() for MMIO write > ordering > Silicon/Broadcom/BcmGenetDxe: add unload support > Platform/RaspberryPi4: remove ASIX 88772b driver > > Platform/RaspberryPi/RPi4/RPi4.dsc | 1 - > Platform/RaspberryPi/RPi4/RPi4.fdf | 1 - > .../Drivers/Net/BcmGenetDxe/BcmGenetDxe.inf | 13 +- > .../Drivers/Net/BcmGenetDxe/GenetUtil.h | 51 +- > .../Drivers/Net/BcmGenetDxe/DriverBinding.c | 122 ++- > .../Drivers/Net/BcmGenetDxe/GenericPhy.c | 16 +- > .../Drivers/Net/BcmGenetDxe/GenetUtil.c | 787 +++++++++--------- > .../Drivers/Net/BcmGenetDxe/SimpleNetwork.c | 115 ++- > 8 files changed, 621 insertions(+), 485 deletions(-) >