public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Kun Qin" <kuqin12@gmail.com>
To: devel@edk2.groups.io
Cc: Sean Brogan <sean.brogan@microsoft.com>,
	Bret Barkelew <Bret.Barkelew@microsoft.com>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [edk2-devel] [PATCH v2 4/4] Azurepipeline: SpellCheck: Enforce Node dependency to use version 14.x
Date: Wed, 16 Jun 2021 14:08:07 -0700	[thread overview]
Message-ID: <3a843b53-28f4-0a8a-d123-faf4ae6af2dd@gmail.com> (raw)
In-Reply-To: <168886A01B551E5C.18371@groups.io>

Hi pipeline maintainers,

Could you please help reviewing this specific patch?

Thanks to Ard, the other patches in this series are already reviewed and 
merged.

Regards,
Kun

On 06/14/2021 11:34, Kun Qin via groups.io wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445
> 
> Per update from Cspell tool, the minimal requirement of Cspell 5.x
> regarding Node is 12 and above. This has caused multple Cspell failures
> during CI build validation:
> "Failed to process "**.c" TypeError: text.matchAll(...) is not a function
> or its return value is not iterable"
> 
> This change updates the lowest required node version to 14.x to support
> Cspell functionalities.
> 
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> 
> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> 
> Notes:
>      v2:
>      - Added reviewed-by tag [Ard]
> 
>   .azurepipelines/templates/spell-check-prereq-steps.yml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.azurepipelines/templates/spell-check-prereq-steps.yml b/.azurepipelines/templates/spell-check-prereq-steps.yml
> index e1570d4f2aac..98ee3cfa6bc6 100644
> --- a/.azurepipelines/templates/spell-check-prereq-steps.yml
> +++ b/.azurepipelines/templates/spell-check-prereq-steps.yml
> @@ -13,7 +13,7 @@ parameters:
>   steps:
>   - task: NodeTool@0
>     inputs:
> -    versionSpec: '10.x'
> +    versionSpec: '14.x'
>       #checkLatest: false # Optional
>     condition: and(gt(variables.pkg_count, 0), succeeded())
>   
> 

  parent reply	other threads:[~2021-06-16 21:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-14 18:34 [PATCH v2 0/4] Update Node to 14.x to resolve cspell failure Kun Qin
2021-06-14 18:34 ` [PATCH v2 1/4] StandaloneMmPkg: Core: Spelling error in comment Kun Qin
2021-06-16 14:45   ` Ard Biesheuvel
2021-06-14 18:34 ` [PATCH v2 2/4] ArmPlatformPkg: SpellCheck: Switch spellcheck CI to AuditOnly Kun Qin
2021-06-14 18:34 ` [PATCH v2 3/4] ArmPkg: SpellCheck: Update valid acronyms in ExtendedWords Kun Qin
2021-06-14 18:34 ` [PATCH v2 4/4] Azurepipeline: SpellCheck: Enforce Node dependency to use version 14.x Kun Qin
2021-06-17 22:53   ` [edk2-devel] " Sean
2021-06-15 14:29 ` [edk2-devel] [PATCH v2 0/4] Update Node to 14.x to resolve cspell failure PierreGondois
2021-06-15 16:04   ` Sean
     [not found] ` <168886A01B551E5C.18371@groups.io>
2021-06-16 21:08   ` Kun Qin [this message]
2021-06-17  2:05     ` 回复: [edk2-devel] [PATCH v2 4/4] Azurepipeline: SpellCheck: Enforce Node dependency to use version 14.x gaoliming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a843b53-28f4-0a8a-d123-faf4ae6af2dd@gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox