From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by mx.groups.io with SMTP id smtpd.web10.247.1623877688853071968 for ; Wed, 16 Jun 2021 14:08:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Uw6ZrrRk; spf=pass (domain: gmail.com, ip: 209.85.216.46, mailfrom: kuqin12@gmail.com) Received: by mail-pj1-f46.google.com with SMTP id o88-20020a17090a0a61b029016eeb2adf66so4597589pjo.4 for ; Wed, 16 Jun 2021 14:08:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZG6wObT6tKiMN6m4jJ8wxQ3mWD79MYwkqs9kJalLyzQ=; b=Uw6ZrrRkG7IsfU8HyLUccPVjhKt6V1alwFf/IWjZFW8SX/xI+gKjqm3QIarII/JyN8 CgGsaSXVMMZtaU9ogv5yyRT19xWFi6VQMKnP3/SAUt8EWQqunv37NQb7b3FnvRHIf08q Zv74Yw350cngZexNf4TxoiwB6+yxOz7omyPZBhIhSUv7rieMh8xrmWVezplKLAHv/o+a OuiWD/KRQ+LcX3w+lVMNEMl5+EZ/kLAZWA2tIGlJQvbdwWogoEQ8pIyNLlOI2Dryhisk qlYmndVaBLMupNcgvOgeVX3F+JfV0Wb2Kqty2F/UC8w/J7imVNQAWFgYwkdO3B1ug+OE 9X2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZG6wObT6tKiMN6m4jJ8wxQ3mWD79MYwkqs9kJalLyzQ=; b=p8oWoKOUKFHzGouqpJGAlh3lFiRgcSQNRTqSgUrzol2i7pFkXj5rTEVd/Y5GmcVEyR x46Xj/cELNJP1TaW8+e7iZirrYxAgLx/EEM+Xm1+KydHWjlsR/DxQEHiZMedvz4Akio9 /anR9HXVEVtuKQIcNG+B09RLXFDU7SCZBkc5WNXPeiIfd/wcbi7+T+nON3aD37W3QxFM YG+CCavB2ooYJU553V5MQpSDASBAxU5mcWbzMnsz3SmimuJppzLLlK8kdjeqQjOZaC6r F4sygPuJ2+39Up2rpAMLe6kFzWvgs+5LyPJlAapfur72IiYNOp8kdVd3j/DjOB8BreBv lHlQ== X-Gm-Message-State: AOAM5310zBWRTwApOyca3eNerzE8MKZ81Gh+yFndgH4ChgVMsnthfHUw EOparbwAJpYy7Jo882oZLDk= X-Google-Smtp-Source: ABdhPJye4bPExwnRVmeLxBYf172kGWVHJl0kHU03cc1iRIgB1fJhkxtID6yRhEAZd3LX9TzT2O/ABg== X-Received: by 2002:a17:902:a70c:b029:118:7b47:e5bf with SMTP id w12-20020a170902a70cb02901187b47e5bfmr1378848plq.9.1623877688364; Wed, 16 Jun 2021 14:08:08 -0700 (PDT) Return-Path: Received: from [192.168.50.18] ([50.35.88.161]) by smtp.gmail.com with ESMTPSA id n8sm6316185pjo.1.2021.06.16.14.08.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jun 2021 14:08:07 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH v2 4/4] Azurepipeline: SpellCheck: Enforce Node dependency to use version 14.x To: devel@edk2.groups.io Cc: Sean Brogan , Bret Barkelew , Michael D Kinney , Liming Gao , Ard Biesheuvel References: <20210614183431.1657-1-kuqin12@gmail.com> <168886A01B551E5C.18371@groups.io> From: "Kun Qin" Message-ID: <3a843b53-28f4-0a8a-d123-faf4ae6af2dd@gmail.com> Date: Wed, 16 Jun 2021 14:08:07 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <168886A01B551E5C.18371@groups.io> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi pipeline maintainers, Could you please help reviewing this specific patch? Thanks to Ard, the other patches in this series are already reviewed and merged. Regards, Kun On 06/14/2021 11:34, Kun Qin via groups.io wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445 > > Per update from Cspell tool, the minimal requirement of Cspell 5.x > regarding Node is 12 and above. This has caused multple Cspell failures > during CI build validation: > "Failed to process "**.c" TypeError: text.matchAll(...) is not a function > or its return value is not iterable" > > This change updates the lowest required node version to 14.x to support > Cspell functionalities. > > Cc: Sean Brogan > Cc: Bret Barkelew > Cc: Michael D Kinney > Cc: Liming Gao > > Signed-off-by: Kun Qin > Reviewed-by: Ard Biesheuvel > --- > > Notes: > v2: > - Added reviewed-by tag [Ard] > > .azurepipelines/templates/spell-check-prereq-steps.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.azurepipelines/templates/spell-check-prereq-steps.yml b/.azurepipelines/templates/spell-check-prereq-steps.yml > index e1570d4f2aac..98ee3cfa6bc6 100644 > --- a/.azurepipelines/templates/spell-check-prereq-steps.yml > +++ b/.azurepipelines/templates/spell-check-prereq-steps.yml > @@ -13,7 +13,7 @@ parameters: > steps: > - task: NodeTool@0 > inputs: > - versionSpec: '10.x' > + versionSpec: '14.x' > #checkLatest: false # Optional > condition: and(gt(variables.pkg_count, 0), succeeded()) > >