From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.14801.1641141247525986063 for ; Sun, 02 Jan 2022 08:34:08 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=k8GHORmQ; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ashraf.ali.s@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641141247; x=1672677247; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=7rLIwjPWwxcm6hTwTNpUjb5flBqeffEa7QYYHPWgUSU=; b=k8GHORmQ8h5cBbTvs0kDI4BOP6ifxgifMCVLIOgRhM4fHIeOnsUyB+oT XBRoyJO+ZTRgMqhXeDgn5ECsuLtFxizVI8YachkhFgSEk+maqVVqPBldo DJzI/uNc2PD9GLNO8k60DUuCXdMfSf+F5kG7GSDpcKkyfwpuHGWNgDhof gx/RsTgBVaBLhels29T6rwtn9sLlkoKjzYhbVH31QJUVrPeFqflqy7/pY obdtQ92My/Gry85zP3a0dO66eMoYzZDYFgwJXQ0FTNzfsrYZCHuilDHtn qYMYa5n2Ki2qXYJkUBqojHGSG3fUWf5J4JRBZbBLoJGgBiKIPCkmIZDt8 Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10214"; a="239520868" X-IronPort-AV: E=Sophos;i="5.88,256,1635231600"; d="scan'208";a="239520868" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2022 08:34:06 -0800 X-IronPort-AV: E=Sophos;i="5.88,256,1635231600"; d="scan'208";a="487598105" Received: from basfe004.gar.corp.intel.com ([10.66.129.57]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2022 08:34:03 -0800 From: "Ashraf Ali S" To: devel@edk2.groups.io Cc: Ashraf Ali S , Rangasai V Chaganty , Digant H Solanki , Sangeetha V , Ray Ni , Michael D Kinney , Liming Gao , Zhiguang Liu Subject: [PATCH] Update Graphics Info Hob FrameBufferSize Based on UEFI Spec 2.0 Date: Sun, 2 Jan 2022 22:03:51 +0530 Message-Id: <3a8e50cf4d5d293d4ce53ffbdad4b5be9bb64a41.1641141173.git.ashraf.ali.s@intel.com> X-Mailer: git-send-email 2.30.2.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3793 Basede on UEFI Spec 2.0 section 17.7.1 structure EFI_GRAPHICS_OUTPUT_PROTOCOL_MODE say FrameBufferSize should be size of UINTN, in MdePkg\Include\Guid\GraphicsInfoHob.h EFI_PEI_GRAPHICS_INFO_HOB FrameBufferSize is UINT32, UefiPayloadPkg\GraphicsOutputDxe\GraphicsOutput.c MdeModulePkg\Universal\Console\GraphicsOutputDxe\GraphicsOutput.c Private->GraphicsOutputMode.FrameBufferSize = \ GraphicsInfo->FrameBufferSize; UINT32 value is getting assigned to UINTN, in X64 build compiler will throw possible loss of data error. so update the EFI_PEI_GRAPHICS_INFO_HOB based on UEFI Spec 2.0 Signed-off-by: Ashraf Ali S Cc: Rangasai V Chaganty Cc: Digant H Solanki Cc: Sangeetha V Cc: Ray Ni Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu --- MdePkg/Include/Guid/GraphicsInfoHob.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Include/Guid/GraphicsInfoHob.h b/MdePkg/Include/Guid/GraphicsInfoHob.h index 237911e63a..92bd907f20 100644 --- a/MdePkg/Include/Guid/GraphicsInfoHob.h +++ b/MdePkg/Include/Guid/GraphicsInfoHob.h @@ -26,7 +26,7 @@ typedef struct { EFI_PHYSICAL_ADDRESS FrameBufferBase; - UINT32 FrameBufferSize; + UINTN FrameBufferSize; EFI_GRAPHICS_OUTPUT_MODE_INFORMATION GraphicsMode; } EFI_PEI_GRAPHICS_INFO_HOB; -- 2.30.2.windows.1