From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web11.1132.1634246574123444194
 for <devel@edk2.groups.io>;
 Thu, 14 Oct 2021 14:22:54 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: jeremy.linton@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AA13E11D4;
	Thu, 14 Oct 2021 14:22:53 -0700 (PDT)
Received: from [192.168.122.166] (unknown [172.31.20.19])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 39E9B3F694;
	Thu, 14 Oct 2021 14:22:53 -0700 (PDT)
Subject: Re: [PATCH 3/5] Platform/RaspberryPi: Update Linux quirk name
To: devel@edk2.groups.io
Cc: pete@akeo.ie, ardb+tianocore@kernel.org, leif@nuviainc.com,
 awarkentin@vmware.com, Sunny.Wang@arm.com, samer.el-haj-mahmoud@arm.com
References: <20211002005238.40280-1-jeremy.linton@arm.com>
 <20211002005238.40280-4-jeremy.linton@arm.com>
From: "Jeremy Linton" <jeremy.linton@arm.com>
Message-ID: <3ac8d4a4-f55c-76c6-b267-105e0e1ec221@arm.com>
Date: Thu, 14 Oct 2021 16:22:52 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <20211002005238.40280-4-jeremy.linton@arm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi,


On 10/1/21 7:52 PM, Jeremy Linton wrote:
> During review/merge of the linux ecam quirk, some logic
> was added to require the quirk name to be exactly 6
> characters, matching the MADT field its overriding.
> 
> As such, the rpi quirk here needed to be shorted by
> a character to avoid confusion.

I'm going to drop this from the v2 of this set because while the 
mainline patch has a bunch of Ack's, its stuck because we are still 
discussing whether a DSD here is the right choice.


> 
> Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
> ---
>   Platform/RaspberryPi/AcpiTables/Pci.asl | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Platform/RaspberryPi/AcpiTables/Pci.asl b/Platform/RaspberryPi/AcpiTables/Pci.asl
> index ee37b7a21e..e5fe755923 100644
> --- a/Platform/RaspberryPi/AcpiTables/Pci.asl
> +++ b/Platform/RaspberryPi/AcpiTables/Pci.asl
> @@ -65,7 +65,7 @@ DefinitionBlock (__FILE__, "SSDT", 5, "RPIFDN", "RPI4PCIE", 2)
>         Name (_DSD, Package () {
>           ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
>             Package () {
> -            Package () { "linux-ecam-quirk-id", "bcm2711" },
> +            Package () { "linux-ecam-quirk-id", "bc2711" },
>             }
>         })
>   
>