Re: [edk2-devel] [PATCH V5 3/6] MdeModulePkg: Add definitions in DEC for SPI NOR Flash SFDP driver

["Abdul Lateef Attar via groups.io" <AbdulLateef.Attar=amd.com@groups.io>]

[-- Attachment #1: Type: text/plain, Size: 3608 bytes --]

Reviewed-by: Abdul Lateef Attar <abdattar@amd.com>

On 04-04-2024 14:54, abner.chang@amd.com wrote:
> From: Abner Chang<abner.chang@amd.com>
>
> BZ#: 4473
>
> Signed-off-by: Abner Chang<abner.chang@amd.com>
> Cc: Liming Gao<gaoliming@byosoft.com.cn>
> Cc: Jian J Wang<jian.j.wang@intel.com>
> Cc: Abdul Lateef Attar<abdattar@amd.com>
> ---
>   MdeModulePkg/MdeModulePkg.dec | 28 +++++++++++++++++++++++++++-
>   1 file changed, 27 insertions(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
> index a82dedc070d..050871cdf6b 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -9,7 +9,7 @@
>   # (C) Copyright 2016 - 2019 Hewlett Packard Enterprise Development LP<BR>
>   # Copyright (c) 2017, AMD Incorporated. All rights reserved.<BR>
>   # Copyright (c) Microsoft Corporation.<BR>
> -# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
> +# Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.<BR>
>   # SPDX-License-Identifier: BSD-2-Clause-Patent
>   #
>   ##
> @@ -454,6 +454,12 @@
>     ## GUID used for Boot Discovery Policy FormSet guid and related variables.
>     gBootDiscoveryPolicyMgrFormsetGuid = { 0x5b6f7107, 0xbb3c, 0x4660, { 0x92, 0xcd, 0x54, 0x26, 0x90, 0x28, 0x0b, 0xbd } }
>   
> +  #
> +  # SPI NOR flash JEDEC Serial Flash Discoverable Parameters (SFDP) driver GUID
> +  #
> +  gEdk2JedecSfdpSpiDxeDriverGuid  = { 0xBE71701E, 0xB63C, 0x4574, { 0x9C, 0x5C, 0x36, 0x29, 0xE8, 0xEA, 0xC4, 0x14 }}
> +  gEdk2JedecSfdpSpiSmmDriverGuid  = { 0x95A1E915, 0x195C, 0x477C, { 0x92, 0x6F, 0x7E, 0x24, 0x67, 0xC1, 0xB3, 0x1F }}
> +
>   [Ppis]
>     ## Include/Ppi/FirmwareVolumeShadowPpi.h
>     gEdkiiPeiFirmwareVolumeShadowPpiGuid = { 0x7dfe756c, 0xed8d, 0x4d77, {0x9e, 0xc4, 0x39, 0x9a, 0x8a, 0x81, 0x51, 0x16 } }
> @@ -1638,6 +1644,26 @@
>     # @Prompt The value of Retry Count,  Default value is 5.
>     gEfiMdeModulePkgTokenSpaceGuid.PcdAhciCommandRetryCount|5|UINT32|0x00000032
>   
> +  ## SPI NOR Flash operation retry counts
> +  #  0x00000000:  No retry
> +  #  0xFFFFFFFF:  Maximum retry value
> +  #
> +  # @Prompt SPI NOR Flash Operation Retry Value
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdSpiNorFlashOperationRetryCount|0x00000003|UINT32|0x00000033
> +
> +  ## SPI NOR Flash operation retry counts for the fixed timeout value
> +  #  0x00000000:  No retry
> +  #  0xFFFFFFFF:  Maximum retry value
> +  #
> +  # @Prompt SPI NOR Flash Operation Retry Value for the Fixed Timeout Value
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdSpiNorFlashFixedTimeoutRetryCount|0x0000FFFF|UINT32|0x00000034
> +
> +  ## SPI NOR Flash operation delay in microseconds
> +  #  Deafult is set to 0x00000010 microseconds
> +  #
> +  # @Prompt SPI NOR Flash Operation Delay in Microseconds (16 us)
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdSpiNorFlashOperationDelayMicroseconds|0x00000010|UINT32|0x00000035
> +
>   [PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
>     ## This PCD defines the Console output row. The default value is 25 according to UEFI spec.
>     #  This PCD could be set to 0 then console output would be at max column and max row.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117786): https://edk2.groups.io/g/devel/message/117786
Mute This Topic: https://groups.io/mt/105325720/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 4843 bytes --]