From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail04.groups.io (mail04.groups.io [45.79.224.9]) by spool.mail.gandi.net (Postfix) with ESMTPS id 032FDD811D0 for ; Mon, 15 Apr 2024 13:51:46 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=kB98ujnA7ggmSW4dNa/+4AX/iIt8cQ900+uZyaa4opA=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Language; s=20240206; t=1713189105; v=1; b=B+TqZaStiGhAeX7KbN3n2CIvK5sp+CaLIHROZ9EexU6Y3ink9QJ4MglGVBSDB7Oh09QKxT/n wl5Tzq0AtmcJiQ0lqjpQUO6qc/4Lmnmt45lI+tPnRZsS9tKvxrGSrNTw3D2pvzd2+7VdNWYpT0r bLTodoiSR8TXuMBsLLxfOf6+HHO5NK/fD/1dmWTKZllOxkkcKktQc7ACjzCdYHa36QxcSs7w+lw 82VMW3govyjqxd9ktf6a9xhgUoiZnrjcA7ek2lAGhXOsVbkGab7jXqGV9bMuxfoEcUB8k3LdyJq DBx+0cwqv2xpE1zvo+dmuVe71bU79+/8JmyVZrTJrYIjw== X-Received: by 127.0.0.2 with SMTP id GXuCYY7687511xbvjQRhXCLF; Mon, 15 Apr 2024 06:51:45 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.52]) by mx.groups.io with SMTP id smtpd.web10.21559.1713189104712583982 for ; Mon, 15 Apr 2024 06:51:45 -0700 X-Received: from IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) by PH7PR12MB9127.namprd12.prod.outlook.com (2603:10b6:510:2f6::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.50; Mon, 15 Apr 2024 13:51:41 +0000 X-Received: from IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::1a52:ef3a:cf04:e56d]) by IA1PR12MB6458.namprd12.prod.outlook.com ([fe80::1a52:ef3a:cf04:e56d%3]) with mapi id 15.20.7452.049; Mon, 15 Apr 2024 13:51:41 +0000 Message-ID: <3ad1f5ab-8b7e-4357-8ef1-70704ba13a99@amd.com> Date: Mon, 15 Apr 2024 19:21:32 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH V5 3/6] MdeModulePkg: Add definitions in DEC for SPI NOR Flash SFDP driver To: abner.chang@amd.com, devel@edk2.groups.io Cc: Liming Gao , Jian J Wang , Abdul Lateef Attar References: <20240404092455.1903-1-abner.chang@amd.com> <20240404092455.1903-4-abner.chang@amd.com> From: "Abdul Lateef Attar via groups.io" In-Reply-To: <20240404092455.1903-4-abner.chang@amd.com> X-ClientProxiedBy: BM1PR01CA0147.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:68::17) To IA1PR12MB6458.namprd12.prod.outlook.com (2603:10b6:208:3aa::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR12MB6458:EE_|PH7PR12MB9127:EE_ X-MS-Office365-Filtering-Correlation-Id: 4dabfd99-72eb-4a28-60dd-08dc5d532dbd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: 0jVBXp4kGRShPZ4Ywaijiacq3Jhkv8pWgSj8UZXVpcIkC1P8qs1LaDinOy/7TutP1RxM7LQ68bvUQq/6o3hfmv+c6BMtctPZFvk2JlBm9ZzW+R+Pg3nJWMJt9TLQqbHEgXMRIzGKnkRzHAUM+3Z4qROa5O6u1NngJZ8VsScdCXq2+AsskhGy9mHm70FxtATVwIhH40/GJXlKKUJRThF7CXTBzAEVU+DuPDJ1JnPV5yCDuLWa+BqnT9o1shOu8HfOQ15otXzl4WVEQHcKuCbnXvjG+d15h+tzhhUgvASJY+fUHBJldZKKtAhaMeVNZtkx1Us5HbH9wLXdjIbshDe32sT0vDu9PwJWxFEiSikhXuTrE4ITv5FX92k1DeLeKuawb+hhGxAF4Fhu3IFAaZ9MkCMfC7jy/CysAwzo4Rx0afckgZEH+HX5lb+n3A6OleP3iuJJz9vcEM54tx8t4wkNaStEIsDyg6O4gFZ0NMiAl0VTimabMs2fT1x1GfGW+LBNoolS94v4RNHfRjedoSE0SCU/mt5DlyBxMOqb/56zDA5ZcHonIR/636+BsDkXkK86TSeTTOrbVBFMIsihSMbEcnQmbPdSbEm9eGrEWkjKaGEJCPUfFLlxo1cKQprJXjbWYWKEUqtzCEudSjQSqWEtuONWOTU2GRVqKvHD3cUzUds= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2lDQVJSN3ZTTnJMcGhOM3o4RlJLcFh5d2grY0lQYkVCTWc3d1psZms4R24w?= =?utf-8?B?Wm9xZFBuOVZCUmRNVDlkb3FSazV4Q283a1REL3ZZdzNMZkNISWhOK202QnRJ?= =?utf-8?B?SXRGbWhSb0RwRENrejN4VStYOE43T2ZzRzFGaGxhdjNqcHZrYVJCb0V1VUFw?= =?utf-8?B?eHVwcmY3Y0RSWWF5YUc0MXdNb2dwd3hCSTRGajUvMW1MWmpVYUJtb2NRM2hM?= =?utf-8?B?ZVZmQnJZUFZrZWdEUGppNHVjRE9VN1gzOWdjRkQySUdKYzNXY1BFYmo3UlFw?= =?utf-8?B?L1ZGOEZFUkwxSWFzZDByMVdYMUJXNjgrUHQxTVhWeVkxU0hSWVF4eFBnazlL?= =?utf-8?B?b0dNMnNFeFZTSVhCQ2pvc0dybDltZVB6cWdsRmRSTER0RWtybXo2dE9LWk1w?= =?utf-8?B?QUpzcDU0N3pxRjF1dkVOM1RhRFVMN3prREJRS3lhOURUVHhMbS9YZHdjUDJP?= =?utf-8?B?K3ZSQnptM2l1eDlJdnUyQ2FIb2J2eVFXczZEN295OXBqYWU3K0h4RVhFZmo5?= =?utf-8?B?R0ZMS21yeUNyVEk3Qy9DcVZUbWkvaGdxMFJ6a1VuTU0vSE5pMDhpOXpYbllB?= =?utf-8?B?TmQ1bU5haThXSkFGRm96cG5PMXNLR3dzaE5pZ0pJd2k1Yktva09OTDVaTTZD?= =?utf-8?B?bGlUekttdGJvNVlNazZZbldxWElMVkRTVlUrR3dpdmdveGRuWXF2T2lpMHhE?= =?utf-8?B?aVc5Z05BZ3lPTVRmZS9EOGlGUDNKS1BXdXlFRUxWTWJ0MjRDNEZJdXN1akVX?= =?utf-8?B?dzEvTXVxSm5qaVNtcDlXRTJlTnBLblNFR3FyQUFWbkZiU3ZoVUFLL2d1dWIr?= =?utf-8?B?aWhQb0w3UzF0NEZTalVNMWtiY1lWeWVpMyt1NkdDZnQwSFFRNGFtK0dvQXJx?= =?utf-8?B?MEVXOEk0WDVuZ0RhdkhKcG85OGhTQ0VqNko4M0NYd0ozR0ErZmJHVENtSVU4?= =?utf-8?B?S1JFYytmb09KemZmTm1jMXgvSjRKY3BrOFpSamc2RHd2ZW1PNVE4cG5tVTI1?= =?utf-8?B?cERsWGpRUEhJVHRMcS9QSnJqYlJoejdyZjVoUUtPNkNDMlFXSkNCNFBWQURj?= =?utf-8?B?dmtIVlZOOHZMUExpa1lUSlRBMUpEcjVzSnY3ZWI5YW4yQVdBblcyU2E5TDlo?= =?utf-8?B?TjlkamhxNG1MRVpGM05wdUZhOHdzakljWExLT0dsTkI0TkhMUGZ5R2xUYzh4?= =?utf-8?B?Ym10QWdjNEpzT3p0TS9ldk96bEtkcm9XVFllRXJMUlUwVHFOU1RQb0ZaNU11?= =?utf-8?B?TkViRUVQUDV5bHN0QzNzbnpCeEpXbWNzcnFwWTlxQ0VyaWtqalVSMmRVOCtZ?= =?utf-8?B?bU9lcmJjelRJWGpiRGM5VEVTVWs5NlRMS3VmaXBaOGFHWDl2VEhDNDlERG95?= =?utf-8?B?WEtHZFF5b1Q3dXRoQ3l2ek5CbnJPeE9KQ2ZXbVVjZ0ptWm1YS2MzMklvRnF1?= =?utf-8?B?ODVqYkVEUXlwd3pGSnpqYXNhVlhKWUM3T1RVK3kvT1JWajJTSmhUalc4ZkNs?= =?utf-8?B?QXlzclNBMHJ6bm5Sb0ZpRXBaOURIbHcrN3NJazlmUFlzdU9BTGxYUUw0M3lN?= =?utf-8?B?Um5sM2phT3RwMmVEWHpleVZGemVRYXZqVkhaWE1CZ3dVQzBkL2ljZi9PcVVk?= =?utf-8?B?K1A0S0ExUzJWVlVsSkc4NW5rcVRvZjZTRGZlbUhJUWp6MVpuMTZmUndGak9l?= =?utf-8?B?ZkhRVnFRV0VZa2ZFd29iN24wTytTQ2FGYW01d1pOL1U1eEFleVpZSXU1d0hN?= =?utf-8?B?QnAvT1FDc1RKaFV6dmFlaXhVTVhRRXJpU2VDYmZpNHRLV0gxQjI4YTREMjNs?= =?utf-8?B?bkZLbDI5TDRGUlJkckJjYVBMQjNUYzV2dkdCdFRXSHZIUkRndGhDdjRJZjV4?= =?utf-8?B?cVdBaVhoV2U2bDNuVm5wM2tvQjZib1NIRWlLZlNZUk9wSU91OEM0dHB4ekQ2?= =?utf-8?B?M05yQTRERXZIdHNYZnBkaWVGbFkzT1RrUDZVOUt3Z1RHNDI5Y3pYZVZjeGRm?= =?utf-8?B?bjNhSHd2YlVCY1U3eVN3QWoxODh3Y1AvNVBKMVNlOENsdGQ5VXBVemNXTEJz?= =?utf-8?B?NUUzS0JHWS9pQ21YcGxpazhlS1ZOSFg0NDJSUGdjelR2ZkxIRkRaQW4vZWF6?= =?utf-8?Q?70vAL4jMoaUAW8fCoc7VB1ABk?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4dabfd99-72eb-4a28-60dd-08dc5d532dbd X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6458.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2024 13:51:41.4063 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: z9HJgxpijU8GnS4gepLNXrj3dvwfpbMkuD9codmn1q8ChD75puRMmLMcFRW3NkzU/e0K2DvPvaUfrA1+qfYURQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9127 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 15 Apr 2024 06:51:45 -0700 Resent-From: AbdulLateef.Attar@amd.com Reply-To: devel@edk2.groups.io,AbdulLateef.Attar@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 0Lq9ZKyJDYSzs89YHNtuJYpGx7686176AA= Content-Type: multipart/alternative; boundary="------------kxJc4wdMNGXJ7hxoVXermpSy" Content-Language: en-US X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=B+TqZaSt; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.9 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=pass (policy=none) header.from=groups.io --------------kxJc4wdMNGXJ7hxoVXermpSy Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Reviewed-by: Abdul Lateef Attar On 04-04-2024 14:54, abner.chang@amd.com wrote: > From: Abner Chang > > BZ#: 4473 > > Signed-off-by: Abner Chang > Cc: Liming Gao > Cc: Jian J Wang > Cc: Abdul Lateef Attar > --- > MdeModulePkg/MdeModulePkg.dec | 28 +++++++++++++++++++++++++++- > 1 file changed, 27 insertions(+), 1 deletion(-) > > diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.de= c > index a82dedc070d..050871cdf6b 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -9,7 +9,7 @@ > # (C) Copyright 2016 - 2019 Hewlett Packard Enterprise Development LP > # Copyright (c) 2017, AMD Incorporated. All rights reserved.
> # Copyright (c) Microsoft Corporation.
> -# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved. > +# Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved. > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > ## > @@ -454,6 +454,12 @@ > ## GUID used for Boot Discovery Policy FormSet guid and related varia= bles. > gBootDiscoveryPolicyMgrFormsetGuid =3D { 0x5b6f7107, 0xbb3c, 0x4660, = { 0x92, 0xcd, 0x54, 0x26, 0x90, 0x28, 0x0b, 0xbd } } > =20 > + # > + # SPI NOR flash JEDEC Serial Flash Discoverable Parameters (SFDP) driv= er GUID > + # > + gEdk2JedecSfdpSpiDxeDriverGuid =3D { 0xBE71701E, 0xB63C, 0x4574, { 0x= 9C, 0x5C, 0x36, 0x29, 0xE8, 0xEA, 0xC4, 0x14 }} > + gEdk2JedecSfdpSpiSmmDriverGuid =3D { 0x95A1E915, 0x195C, 0x477C, { 0x= 92, 0x6F, 0x7E, 0x24, 0x67, 0xC1, 0xB3, 0x1F }} > + > [Ppis] > ## Include/Ppi/FirmwareVolumeShadowPpi.h > gEdkiiPeiFirmwareVolumeShadowPpiGuid =3D { 0x7dfe756c, 0xed8d, 0x4d77= , {0x9e, 0xc4, 0x39, 0x9a, 0x8a, 0x81, 0x51, 0x16 } } > @@ -1638,6 +1644,26 @@ > # @Prompt The value of Retry Count, Default value is 5. > gEfiMdeModulePkgTokenSpaceGuid.PcdAhciCommandRetryCount|5|UINT32|0x00= 000032 > =20 > + ## SPI NOR Flash operation retry counts > + # 0x00000000: No retry > + # 0xFFFFFFFF: Maximum retry value > + # > + # @Prompt SPI NOR Flash Operation Retry Value > + gEfiMdeModulePkgTokenSpaceGuid.PcdSpiNorFlashOperationRetryCount|0x000= 00003|UINT32|0x00000033 > + > + ## SPI NOR Flash operation retry counts for the fixed timeout value > + # 0x00000000: No retry > + # 0xFFFFFFFF: Maximum retry value > + # > + # @Prompt SPI NOR Flash Operation Retry Value for the Fixed Timeout Va= lue > + gEfiMdeModulePkgTokenSpaceGuid.PcdSpiNorFlashFixedTimeoutRetryCount|0x= 0000FFFF|UINT32|0x00000034 > + > + ## SPI NOR Flash operation delay in microseconds > + # Deafult is set to 0x00000010 microseconds > + # > + # @Prompt SPI NOR Flash Operation Delay in Microseconds (16 us) > + gEfiMdeModulePkgTokenSpaceGuid.PcdSpiNorFlashOperationDelayMicrosecond= s|0x00000010|UINT32|0x00000035 > + > [PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] > ## This PCD defines the Console output row. The default value is 25 a= ccording to UEFI spec. > # This PCD could be set to 0 then console output would be at max col= umn and max row. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117786): https://edk2.groups.io/g/devel/message/117786 Mute This Topic: https://groups.io/mt/105325720/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --------------kxJc4wdMNGXJ7hxoVXermpSy Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Reviewed-by: Abdul Lateef Atta= r <a= bdattar@amd.com>

On 04-04-2024 14:54, abner.chang@amd.com wrote:
From: Abner Chang <abner.chang@=
amd.com>

BZ#: 4473

Signed-off-by: Abner Chang <abner.chang@amd.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Abdul Lateef Attar <abdattar@amd.com>
---
 MdeModulePkg/MdeModulePkg.dec | 28 +++++++++++++++++++++++++++-
 1 file changed, 27 insertions(+), 1 deletion(-)

diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
index a82dedc070d..050871cdf6b 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -9,7 +9,7 @@
 # (C) Copyright 2016 - 2019 Hewlett Packard Enterprise Development LP<B=
R>
 # Copyright (c) 2017, AMD Incorporated. All rights reserved.<BR>
 # Copyright (c) Microsoft Corporation.<BR>
-# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<=
BR>
+# Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.<=
BR>
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #
 ##
@@ -454,6 +454,12 @@
   ## GUID used for Boot Discovery Policy FormSet guid and related variable=
s.
   gBootDiscoveryPolicyMgrFormsetGuid =3D { 0x5b6f7107, 0xbb3c, 0x4660, { 0=
x92, 0xcd, 0x54, 0x26, 0x90, 0x28, 0x0b, 0xbd } }
=20
+  #
+  # SPI NOR flash JEDEC Serial Flash Discoverable Parameters (SFDP) driver=
 GUID
+  #
+  gEdk2JedecSfdpSpiDxeDriverGuid  =3D { 0xBE71701E, 0xB63C, 0x4574, { 0x9C=
, 0x5C, 0x36, 0x29, 0xE8, 0xEA, 0xC4, 0x14 }}
+  gEdk2JedecSfdpSpiSmmDriverGuid  =3D { 0x95A1E915, 0x195C, 0x477C, { 0x92=
, 0x6F, 0x7E, 0x24, 0x67, 0xC1, 0xB3, 0x1F }}
+
 [Ppis]
   ## Include/Ppi/FirmwareVolumeShadowPpi.h
   gEdkiiPeiFirmwareVolumeShadowPpiGuid =3D { 0x7dfe756c, 0xed8d, 0x4d77, {=
0x9e, 0xc4, 0x39, 0x9a, 0x8a, 0x81, 0x51, 0x16 } }
@@ -1638,6 +1644,26 @@
   # @Prompt The value of Retry Count,  Default value is 5.
   gEfiMdeModulePkgTokenSpaceGuid.PcdAhciCommandRetryCount|5|UINT32|0x00000=
032
=20
+  ## SPI NOR Flash operation retry counts
+  #  0x00000000:  No retry
+  #  0xFFFFFFFF:  Maximum retry value
+  #
+  # @Prompt SPI NOR Flash Operation Retry Value
+  gEfiMdeModulePkgTokenSpaceGuid.PcdSpiNorFlashOperationRetryCount|0x00000=
003|UINT32|0x00000033
+
+  ## SPI NOR Flash operation retry counts for the fixed timeout value
+  #  0x00000000:  No retry
+  #  0xFFFFFFFF:  Maximum retry value
+  #
+  # @Prompt SPI NOR Flash Operation Retry Value for the Fixed Timeout Valu=
e
+  gEfiMdeModulePkgTokenSpaceGuid.PcdSpiNorFlashFixedTimeoutRetryCount|0x00=
00FFFF|UINT32|0x00000034
+
+  ## SPI NOR Flash operation delay in microseconds
+  #  Deafult is set to 0x00000010 microseconds
+  #
+  # @Prompt SPI NOR Flash Operation Delay in Microseconds (16 us)
+  gEfiMdeModulePkgTokenSpaceGuid.PcdSpiNorFlashOperationDelayMicroseconds|=
0x00000010|UINT32|0x00000035
+
 [PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
   ## This PCD defines the Console output row. The default value is 25 acco=
rding to UEFI spec.
   #  This PCD could be set to 0 then console output would be at max column=
 and max row.
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#117786) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------kxJc4wdMNGXJ7hxoVXermpSy--