From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web11.14884.1589212261014685855
 for <devel@edk2.groups.io>;
 Mon, 11 May 2020 08:51:01 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A8DF730E;
	Mon, 11 May 2020 08:51:00 -0700 (PDT)
Received: from [192.168.1.81] (unknown [10.37.8.255])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3254F3F305;
	Mon, 11 May 2020 08:50:58 -0700 (PDT)
Subject: Re: [edk2-platform][PATCH v1 0/4] Update ASIX USB Networking drivers
To: Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>, devel@edk2.groups.io
Cc: Ray Ni <ray.ni@intel.com>, Leif Lindholm <leif@nuviainc.com>,
 Michael D Kinney <michael.d.kinney@intel.com>
References: <20200510111530.26225-1-Samer.El-Haj-Mahmoud@arm.com>
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
Message-ID: <3ae3d8da-2f51-edce-4457-b1db79e501f5@arm.com>
Date: Mon, 11 May 2020 17:50:54 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200510111530.26225-1-Samer.El-Haj-Mahmoud@arm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 5/10/20 1:15 PM, Samer El-Haj-Mahmoud wrote:
> This series updates the ASIX USB networking drivers:
> 
>   - Create new Silicon/ASIX/ package
>   - Move existing Ax88772 and Ax88772b drivers from OptionRomPkg
>     to the newly created AsixPkg
>   - Add new ASIX drivers Ax88179 and Ax88772c
> 
> Code pushed to https://github.com/samerhaj/edk2-platforms/tree/asix_usb_nic_drivers_v2
> 
> version 1: https://edk2.groups.io/g/devel/message/58771
> version 2 changes:
>   - Create new ASIX Package to host existing and new ASIX drivers[Ray]
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> 
> Signed-off-by: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> 
> Samer El-Haj-Mahmoud (4):
>    Silicon/AsixPkg: Create AsixPkg
>    Drivers/OptionRomPkg: Move ASIX drivers to AsixPkg
>    Silicon/AsixPkg: Add ASIX Ax88179 driver
>    Silicon/AsixPkg: Add ASIX Ax88772c driver
> 

I happened to have one of each of these dongles in my drawer, so I 
managed to test them both.

Both work fine, although the 88179 one was rather slow.

In any case, the 10/100 one I tried is an Apple one (05ac:1402) which is 
also supported by the 88772b driver. The only other vid/pid pair which 
that old driver supports is also supported by the new one, so I think we 
can drop the old one altogether. The non-b 7720 driver is also supported 
by the new 10/100 driver, so we can drop the old 88772 as well, afaict.