From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web08.1199.1610093814503787465 for ; Fri, 08 Jan 2021 00:16:54 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=a7qbM4Tk; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610093813; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EzsCC2O7rJ2lcAEKGUlOqG6eY/Y9lszqPWp17kgalqg=; b=a7qbM4Tk2rwpRDV9sdzCIKV5SlcHiOQF2VBTfI7ZmPC1McBIB76KSGyvmNtP34xK+z6ogC 6ZP0fKg3myhyia9VtviSZtl84GuaSSI50treGyclptLF/jCPeDhdDaEr431oJB3eaDUG7W nKOLnVrLaNpV2OhaYiAnGFTnEOfVk68= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-544-1h4ys0SOOeqQodmSSeaM-A-1; Fri, 08 Jan 2021 03:16:47 -0500 X-MC-Unique: 1h4ys0SOOeqQodmSSeaM-A-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4086E180A097; Fri, 8 Jan 2021 08:16:46 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-111.ams2.redhat.com [10.36.113.111]) by smtp.corp.redhat.com (Postfix) with ESMTP id DBD8A6062F; Fri, 8 Jan 2021 08:16:44 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase the width of the data read during oprom shadow To: devel@edk2.groups.io, sumana.venur@intel.com References: <20210108040543.11140-1-sumana.venur@intel.com> Cc: Jian J Wang , Hao A Wu , Ray Ni From: "Laszlo Ersek" Message-ID: <3ae4a361-6264-4975-4862-cab3443d81c7@redhat.com> Date: Fri, 8 Jan 2021 09:16:43 +0100 MIME-Version: 1.0 In-Reply-To: <20210108040543.11140-1-sumana.venur@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Adding PciBusDxe reviewers. Thanks Laszlo On 01/08/21 05:05, Sumana Venur wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2989 > > Long times spent on shadowing oprom from graphics card to system memory. We are currently using 8 bit read cycles. > This needs to be wider, at least 32bit reads to reduce the time for oprom shadow > > Signed-off-by: Sumana Venur > --- > MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c > index c994ed5fe3..a981f93f43 100644 > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c > @@ -521,9 +521,9 @@ LoadOpRomImage ( > // > PciDevice->PciRootBridgeIo->Mem.Read ( > PciDevice->PciRootBridgeIo, > - EfiPciWidthUint8, > + EfiPciWidthUint32, > RomBar, > - (UINT32) RomImageSize, > + (UINT32) RomImageSize/sizeof(UINT32), > Image > ); > RomInMemory = Image; >