From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 463D294177D for ; Mon, 1 Jul 2024 14:27:04 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=DAU60aiT05kj5/WI1eQybLNeTkoDRM25xdNCbrmyQD4=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:References:From:CC:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1719844024; v=1; b=rh5FdvXjk+b0BFfI/F2IFpyRl5EddqYVdygbgmWgBq+D6t7qyfEVcPsqFOu0GAFecbu7MgHN d4VkIU6pQJ1lFm1Nw26H03Xp4ePr+mnNyJwX0wvL2MX/P+xqByQmVoMQ3PZAU4MlVJKHWxTTW5t xMgj23BKnw8O8bK3FPg1Xpx2Hur7gbUb8oXbY53dPZS2ZHmSmiJd9R0Kpy8BoxyCZOse6tD8nXw d1W7Y+HZMSG6Bqz1upxA6A0rRw3VF2dhuUxnzcWfDPhjogt4P4iE22qy1OGRAlx44+TwazWTkuq ZRkk+AYJlg+uwazqRUdq/4RxfL8HbTg+DVfeZ38ZY90EQ== X-Received: by 127.0.0.2 with SMTP id t5gzYY7687511xxOmwhB4Wdp; Mon, 01 Jul 2024 07:27:02 -0700 X-Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web10.21164.1719844022226601010 for ; Mon, 01 Jul 2024 07:27:02 -0700 X-Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 461BijRX010962; Mon, 1 Jul 2024 14:27:02 GMT X-Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 403kj8skwm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 01 Jul 2024 14:27:01 +0000 (GMT) X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA01.qualcomm.com (8.17.1.19/8.17.1.19) with ESMTPS id 461ER1M4004447 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 1 Jul 2024 14:27:01 GMT X-Received: from [10.111.143.246] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 1 Jul 2024 07:27:00 -0700 Message-ID: <3aeee49f-f3d5-45c3-b7a8-7631ecb7ee96@quicinc.com> Date: Mon, 1 Jul 2024 15:26:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: use FEAT_RNG for EFI_RNG_PROTOCOL To: , Marcin Juszkiewicz References: <20240627142212.408917-1-marcin.juszkiewicz@linaro.org> <20240627142212.408917-2-marcin.juszkiewicz@linaro.org> <59847794-9dd1-4be1-b5ac-e61f22c60386@quicinc.com> <2176e4bf-dcd1-4aa5-9866-eaa852ae0fb0@linaro.org> <9b49bd01-ef9d-4a7d-8738-138a2c6c2ebd@quicinc.com> From: "Leif Lindholm" CC: Ard Biesheuvel In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: p0J1yeLxW3_OU4YcqS1x7KdX1SETaTs5 X-Proofpoint-ORIG-GUID: p0J1yeLxW3_OU4YcqS1x7KdX1SETaTs5 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 01 Jul 2024 07:27:02 -0700 Resent-From: quic_llindhol@quicinc.com Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: nxFLw2OIWdn13BfU8byv4Gsvx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=rh5FdvXj; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On 2024-07-01 14:35, Ard Biesheuvel wrote: >> Ard: would you be opposed to putting a DEBUG print and/or an ASSERT in >> BaseRngLibContructor if mRndrSupported =3D=3D 0? >> >> An alternative would be to place a test and noisy warning inside >> SbsaQemuPlatformDxe. >=20 > I'm not sure I follow what we are trying to fix here. RngDxe will > simply not load if BaseRngLib does not find FEAT_RNG support. > > If the issue is other, existing users of RngLib that are currently > served by BaseRngTimerLib, we could make the library class resolutions > introduced here local the RngDxe driver, using >=20 > SecurityPkg/RandomNumberGenerator/RngDxe/RngDxe.inf { > > RngLib|MdePkg/Library/BaseRngLib/BaseRngLib.inf > ArmTrngLib|ArmPkg/Library/ArmTrngLib/ArmTrngLib.inf > ArmMonitorLib|ArmPkg/Library/ArmMonitorLib/ArmMonitorLib.inf > } Good point. I think Ard's example solves the original purpose (providing=20 EFI_RNG_PROTOCOL to linux efi stub) while not breaking any potential=20 usage before this point. I'd still quite like to nudge existing users onto a more recent cpu, with less cryptic console output. But if we do the above we can drop the=20 conditional part and just put a test and a message in the PlatformDxe. (And have the commit message be clear on RngDxe being added.) / Leif -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119741): https://edk2.groups.io/g/devel/message/119741 Mute This Topic: https://groups.io/mt/106909459/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-