From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.89]) by mx.groups.io with SMTP id smtpd.web11.1579.1646840112672794698 for ; Wed, 09 Mar 2022 07:35:13 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=6g1jDLVF; spf=pass (domain: arm.com, ip: 40.107.21.89, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vb88dv3PZHhkuwTubwG2pK5b1DZl152VUqIYdWjPqc0=; b=6g1jDLVF0S/rKUrLkBgoPRWen8g7VvybRVx/UR2Y3AJJpSlnzaQLtND/fPZ9uT/nSc2Ep3YtjZ7L3lvPAkZQw1lilqY0+m6Hvd4UGqfSW2kPoZ3WojlYUTRFe/X9dMvGo+w2LhNkAlNficsdznrxtzhtssVZvw67Bd+2wfDXcqM= Received: from DU2P251CA0028.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::32) by AM5PR0801MB1681.eurprd08.prod.outlook.com (2603:10a6:203:3b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.15; Wed, 9 Mar 2022 15:35:08 +0000 Received: from DB5EUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:230:cafe::16) by DU2P251CA0028.outlook.office365.com (2603:10a6:10:230::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14 via Frontend Transport; Wed, 9 Mar 2022 15:35:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT052.mail.protection.outlook.com (10.152.21.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22 via Frontend Transport; Wed, 9 Mar 2022 15:35:07 +0000 Received: ("Tessian outbound 341d209a0e52:v113"); Wed, 09 Mar 2022 15:35:07 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 8d53a33eb75146d0 X-CR-MTA-TID: 64aa7808 Received: from 764fa105d044.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 07F54ACF-F11E-4E34-BB08-4F8688DBABF4.1; Wed, 09 Mar 2022 15:35:00 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 764fa105d044.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 09 Mar 2022 15:35:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VGtPnFJi09DpR2tblc0E/PbuOKJpIINpaXZ8NBSXXWq2Ceg3vzJLBk6eI0Px2t0gFDHcVYdJRO9bsJ6zmNtjo8LPcw/P8pioEkwNiQs3rf44QzSZDGRmqyGZChfjc+7M06evOQcbyDec4On7+5ZC5h7/abpSqLTbVMAdFRTjlVSZeEARtNKC5NlyFxLDYNFqXa5ND9HVkhqeqmOO2YmAqC4GAyHtBDPn6Vlk6jGcmc0mDbM1Nh0PbCy1+fnDHWkSjCgWDbmo/wJ2p8vL2w63Iu6+7iPUQmy2lcvZEPGXJDnHzA2eVtV3uyKUvoEEXAuZuNmKuh69yk2mEf7mJbZXPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vb88dv3PZHhkuwTubwG2pK5b1DZl152VUqIYdWjPqc0=; b=TDUR1yU8jl6FgYHEj8nw8b+IUNSEmJLve2LT/AwEceG1oYyYj5g30yvM/OwXcjZ0J4Tky79JV+z2Xw7OHhdlFrQWssW4+TV7JopKE2A78sScAB5OnZF73xSQKkgOGPeLxZocy6RuXQNjpRopuNO9M8Xp/scbQk1YQ72kpbsv2OIglgdrleQlEiBn2B+IRput4iK43WXrrpGnKnXTjP62IY1q6YSo3e1+xatVRSfroaroumxqiJhQxKEWAA8asZYU8s/m5Lug4xujENEMGPdqYdrWUdnSj3nfTeYAfweewcIRJ/m9+Q/BTRoJ4GAo3ETvFxUU2gZ4/rq8JwGZniASpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vb88dv3PZHhkuwTubwG2pK5b1DZl152VUqIYdWjPqc0=; b=6g1jDLVF0S/rKUrLkBgoPRWen8g7VvybRVx/UR2Y3AJJpSlnzaQLtND/fPZ9uT/nSc2Ep3YtjZ7L3lvPAkZQw1lilqY0+m6Hvd4UGqfSW2kPoZ3WojlYUTRFe/X9dMvGo+w2LhNkAlNficsdznrxtzhtssVZvw67Bd+2wfDXcqM= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from PAXPR08MB6813.eurprd08.prod.outlook.com (2603:10a6:102:15f::10) by DBBPR08MB4457.eurprd08.prod.outlook.com (2603:10a6:10:cd::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.29; Wed, 9 Mar 2022 15:34:57 +0000 Received: from PAXPR08MB6813.eurprd08.prod.outlook.com ([fe80::114a:19da:b171:82b5]) by PAXPR08MB6813.eurprd08.prod.outlook.com ([fe80::114a:19da:b171:82b5%5]) with mapi id 15.20.5038.027; Wed, 9 Mar 2022 15:34:57 +0000 Subject: Re: [PATCH 5/8] MdePkg: Define CC Measure EventLog ACPI Table To: Min Xu , devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao , Zhiguang Liu , Jiewen Yao , Jian J Wang , Ken Lu , Gerd Hoffmann , nd , Samer El-Haj-Mahmoud , thanu.rangarajan@arm.com References: <20220302002807.982-1-min.m.xu@intel.com> <20220302002807.982-6-min.m.xu@intel.com> From: "Sami Mujawar" Message-ID: <3b0b1b42-1be8-84d6-cc54-925642d4b77e@arm.com> Date: Wed, 9 Mar 2022 15:35:02 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20220302002807.982-6-min.m.xu@intel.com> X-ClientProxiedBy: LNXP265CA0029.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5c::17) To PAXPR08MB6813.eurprd08.prod.outlook.com (2603:10a6:102:15f::10) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: acd4f10a-51f0-4eef-9b07-08da01e2640a X-MS-TrafficTypeDiagnostic: DBBPR08MB4457:EE_|DB5EUR03FT052:EE_|AM5PR0801MB1681:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: vY3tbJiWSaaI32KwMsknrzPvV/SZhXpHDwny8KrKMFs0ONNuRX+Oz02oidtJR26AI1nFh0ADUegasRCRs5Rd8mddlrNB0YoInT5GVupZfnzHMXlbONb/6H9fxz1YeHBAhk/+b90mOd9QfcLOMVjAB67wxBNixcLm1ryYwOMGMurAurlqc8VUJdJQ0pUCiMzFbDy2TD93h1kVNUtaV2KAm2hsEd/ab4U6DUCofJ9CK7g406EIca3GYY4e2uWapdvY4/J4gDixFQKSTmKNQ8Z4Jc34AVqc1ntQRON+Pfwi1HZxRjjZOel3xkFbu720Xz1PxlOWiqbJuo9qoHCaAJ1Hawu6OcSt4FosxdQ31y5oX5cgszsd4GJx2Hy/0RXGqYwMykDxc8WMUtnB4cB19XpVlhuTmfy2jtI/QAQzXxU46BhHmK9D1REbi3ghYrfQn8OJ1NjBYq/xRdKY/LJh/FjChcHPFofJf99eIltwhOcxpTbwJy9vX6PXcJVobOYmVFB27Vs4YzvGdl2HD56zFHJuKRaTcpTSrTcnZySAhffoYF9cs/ifoMric5a6IZfZZ7Wob1RpmU8KLyjREkLFxX9s4xWIwwLFUHlRteGeZv2cOscV3+g6ZZAwkh4xhQLLXR94BbsJhcasWQjKM9JT9MJCm7i6+sybs3n1F4SJR0axnajaGWUEiR6ltIFpZuyzkyAgDcr1ZWwP7alZgXX9diWDrB8j8j18AkaU0KPz2ei3bqvCuIFvaOeLCtAqXh78OSKXdtEp4ZdywVMPFnnvKUftAnlAQFtsaCnLncGSsMkwrk05dRQEvRwXo3ctYUBGSG4B0dIzSllltj/BavlxE+jSSlsg9tz98pSq86GdJyAtHLu4nbL1n3KtmKM2BqTacgYS X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB6813.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(6486002)(31686004)(54906003)(31696002)(316002)(38100700002)(966005)(508600001)(66946007)(8676002)(66476007)(4326008)(6506007)(66556008)(5660300002)(2616005)(186003)(26005)(83380400001)(52116002)(53546011)(6666004)(6512007)(36756003)(44832011)(86362001)(2906002)(38350700002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4457 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3ece679d-dbce-4f3e-df60-08da01e25d76 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1L/Tp44TfPHFH0m7VoXI2x6R1gDFTy5/ym/LB6pXUqtJopohKg+BtaoOcwylyp7KuCqmluTj3AfVptoxzZ8JXsN5HB/zRAu2I/FfMuQbW/LPmQmULgveZTQA6uhIlz8n9TYjXIOQSsTD8zurSdGn0wcAKB4o2G2WZA7Y6UIcXfhvYRpkBcZhWNDTwC4quGhxI8mlmGj4ErHWIXEsOcqFl4+AWW4BeFD9LAqLWVerzpx7uz8264PFVrByIZYqNdWQFjaYvJ8T8NVtNN2IQQIzQGElyGjOysTULVRVkj54H+mjnMyOuznNLd9sFPzZSfK54WgtKr/1M6tbtO+49Z1zEbKlCSXcfYFdv4JQ117ytITEGktTlC7/l6WIIPW28v97TVoorCjEeQwBsOSr3bFUvBXzEOTmEuDD6fRV25eAcPEt5kkhqLnEUXLsBe7xcz00+OLCKW3DTCDqahDZuBS8RCpuR582oyOsYfL8dO/FqJAWkRT2DAxtA2BKGu4kZA2ZK9HbCehVlth0exU2X76YUF5uEbV8GRJCgTvamB70SgrMZlRQpZJd+2d78B7+FVn34+znFbkuzB8Kxb6LL14in9Bf7XWfrMT3NsQTew/CnyhMkkyZIPDkSGUOgSAP+Y/dNZUnh9Zm8n1q/zloSZq4QVd3OE4NIkANHhvMLWaenn7PKiMlUGQA0JZ6m1yPO9busspB7mlBVGXMK8wM32biZsIYy6aUEP5cI0rzPZOeYpgxLuh5+s+8101v8Qd1QEyXn17clRAM/yfRN/4xqmABJP5AiSXQP08zZgCtDCIAsN/+LT0YZK2mJX7jsnjvvUm8X22bMBcPxOzUgfH3aJscUw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230001)(4636009)(46966006)(36840700001)(40470700004)(186003)(6666004)(336012)(2616005)(26005)(31696002)(40460700003)(2906002)(6512007)(53546011)(36756003)(82310400004)(36860700001)(6506007)(356005)(81166007)(47076005)(31686004)(5660300002)(44832011)(966005)(508600001)(70586007)(6486002)(83380400001)(70206006)(8676002)(8936002)(4326008)(86362001)(316002)(54906003)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2022 15:35:07.8843 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: acd4f10a-51f0-4eef-9b07-08da01e2640a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1681 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Min, Thank you for this patch. Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 02/03/2022 12:28 AM, Min Xu wrote: > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3853 > > TDVF set up an ACPI table (EFI_CC_EVENTLOG_ACPI_TABLE) to pass the > event-log information. The event log created by the TD owner contains > the hashes to reconstruct the MRTD and RTMR registers. > > Please refer to Sec 4.3.3 in blow link: > https://www.intel.com/content/dam/develop/external/us/en/documents/ > intel-tdx-guest-hypervisor-communication-interface-1.0-344426-002.pdf > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Ken Lu > Cc: Sami Mujawar > Cc: Gerd Hoffmann > Signed-off-by: Min Xu > --- > MdePkg/Include/Protocol/CcMeasurement.h | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/MdePkg/Include/Protocol/CcMeasurement.h b/MdePkg/Include/Protocol/CcMeasurement.h > index 83eaafaf10a6..86de226c1d82 100644 > --- a/MdePkg/Include/Protocol/CcMeasurement.h > +++ b/MdePkg/Include/Protocol/CcMeasurement.h > @@ -307,4 +307,24 @@ extern EFI_GUID gEfiCcFinalEventsTableGuid; > > extern EFI_GUID gCcEventEntryHobGuid; > > +// > +// Define the CC Measure EventLog ACPI Table > +// > +#pragma pack(1) > + > +typedef struct { > + EFI_ACPI_DESCRIPTION_HEADER Header; > + UINT32 Rsvd; > + UINT64 Laml; > + UINT64 Lasa; > +} EFI_CC_EVENTLOG_ACPI_TABLE; > + > +#pragma pack() > + > +// > +// Define the signature and revision of CC Measurement EventLog ACPI Table for Td guest > +// > +#define EFI_CC_EVENTLOG_ACPI_TABLE_TD_SIGNATURE SIGNATURE_32('T', 'D', 'E', 'L') > +#define EFI_CC_EVENTLOG_ACPI_TABLE_TD_REVISION 1 [SAMI] I can see that the above macros have the _TD_ infix. Is the intention here that each architecture shall define its own signature and revision? Would it be possible to make the signature generic across architectures, e.g. "SIGNATURE_32('C', 'C', 'E', 'L')" ? [/SAMI] > + > #endif