From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.89]) by mx.groups.io with SMTP id smtpd.web09.35787.1641838702383507838 for ; Mon, 10 Jan 2022 10:18:22 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=qQrgyIiE; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.243.89, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=An90bPOyfhMx2z6nq/Dj4YAU9lzol++2+K5jnRMnUoVkenkTRj9fGFxOFcA+apu6wyzkjIIoajBrKK/3ZX8WLifFja6xbL5bGfBE93Dmq/xIm9RBcGwPKjeFNQfMUMnqUmSPteaLkdFA8ExFHo3EIRCodzrd0bzDTIUvrUU1yWRgoy2a1AcMpV9F3MfUsrZ5DuYBk5p0cnALBC9nQAkm25wS/5+3U/K16dSsT5wIxmHLzbL5O/kq7jZlPrHCBr0j3+4nkmcIZPUONlqRycQqD8bgyNid7uPSEp/PNVL3mZCzMyKKfDAhJf8+GtqFSJCXqKLUORx6zpkYV2dwjhT9zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DQOfWNE/MkcMZqnN+LKZnZ/lssX7+RLjmMCTXlpcA5Q=; b=QQXMDx5QKnn5YKFOL+jIcaSut/I+OQsmaijm6REvBCXKzZzIAuPfyKWWKji5oIdwpH2SEOo9LJIODAdJ3FaCDpPzFgj6jBQMq4/2wnIPNK99oBrOftxOnF2QZsZNzoV5gzNcvB72Ef3uE6dws3DViti9VQNDhtSP8aM0iScINLiYtDQH+LlPAgD/NCreYRIcfR4OrNKuNsg2jgd/LxMlEyiLOE00W2ydAsj3bSH2zeIB1pSDnUXbhgdPMgOZM9Mddk1R0b6wTgRJn200gdyJmB/1XmgMWvgkDRZAB0ze74x2H/IDgRXoPfebkmlM5TxwA5dB0odrUUdB9B7bspmSbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DQOfWNE/MkcMZqnN+LKZnZ/lssX7+RLjmMCTXlpcA5Q=; b=qQrgyIiE/qvz8tK2BtfVGj/VKxab7+egVargY/OF/+i7ZYDmESkfqLu+xtvz+kt3YOxB5xMrhBkB3RPyra2tJVkTqQ9ZMDqQPSgWhrAtc0VUHLQ6KKCXx2xEeDp22/is4jW/MkgnCaEYcUV9asw3KBdscK68iXBTCbJiEDhqHEE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) by DM8PR12MB5430.namprd12.prod.outlook.com (2603:10b6:8:28::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.11; Mon, 10 Jan 2022 18:18:21 +0000 Received: from DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::ccd7:e520:c726:d0b]) by DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::ccd7:e520:c726:d0b%5]) with mapi id 15.20.4867.011; Mon, 10 Jan 2022 18:18:21 +0000 Subject: Re: [PATCH] OvmfPkg/ResetVector: Removing SEV-ES CPUID bit check To: Peter Gonda Cc: devel@edk2.groups.io, James Bottomley , Min Xu , Jiewen Yao , Jordan Justen , Ard Biesheuvel , Laszlo Ersek , Erdem Aktas , Marc Orr , Brijesh Singh , Jim Mattson References: <8ff105d6-0bbe-35cd-22fb-151b6fb076c8@amd.com> From: "Lendacky, Thomas" Message-ID: <3b0c0bff-56f4-d243-5ad0-16dd2505a1b8@amd.com> Date: Mon, 10 Jan 2022 12:18:18 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: X-ClientProxiedBy: CH0PR03CA0373.namprd03.prod.outlook.com (2603:10b6:610:119::7) To DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) Return-Path: Thomas.Lendacky@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9f41f374-a404-464e-ec12-08d9d4659520 X-MS-TrafficTypeDiagnostic: DM8PR12MB5430:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1728; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VlZA/quFQT3X41O/nrw3awRpLP3xmplqYljfCMtea/Sd6fkO/Vp+C+BaQMkLj8xuL7gHrpy2KuXBzu0j7IrogvoZee7SKSnAEaQu2NWKT0AEtn+/abKWuMeGr85U7k0uP/fxvdTPL8FdWCfUsS7Tu38g6y3Cxcx4xcdoKkESWlAuYAfm2bxPVDrUp1aOaRqbUIg7kSDYAFXUGpb1X5pAiWLcDGJcWc/r5mgnxD+sZjNeu1Ob9tECAsBpHo3BOzUZEYlP9d0g77DJQMviQd8iFg+o+qWceeV2RrtQENV2IlL/iLFnL2aJ84X7VhcYbbjrSi7A7/P+Nmvj5mlJoYd915Uytg+zxqYT0Zh6cacoy08vqWSeMfdTipH2gDESoCjYxSrns77D+W/l7PvEfZfChz7NkN+XyiuGqZTWLy7oycXUmrOii4cMSmGdtMBSGgiBLJXPqnB53iyLFTF7ux2GepLTkyDOcAega7Hiq0hoB4avgVWTa1bck6LekamX6S6+xsAb4aKkJ1lcgDoMBNJFBvR8bg22suBwlYE6ko63WALnc2hz1vnBcNdHIcL+nf3PKX8PGDoDWPfDUY0U+oEtf5za7HYH2sswjY58kd11j84fkcIG73OUNFIMK6jGj1uA803TuMR60Yn++Z4xf3nB+y9lqFMbV5X3mgjapFTL2esq2ns3z/HrXazEOVvyNNe6c3C1lF3zBx0utzIfy02R+uorRf44q22npSFax+8DD3U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5229.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(54906003)(508600001)(66946007)(83380400001)(2616005)(6666004)(31686004)(6512007)(2906002)(8676002)(66556008)(5660300002)(4744005)(6916009)(31696002)(86362001)(4326008)(6506007)(53546011)(7416002)(66476007)(36756003)(8936002)(38100700002)(6486002)(186003)(26005)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZmdBbWJYT2N5VUN5Q0ExR0RYcjQxeGhpS3EyeTZDWjREM3VpQ0FucnNMTnIx?= =?utf-8?B?eC9heDVMenBUVkMzbmdpUzZRd0lUbk1KY0IxQkQ5RHROcklBaWxGd1BvYWRC?= =?utf-8?B?cVE4RXhwTHRQUnFNTE13U2JTalFTQW9jck9hZmgwcHhqcURucUxjMXo3QnNp?= =?utf-8?B?SzZNMDltM3pRQUYwT2tLQlJPaVIyTit4UU9FVktLdjlyRWx0SlZGdHFDWi9x?= =?utf-8?B?aGhWbnVDaUErYk5SYnFSOFd2L3ZyNWVxN0VWTVVISXhHR2htSmVTbk9TSmpj?= =?utf-8?B?emVNV1poQ1NDU1FJcmRMUWZYNm51dHRqeTl3MEllTHpCcEFxMFJUd0p5aU1s?= =?utf-8?B?WWsraU1WT3l5TUErdDFhOUQ4YVRjdlg5c0VJZWJmclVpL2RFLzRvSjJoR2Fp?= =?utf-8?B?eW1HWXFPYVNCM3NBUjhZdUpkZ0JUWWRGTGNZSGd6S2RXOTdVaWNhWndYZ29w?= =?utf-8?B?eDBubU5jVGljaEdRK0tuL2dBTTk2Ti8weUt2N2RUWDhYL2VQbjVIS2tlRU1D?= =?utf-8?B?ZGNacmljOXVyNklXejZWeXR1R3IwQXFFbHBwZkVEcVp0RURSQ2hET3hsaks1?= =?utf-8?B?dkhINXMyeUhaSVd1bExHdTN5b2p4dXBLVCtGSFFhU3VoVUpnTUhSUnJEMjBL?= =?utf-8?B?VUp1SWZVRFRxWm4vZWxSNzh3ay83eU1Tdzh3TmRDUDBvakJjUEw0ZjcxRlVE?= =?utf-8?B?Y2lvck9sYmxyVVZ5cmZrODlvelFoK3JZaVRmUFRNQy9qSWlLcGh4Ulc2K29y?= =?utf-8?B?ZmpIYXJDN2owWG1PT2tOY3dMRkxVdDRZNlBld0dtWEhhdTRwRDBnZFd0YWZx?= =?utf-8?B?UUpDdnVtRVgrM05pdXFneXNHWlZtWnBUdncyWDVEbjEzUlVUd3JlZUF6cnh5?= =?utf-8?B?MnpXZUVGeUtETDFtS2ZMY0RFQmJUTzJGT2pWOFNtVmU3SW4xTFFXSkwrSlBB?= =?utf-8?B?OWZRdlJ0Zncyb3pvcGhmaHJ3a05YSzdhZ2N6M0ZhYmx4NW5TMmdQSDNTT0dD?= =?utf-8?B?clhaVjZRUXdrdC91MDlSVERndUc2Ny8yY1pqNWZVYXllZng5MFc0Wk8vWGtI?= =?utf-8?B?aW5DU0YxNFVYcitqQUhhd3JVOTdEOFZxNHpmYzF0cVRMM05oNktMQ0dqeW1M?= =?utf-8?B?MUhtdXBYMHlyZnB1Ung3Z1F3bGh0OW9nN1RVQyt2UWlVKzdmRlBKK0pQR1lk?= =?utf-8?B?LzFBZjZGRXB4YkxvMlpBUkQ5QnJBeXNiOEcxc0xVV3V3Tno1U3N3MExqaGJE?= =?utf-8?B?eEZTVHQ4dC95QjQvNjdjQTB6eXVDM3VhZ2V1anRMaVNSdVdnUnlaSTY3cjRn?= =?utf-8?B?dEtCbVVxTDFITDhlZ0c2dmF6MW5BWGRqQUloU2lXWExzQVBYWVhIaHpmNi9N?= =?utf-8?B?RUFEcm5kdzRZTmU3QjR2OGtGQlkwaEFPV2xJVWZKaFRaRkdzaEE0SGg4WGJk?= =?utf-8?B?UFZoY3lTSkFhRFFjZm5uc25jWm42OHFuYlhNQjkrSjRieERUc1hSc3BqU0E1?= =?utf-8?B?dGY3dEhLVWJBREQrUGZFdzNUOXpDSFBmMWpjcHY1TElLVXY4WTk3YmROMk1x?= =?utf-8?B?TThsL3c0QmVBK3pJWGowdjNVYkkrZU5XNTFUeXQySlBvYnVKTmZyREtUbjhk?= =?utf-8?B?L3Z4ZGdwaXJybGFTb05DTjRCOWkxc01WYitpZWkvZTV4N0JUVE84dDZaajdZ?= =?utf-8?B?U1RSclY2bmtXT1MvYnFmUWp0NHJFdWU4ZFVFb3YvOGIxYkxqczRzYnVqYWV1?= =?utf-8?B?a09rdndEbk41ZXdsdmRseGg4eWw5VlpObHVwc1YxN2VNaEVjTExaVlFSUTNl?= =?utf-8?B?ZDNkTVZkVlQ3NzdNM3g4MDBpdkZMQU03eVJjQTkyRGh1MDZUK2tOdlMvdzk3?= =?utf-8?B?THJzcldjV2I0QVJVYkZyUml0UlNkTWNiNjUyYzZGd3NzakR1MmgzVm82b0pa?= =?utf-8?B?cjRZSHhpWk5JWGY5WTB5Wks5L0tBeElaL3c3UHVreVRXWnRxb3UvcjJDSkNo?= =?utf-8?B?bk4vQXBnblFCaUhzWE4zeG1NYnE2Sk5jZXF5TVg0bWI0eHJaY3o3V2YzWURj?= =?utf-8?B?eXlwamRUaVFxclJqNmVsMDJ3UjM5N0dvVmlmUUhjbDFZSEY0cjZRNzBURW9Y?= =?utf-8?B?ajJvV2VHWmZUa2lDUjdaR2hDajNMRWJNZWl1clZTWmZHRDUzR21TT3dZanhM?= =?utf-8?Q?jTLVe+8kUCYIlNKhC6J6a44=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f41f374-a404-464e-ec12-08d9d4659520 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2022 18:18:21.0727 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0XuTwIQ6ytc3iXQQWAYoPE06DzNS9S0jKZpJ5bKwDPmg4mAc8P+fBIcOzBysz6k1NfWmtqds97/zrVkn4545Sg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5430 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 1/10/22 9:29 AM, Peter Gonda wrote: > On Fri, Jan 7, 2022 at 3:54 PM Tom Lendacky wrote: >> >> On 1/7/22 11:04 AM, Peter Gonda wrote: >>> The SEV-ES bit of Fn800-001F[EAX] - Bit 3 is used for a host to >>> determine support for running SEV-ES guests. It should not be checked by >>> a guest to determine if it is running under SEV-ES. The guest should use >>> the SEV_STATUS MSR Bit 1 to determine if SEV-ES is enabled. >> >> Worth mentioning in the commit message that this check wasn't part of the >> original SEV-ES support (Fixes: a91b700e385e7484ab7286b3ba7ea2efbd59480e >> tag?), so this is really a compatibility thing, and that this makes the >> check consistent with the Linux kernel. > > Sure I update the commit message in the V2 with this info and add the > Fixes tag. Do I need a (Fixes: > b461d67639f2deced77e9bb967d014b7cfcd75f8) tag too? Since the Check was > moved between files in that commit? I don't think so, but that's just my opinion. Thanks, Tom >