public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Rebecca Cran" <rebecca@bsdio.com>
To: devel@edk2.groups.io, Andrew Fish <afish@apple.com>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Bob Feng <bob.c.feng@intel.com>,
	Yuwei Chen <yuwei.chen@intel.com>
Subject: Re: [edk2-stable202305 PATCH 0/3] BaseTools: Fix PYTHONPATH on Windows, Tests\TestTools.py and cleanup toolsetup.bat
Date: Wed, 10 May 2023 16:30:10 -0600	[thread overview]
Message-ID: <3b21c545-546c-61ed-44e1-6b0725d386a7@bsdio.com> (raw)
In-Reply-To: <20230509042524.612-1-rebecca@bsdio.com>

Mike/Liming:


I'd like to get this in for the upcoming stable tag.

The PR is https://github.com/tianocore/edk2/pull/4363 .


-- 
Rebecca Cran


On 5/8/23 22:25, Rebecca Cran wrote:
> Fix some issues in BaseTools:
>
> - When the Pip BaseTools are used, make sure PYTHONPATH is set.
> - Fix Tests\TestTools.py so it works on Windows.
> - Cleanup toolsetup.bat
>
> Rebecca Cran (3):
>    BaseTools: Update toolsetup.bat to not use BASETOOLS_PYTHON_SOURCE
>    BaseTools: only print the environment once in toolsetup.bat
>    BaseTools: Update Tests/TestTools.py to allow it to work on Windows
>
>   BaseTools/Tests/TestTools.py |  4 +-
>   BaseTools/toolsetup.bat      | 40 +++++++++-----------
>   2 files changed, 21 insertions(+), 23 deletions(-)
>

  parent reply	other threads:[~2023-05-10 22:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-09  4:25 [edk2-stable202305 PATCH 0/3] BaseTools: Fix PYTHONPATH on Windows, Tests\TestTools.py and cleanup toolsetup.bat Rebecca Cran
2023-05-09  4:25 ` [edk2-stable202305 PATCH 1/3] BaseTools: Update toolsetup.bat to not use BASETOOLS_PYTHON_SOURCE Rebecca Cran
2023-05-09  4:25 ` [edk2-stable202305 PATCH 2/3] BaseTools: only print the environment once in toolsetup.bat Rebecca Cran
2023-05-10 22:30 ` Rebecca Cran [this message]
2023-05-11  1:37   ` 回复: [edk2-devel] [edk2-stable202305 PATCH 0/3] BaseTools: Fix PYTHONPATH on Windows, Tests\TestTools.py and cleanup toolsetup.bat gaoliming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b21c545-546c-61ed-44e1-6b0725d386a7@bsdio.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox