From: Laszlo Ersek <lersek@redhat.com>
To: Jordan Justen <jordan.l.justen@intel.com>,
edk2-devel-01 <edk2-devel@ml01.01.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH] OvmfPkg/XenConsoleSerialPortLib: don't include <Uefi/UefiBaseType.h>
Date: Wed, 26 Oct 2016 12:05:36 +0200 [thread overview]
Message-ID: <3b3c2c7a-f118-5271-2053-3403cf6b578e@redhat.com> (raw)
In-Reply-To: <147741397897.26016.3788436900040258320@jljusten-ivb>
On 10/25/16 18:46, Jordan Justen wrote:
> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Thank you, commit 6c9616083c14.
Cheers
Laszlo
> On 2016-10-25 07:38:31, Laszlo Ersek wrote:
>> XenConsoleSerialPortLib is a BASE type library instance, without being
>> restricted to UEFI client modules. (For example, the
>> "ArmVirtPkg/ArmVirtXen.dsc" platform builds this library instance into
>> "ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf", which is a SEC type
>> module.) For such library instances, including <Uefi/UefiBaseType.h> is
>> not right.
>>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>> OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c b/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c
>> index 295696312413..4a63b860476d 100644
>> --- a/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c
>> +++ b/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c
>> @@ -15,7 +15,6 @@
>> **/
>>
>> #include <Base.h>
>> -#include <Uefi/UefiBaseType.h>
>>
>> #include <Library/BaseLib.h>
>> #include <Library/SerialPortLib.h>
>> --
>> 2.9.2
>>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>
prev parent reply other threads:[~2016-10-26 10:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 14:38 [PATCH] OvmfPkg/XenConsoleSerialPortLib: don't include <Uefi/UefiBaseType.h> Laszlo Ersek
2016-10-25 16:46 ` Jordan Justen
2016-10-26 10:05 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b3c2c7a-f118-5271-2053-3403cf6b578e@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox