* [PATCH] OvmfPkg/XenConsoleSerialPortLib: don't include <Uefi/UefiBaseType.h>
@ 2016-10-25 14:38 Laszlo Ersek
2016-10-25 16:46 ` Jordan Justen
0 siblings, 1 reply; 3+ messages in thread
From: Laszlo Ersek @ 2016-10-25 14:38 UTC (permalink / raw)
To: edk2-devel-01; +Cc: Ard Biesheuvel, Jordan Justen
XenConsoleSerialPortLib is a BASE type library instance, without being
restricted to UEFI client modules. (For example, the
"ArmVirtPkg/ArmVirtXen.dsc" platform builds this library instance into
"ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf", which is a SEC type
module.) For such library instances, including <Uefi/UefiBaseType.h> is
not right.
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c b/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c
index 295696312413..4a63b860476d 100644
--- a/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c
+++ b/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c
@@ -15,7 +15,6 @@
**/
#include <Base.h>
-#include <Uefi/UefiBaseType.h>
#include <Library/BaseLib.h>
#include <Library/SerialPortLib.h>
--
2.9.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] OvmfPkg/XenConsoleSerialPortLib: don't include <Uefi/UefiBaseType.h>
2016-10-25 14:38 [PATCH] OvmfPkg/XenConsoleSerialPortLib: don't include <Uefi/UefiBaseType.h> Laszlo Ersek
@ 2016-10-25 16:46 ` Jordan Justen
2016-10-26 10:05 ` Laszlo Ersek
0 siblings, 1 reply; 3+ messages in thread
From: Jordan Justen @ 2016-10-25 16:46 UTC (permalink / raw)
To: Laszlo Ersek, edk2-devel-01; +Cc: Ard Biesheuvel
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
On 2016-10-25 07:38:31, Laszlo Ersek wrote:
> XenConsoleSerialPortLib is a BASE type library instance, without being
> restricted to UEFI client modules. (For example, the
> "ArmVirtPkg/ArmVirtXen.dsc" platform builds this library instance into
> "ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf", which is a SEC type
> module.) For such library instances, including <Uefi/UefiBaseType.h> is
> not right.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c b/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c
> index 295696312413..4a63b860476d 100644
> --- a/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c
> +++ b/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c
> @@ -15,7 +15,6 @@
> **/
>
> #include <Base.h>
> -#include <Uefi/UefiBaseType.h>
>
> #include <Library/BaseLib.h>
> #include <Library/SerialPortLib.h>
> --
> 2.9.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] OvmfPkg/XenConsoleSerialPortLib: don't include <Uefi/UefiBaseType.h>
2016-10-25 16:46 ` Jordan Justen
@ 2016-10-26 10:05 ` Laszlo Ersek
0 siblings, 0 replies; 3+ messages in thread
From: Laszlo Ersek @ 2016-10-26 10:05 UTC (permalink / raw)
To: Jordan Justen, edk2-devel-01; +Cc: Ard Biesheuvel
On 10/25/16 18:46, Jordan Justen wrote:
> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Thank you, commit 6c9616083c14.
Cheers
Laszlo
> On 2016-10-25 07:38:31, Laszlo Ersek wrote:
>> XenConsoleSerialPortLib is a BASE type library instance, without being
>> restricted to UEFI client modules. (For example, the
>> "ArmVirtPkg/ArmVirtXen.dsc" platform builds this library instance into
>> "ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf", which is a SEC type
>> module.) For such library instances, including <Uefi/UefiBaseType.h> is
>> not right.
>>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>> OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c b/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c
>> index 295696312413..4a63b860476d 100644
>> --- a/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c
>> +++ b/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c
>> @@ -15,7 +15,6 @@
>> **/
>>
>> #include <Base.h>
>> -#include <Uefi/UefiBaseType.h>
>>
>> #include <Library/BaseLib.h>
>> #include <Library/SerialPortLib.h>
>> --
>> 2.9.2
>>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-26 10:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-25 14:38 [PATCH] OvmfPkg/XenConsoleSerialPortLib: don't include <Uefi/UefiBaseType.h> Laszlo Ersek
2016-10-25 16:46 ` Jordan Justen
2016-10-26 10:05 ` Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox