From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id F18FF1A1E29
 for <edk2-devel@ml01.01.org>; Wed, 26 Oct 2016 03:05:38 -0700 (PDT)
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
 (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 860B0C05A280;
 Wed, 26 Oct 2016 10:05:38 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-27.phx2.redhat.com
 [10.3.116.27])
 by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 u9QA5aKv007219; Wed, 26 Oct 2016 06:05:37 -0400
To: Jordan Justen <jordan.l.justen@intel.com>,
 edk2-devel-01 <edk2-devel@ml01.01.org>
References: <20161025143831.14482-1-lersek@redhat.com>
 <147741397897.26016.3788436900040258320@jljusten-ivb>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <3b3c2c7a-f118-5271-2053-3403cf6b578e@redhat.com>
Date: Wed, 26 Oct 2016 12:05:36 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <147741397897.26016.3788436900040258320@jljusten-ivb>
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.32]); Wed, 26 Oct 2016 10:05:38 +0000 (UTC)
Subject: Re: [PATCH] OvmfPkg/XenConsoleSerialPortLib: don't include <Uefi/UefiBaseType.h>
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Oct 2016 10:05:39 -0000
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

On 10/25/16 18:46, Jordan Justen wrote:
> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

Thank you, commit 6c9616083c14.

Cheers
Laszlo

> On 2016-10-25 07:38:31, Laszlo Ersek wrote:
>> XenConsoleSerialPortLib is a BASE type library instance, without being
>> restricted to UEFI client modules. (For example, the
>> "ArmVirtPkg/ArmVirtXen.dsc" platform builds this library instance into
>> "ArmVirtPkg/PrePi/ArmVirtPrePiUniCoreRelocatable.inf", which is a SEC type
>> module.) For such library instances, including <Uefi/UefiBaseType.h> is
>> not right.
>>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>>  OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c b/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c
>> index 295696312413..4a63b860476d 100644
>> --- a/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c
>> +++ b/OvmfPkg/Library/XenConsoleSerialPortLib/XenConsoleSerialPortLib.c
>> @@ -15,7 +15,6 @@
>>  **/
>>  
>>  #include <Base.h>
>> -#include <Uefi/UefiBaseType.h>
>>  
>>  #include <Library/BaseLib.h>
>>  #include <Library/SerialPortLib.h>
>> -- 
>> 2.9.2
>>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>