From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8BBB3941369 for ; Mon, 5 Feb 2024 07:45:10 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=YhtYFozZ4S6+GC/Z1ZAiYlTJQqq4DtU653rCOkghhmY=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1707119109; v=1; b=aqfsrZhXqzqNABTADr3AapByxUbeXa3kIIfM6U9wTSmgLSOSmtZA25ipIlatEbBSWQE2Lh3c EJJi2icLoXVPtOS02myM6ARlpz0UIerAdskmFRcqojW2sOJthWdY3O0jHwlVLri5PqY/m+PGHd0 SZ6Q9wXyknYDa8NQ6TjhADZc= X-Received: by 127.0.0.2 with SMTP id mCcyYY7687511xYTwlBKANSO; Sun, 04 Feb 2024 23:45:09 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.58020.1707119108662797047 for ; Sun, 04 Feb 2024 23:45:08 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-592-LiQOeXS1M6u7O2IYKQj25Q-1; Mon, 05 Feb 2024 02:45:04 -0500 X-MC-Unique: LiQOeXS1M6u7O2IYKQj25Q-1 X-Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F15AA3CBD503; Mon, 5 Feb 2024 07:45:03 +0000 (UTC) X-Received: from [10.39.192.216] (unknown [10.39.192.216]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2A8E5492BC6; Mon, 5 Feb 2024 07:45:03 +0000 (UTC) Message-ID: <3b687b34-d788-2aa3-26e9-78bf79787e81@redhat.com> Date: Mon, 5 Feb 2024 08:45:02 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v2 1/4] OvmfPkg/PlatformPei: log a warning when memory is tight To: devel@edk2.groups.io, kraxel@redhat.com Cc: Jiewen Yao , Oliver Steffen , Ard Biesheuvel References: <20240202104720.1275308-1-kraxel@redhat.com> <20240202104720.1275308-2-kraxel@redhat.com> From: "Laszlo Ersek" In-Reply-To: <20240202104720.1275308-2-kraxel@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: wENzNApHPSrjTBsMTUP0Sq8ax7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=aqfsrZhX; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 2/2/24 11:47, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/PlatformPei/MemDetect.c | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/OvmfPkg/PlatformPei/MemDetect.c b/OvmfPkg/PlatformPei/MemDet= ect.c > index 493cb1fbeb01..1684a3783546 100644 > --- a/OvmfPkg/PlatformPei/MemDetect.c > +++ b/OvmfPkg/PlatformPei/MemDetect.c > @@ -319,6 +319,14 @@ PublishPeiMemory ( > if (MemorySize > PeiMemoryCap) { > MemoryBase =3D LowerMemorySize - PeiMemoryCap; > MemorySize =3D PeiMemoryCap; > + } else { > + DEBUG (( > + DEBUG_WARN, > + "%a: Not enough memory for PEI (have %llu KB, estimated need %ll= u KB)\n", > + __func__, > + RShiftU64 (MemorySize, 10), > + RShiftU64 (PeiMemoryCap, 10) > + )); > } > } > =20 both %llu should be just %lu With that updated: Reviewed-by: Laszlo Ersek -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115100): https://edk2.groups.io/g/devel/message/115100 Mute This Topic: https://groups.io/mt/104117097/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-