From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by mx.groups.io with SMTP id smtpd.web11.56240.1598889243740254985 for ; Mon, 31 Aug 2020 08:54:04 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@broadcom.com header.s=google header.b=N8dNKD2R; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: broadcom.com, ip: 209.85.218.44, mailfrom: vladimir.olovyannikov@broadcom.com) Received: by mail-ej1-f44.google.com with SMTP id q13so5700541ejo.9 for ; Mon, 31 Aug 2020 08:54:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:references:in-reply-to:mime-version:thread-index:date :message-id:subject:to:cc; bh=agOB1JjwQFGpA111a/gDkc+wCQKCSi+Ot/Ni3j5Mor4=; b=N8dNKD2RzFl3xZ9hhgXAlFY0QQmdkM91I9h8n8ybqx/Tf/m/L+oqXxH+KOAyLDZXpx a3pwDq7VRvXA7RSkmkj8U3ZdBBR+OyVYOdEiHHB0MSyH3tM7SHaQ7GvYWAEXpAKYyH5s DL2od3/9PTkTRed9pAJeLAOPpzAmidNPixM+o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:references:in-reply-to:mime-version :thread-index:date:message-id:subject:to:cc; bh=agOB1JjwQFGpA111a/gDkc+wCQKCSi+Ot/Ni3j5Mor4=; b=MAapYjL2lXml7sV+PR9CUgB+cdbVgB0XR7eg4IbblBrO9jqtxLF0gYDLukSME9/dqo b89sda/0OPNfnAnq6ij/FgFcc63T4TpVDadYTN9mFnq1zjBhQpy+hdoDBBqnNl7Mo6SZ CZT/qbS/Z35/S1BYUzRViUI9MfAgDWVFzV0FjcD4aDjA+YxxD1eLcxo30bwBXrJ3QiPh UKQ8jJQQTESpWaC1MNC1Svh5vhbZnhbja5txN554idG5ifvjRd2Zw+bYcwcRVE7rztWu siV0qKLpro6WueVi8lCmf0N1rRUsuOS9jump/uCfgYp4jveMvF70emMYAO6PiD54Z2WU 0TMQ== X-Gm-Message-State: AOAM533zU0FZ5E8XDb75qTbqjYQVCU88DAprdVmJWHWjksQDPMZG+kIl GMkmwzohFVdlM7AxwsFI3bO8kua0nWL2ej33EvXNxQ== X-Google-Smtp-Source: ABdhPJzchnU9nYhVK2az5NAZpkIhJGSTbXcTCTYDD7DCzOIesMly/rgroUDdVz2qcp3xG1VDQM3a7gK1cpnXZUEEHeM= X-Received: by 2002:a17:906:6a84:: with SMTP id p4mr1779293ejr.374.1598889241993; Mon, 31 Aug 2020 08:54:01 -0700 (PDT) From: "Vladimir Olovyannikov" References: <20200830002847.12726-1-vladimir.olovyannikov@broadcom.com> In-Reply-To: MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQFA8MBsSI6oLUEhfBV/ukobnxwCYQIrUxzmqmwg8KA= Date: Mon, 31 Aug 2020 08:54:01 -0700 Message-ID: <3b881615f9d39fdebc07b89d9bab0183@mail.gmail.com> Subject: Re: [PATCH v9 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand To: Laszlo Ersek , devel@edk2.groups.io Cc: Zhichao Gao , Maciej Rabeda , Jiaxin Wu , Siyuan Fu , Ray Ni , Liming Gao , Nd , Samer El-Haj-Mahmoud Content-Type: text/plain; charset="UTF-8" Hi Laszlo, > -----Original Message----- > From: Laszlo Ersek > Sent: Monday, August 31, 2020 2:15 AM > To: Vladimir Olovyannikov ; > devel@edk2.groups.io > Cc: Zhichao Gao ; Maciej Rabeda > ; Jiaxin Wu ; Siyuan > Fu ; Ray Ni ; Liming Gao > ; Nd ; Samer El-Haj-Mahmoud > > Subject: Re: [PATCH v9 0/1] ShellPkg/DynamicCommand: add > HttpDynamicCommand > > Hi Vladimir, > > On 08/30/20 02:28, Vladimir Olovyannikov wrote: > > Signed-off-by: Vladimir Olovyannikov > > > > Cc: Zhichao Gao > > Cc: Maciej Rabeda > > Cc: Jiaxin Wu > > Cc: Siyuan Fu > > Cc: Ray Ni > > Cc: Liming Gao > > Cc: Nd > > Cc: Laszlo Ersek > > Cc: Samer El-Haj-Mahmoud > > > > This patchset introduces an http client utilizing EDK2 HTTP protocol, > > to allow fast image downloading from http/https servers. > > HTTP download speed is usually faster than tftp. > > The client is based on the same approach as tftp dynamic command, and > > uses the same UEFI Shell command line parameters. This makes it easy > > integrating http into existing UEFI Shell scripts. > > Note that to enable HTTP download, feature Pcd > > gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections must be set to > TRUE. > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2860 > > > > PATCH v9 changes: > > - check that Response pointer is not NULL before accessing Data > > structure > > member, to prevent possible NULL pointer dereference. > > looks like there's still intense development occurring in > HttpDynamicCommand. > > I'd like to conserve some testing effort on my end, so I'd like to test > this > feature only once more; just before it's merged. I suggest stabilizing the > feature set now, and only focusing on important bugfixes. I agree. The development phase is complete. I am not going to add new features, and the code I submitted for review is now fully in sync with my local development. I promise to just do bug fixes until it is merged in :) Thank you, Vladimir > > Thanks! > Laszlo