From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6DE622096106D for ; Mon, 14 May 2018 06:26:19 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AC3D9818A6B9; Mon, 14 May 2018 13:26:18 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-253.rdu2.redhat.com [10.10.120.253]) by smtp.corp.redhat.com (Postfix) with ESMTP id E82708445D; Mon, 14 May 2018 13:26:17 +0000 (UTC) To: Ard Biesheuvel Cc: Jordan Justen , edk2-devel-01 References: <20180512225514.30760-1-lersek@redhat.com> From: Laszlo Ersek Message-ID: <3b90dcc3-1a19-b26d-80b9-8e41124532a2@redhat.com> Date: Mon, 14 May 2018 15:26:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Mon, 14 May 2018 13:26:18 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Mon, 14 May 2018 13:26:18 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH] OvmfPkg/PlatformBootManagerLib: connect consoles unconditionally X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 May 2018 13:26:19 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05/14/18 12:28, Ard Biesheuvel wrote: > On 13 May 2018 at 00:55, Laszlo Ersek wrote: >> If both ConIn and ConOut exist, but ConIn references none of the PS/2 >> keyboard, the USB wild-card keyboard, and any serial ports, then >> PlatformInitializeConsole() currently allows the boot to proceed without >> any input devices at all. This makes for a bad user experience -- the >> firmware menu could only be entered through OsIndications, set by a guest >> OS. >> >> Do what ArmVirtQemu does already, namely connect the consoles, and add >> them to ConIn / ConOut / ErrOut, unconditionally. (The underlying >> EfiBootManagerUpdateConsoleVariable() function checks for duplicates.) >> >> The issue used to be masked by the EfiBootManagerConnectAll() call that >> got conditionalized in commit 245c643cc8b7. >> >> This patch is best viewed with "git show -b -W". >> >> Cc: Ard Biesheuvel >> Cc: Jordan Justen >> Fixes: 245c643cc8b73240c3b88cb55b2911b285a8c10d >> Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1577546 >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Laszlo Ersek > > Reviewed-by: Ard Biesheuvel Thank you (and welcome back :) ), commit f803c03cc2e0. Laszlo