Hi Gerd,


Thanks,
Chao
On 2024/3/15 17:22, Gerd Hoffmann wrote:
> On Mon, Mar 11, 2024 at 02:39:02AM -0700, Chao Li wrote:
>> This Library is used to collect APs resources, but is currently NULL
>> for OvmfPkg, because it is not used by the LoongArch virtual machine.
> What is the point of having this library then?
This NULL library will be filled in the future.
>
>> +#include <PiPei.h>
>> +#include <Library/BaseLib.h>
>> +#include <Library/HobLib.h>
>> +#include <Library/MemoryAllocationLib.h>
>> +#include <Register/LoongArch64/Csr.h>
>> +#include "../../../UefiCpuPkg/Library/MpInitLib/LoongArch64/MpLib.h"
> Including private header files of other libraries looks questionable.
OK, it will be removed next time.
>
> take care,
>    Gerd
>
>
>
> 
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117663): https://edk2.groups.io/g/devel/message/117663
Mute This Topic: https://groups.io/mt/104859891/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-