From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail03.groups.io (mail03.groups.io [45.79.227.220]) by spool.mail.gandi.net (Postfix) with ESMTPS id 13559D811A4 for ; Fri, 12 Apr 2024 08:34:40 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=F4VmtO+yT5/ZTcDqrb8p7cGyejr53gdwdK48rKDdX4g=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1712910879; v=1; b=shntquX3FhWiYnzi2DfnNCU/1QGfHPKFSKJkBqJy9apZNodWCBLGaGG5lAGCUrOp+I9AHuoX 5r9/zCV+nRIyMjjhb1mDELTnyGdFd4ZZyqEBc3xMvlb/p6WKc9qr5rWUG+mT0R74B0ChIFfrkjO VrkVjFeCyEZp2CsgxcrJE5+mcziVxJ1mkUkBzhaZi1J6TedW+eV+ew/rCn/phb/7LBbI07DYi6/ TyWudJhNas43Tero00QgsXzQWMonKfHX8D60v1tM6ivrHmGaFB/8/wteJzQKQKfaWJxkDCGLEE4 tDqkT0FzWKksiAEDFEv3pt3E+OSYYT307+DucC0vymK7A== X-Received: by 127.0.0.2 with SMTP id QFbdYY7687511xxZSs2mw3oI; Fri, 12 Apr 2024 01:34:39 -0700 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web10.42276.1712910877701098071 for ; Fri, 12 Apr 2024 01:34:38 -0700 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8AxafAY8hhmwkwmAA--.22497S3; Fri, 12 Apr 2024 16:34:32 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8AxzxMV8hhmvJh4AA--.45786S3; Fri, 12 Apr 2024 16:34:29 +0800 (CST) Message-ID: <3bc0bba7-6046-4afe-ace9-bee529a9d295@loongson.cn> Date: Fri, 12 Apr 2024 16:34:29 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 16/26] OvmfPkg/LoongArchVirt: Add a NULL library named CollectApResouceLibNull To: devel@edk2.groups.io, kraxel@redhat.com Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Bibo Mao , Dongyan Qian References: <20240311093631.1251466-1-lichao@loongson.cn> <20240311093857.1254256-1-lichao@loongson.cn> From: "Chao Li" In-Reply-To: X-CM-TRANSID: AQAAf8AxzxMV8hhmvJh4AA--.45786S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQAFCGYXn2oMjAAWse X-Coremail-Antispam: 1Uk129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7 ZEXasCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnUUvcSsGvfC2Kfnx nUUI43ZEXa7xR_UUUUUUUUU== Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 12 Apr 2024 01:34:38 -0700 Resent-From: lichao@loongson.cn Reply-To: devel@edk2.groups.io,lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: pJzFHZdGw06UulSEJxRJepCqx7686176AA= Content-Type: multipart/alternative; boundary="------------DewAbCaI4OSRy7TIu9fV0bDi" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=shntquX3; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.227.220 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none --------------DewAbCaI4OSRy7TIu9fV0bDi Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Gerd, Thanks, Chao On 2024/3/15 17:22, Gerd Hoffmann wrote: > On Mon, Mar 11, 2024 at 02:39:02AM -0700, Chao Li wrote: >> This Library is used to collect APs resources, but is currently NULL >> for OvmfPkg, because it is not used by the LoongArch virtual machine. > What is the point of having this library then? This NULL library will be filled in the future. > >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include "../../../UefiCpuPkg/Library/MpInitLib/LoongArch64/MpLib.h" > Including private header files of other libraries looks questionable. OK, it will be removed next time. > > take care, > Gerd > > > >=20 > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117663): https://edk2.groups.io/g/devel/message/117663 Mute This Topic: https://groups.io/mt/104859891/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --------------DewAbCaI4OSRy7TIu9fV0bDi Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Hi Gerd,


=
Thanks,
Chao
On 2024/3/15 17:22, Gerd Hoffmann wrote:
On Mon, Mar 11, 2024 at 02:39:=
02AM -0700, Chao Li wrote:

This Library is used to coll=
ect APs resources, but is currently NULL
for OvmfPkg, because it is not used by the LoongArch virtual machine.

What is the point of having this library then?
This NULL library will be filled in the future.


+#include <PiPei.h>
+#include <Library/BaseLib.h>
+#include <Library/HobLib.h>
+#include <Library/MemoryAllocationLib.h>
+#include <Register/LoongArch64/Csr.h>
+#include "../../../UefiCpuPkg/Library/MpInitLib/LoongArch64/MpLib.h"

Including private header files of other libraries looks questionable.
OK, it will be removed next time.

take care,
  Gerd
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#117663) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------DewAbCaI4OSRy7TIu9fV0bDi--