From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.54]) by mx.groups.io with SMTP id smtpd.web10.6298.1628001924937401568 for ; Tue, 03 Aug 2021 07:45:25 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=JrroF2An; spf=pass (domain: arm.com, ip: 40.107.21.54, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gYUdV3ITLxdiMi2Q8NRo5bWAdF3D9A7JHC136nFI6k8=; b=JrroF2AnPk+hEmvOoYVoSVKgwG1oo0n4AS/KPtpy/jEzJHIY3w7dbXtU979MDjQTfFRamqh/VpFMRvok5+9Y9GQLR/AEKgZRHWOMoHu+HfPViydh4iYKC88ASN7SbYJy3Af2g6qZfom+txN6W/E6eMl3TVMrV27plndo+cPXheU= Received: from DU2PR04CA0219.eurprd04.prod.outlook.com (2603:10a6:10:2b1::14) by VE1PR08MB4671.eurprd08.prod.outlook.com (2603:10a6:802:ad::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.21; Tue, 3 Aug 2021 14:45:22 +0000 Received: from DB5EUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b1:cafe::c) by DU2PR04CA0219.outlook.office365.com (2603:10a6:10:2b1::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18 via Frontend Transport; Tue, 3 Aug 2021 14:45:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT013.mail.protection.outlook.com (10.152.20.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18 via Frontend Transport; Tue, 3 Aug 2021 14:45:22 +0000 Received: ("Tessian outbound 7b804b1d9bbf:v101"); Tue, 03 Aug 2021 14:45:21 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 88e7cd145ff5fec6 X-CR-MTA-TID: 64aa7808 Received: from 32de3b21f65a.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D7F1BC1F-A42F-4BBB-B81B-2E8245D9C630.1; Tue, 03 Aug 2021 14:45:04 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 32de3b21f65a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 03 Aug 2021 14:45:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LkKK0hOx0a/NRU1uHDuxRrAqc5IxsgKEG5TsLTIcLAk7OGXbveF0hXprAHbcZeMfPNcZt/KU+ud1XpTqwvd2oXlW8xS9Wf26plTVPi5Dh+J9o88oMk2SA60kIRA1Q+6iIwthuyhpZHC7cD30+g2xz4459xltbodwjNvkWTnqLDv2T3p2dSPa0LFtE385ABraPONadSzXUJSsjpD6PbqRxtzWbbTqKr9LRewgmw60IN3w52qhRcJm//nOc3ev4d2jSFRC2Jsv5LWPWFHl6nj3wyaLnMJ6GD1C2Ec037AKeDv2VOC+oRBpAJQUzG/x/6H8A9H7lYT94PqxuB7WXb99ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gYUdV3ITLxdiMi2Q8NRo5bWAdF3D9A7JHC136nFI6k8=; b=CuiviM/vnbKGpgv+RAik/UMld746dcGwYMj01mW60Di+brM4+txPKgRcKPL6oLiQpJ86azsHNiW5wes6ajHZUQB2FbkHYmxHqsWcn7/CS5kXwlgASm7NdkcUqzZLLETWQuTGlDCcOGsd39WwyalTy5bxL92WuhwyA0w2NFNVN0B60h6IokoKz2uesuVZiFMcvCuO1kRT7tFgka7oq0tCWBj6vqLjpveE5i4H8T9vdymG4JSV42kE9MtxdKirM0SEnOXhiKgA+Cs8iv6KaEgtQyfr9Qdf8ReU0kcl41Fq+toRh1tpNwzuZRX0z8GLwDbIi6An1a9sStgVYyMC93Zdjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gYUdV3ITLxdiMi2Q8NRo5bWAdF3D9A7JHC136nFI6k8=; b=JrroF2AnPk+hEmvOoYVoSVKgwG1oo0n4AS/KPtpy/jEzJHIY3w7dbXtU979MDjQTfFRamqh/VpFMRvok5+9Y9GQLR/AEKgZRHWOMoHu+HfPViydh4iYKC88ASN7SbYJy3Af2g6qZfom+txN6W/E6eMl3TVMrV27plndo+cPXheU= Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM6PR08MB3285.eurprd08.prod.outlook.com (2603:10a6:209:4b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.24; Tue, 3 Aug 2021 14:45:03 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::ca6:6171:e2f1:3d40]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::ca6:6171:e2f1:3d40%4]) with mapi id 15.20.4373.026; Tue, 3 Aug 2021 14:45:03 +0000 From: "Sami Mujawar" Subject: Re: [PATCH v2 2/4] ArmPlatformPkg: add definition for MM_HEST_ERROR_SOURCE_DESC_PROTOCOL To: Omkar Anand Kulkarni , devel@edk2.groups.io Cc: Ard Biesheuvel , nd References: <20210710161831.30433-1-omkar.kulkarni@arm.com> <20210710161831.30433-3-omkar.kulkarni@arm.com> Message-ID: <3bcdb3ca-060c-247f-bc54-02edf4516802@arm.com> Date: Tue, 3 Aug 2021 15:45:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20210710161831.30433-3-omkar.kulkarni@arm.com> X-ClientProxiedBy: LO4P123CA0458.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1aa::13) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.1.196.43] (217.140.106.54) by LO4P123CA0458.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1aa::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.15 via Frontend Transport; Tue, 3 Aug 2021 14:45:02 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aed76b47-241f-4dab-c2de-08d9568d5248 X-MS-TrafficTypeDiagnostic: AM6PR08MB3285:|VE1PR08MB4671: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:247;OLM:247; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: hEHj1GpYHNgXPGkVH3hE+ZgCDTOtHUhvc+7sLnvujJ4C6zUCe0BvQ77bk1/uUqWRLavPh117uvl13XkxANTBDnDnaUeqJyIuTChYvRrilfMltWjYIqil1kMJE/RowtA84q+8zNtrHyfYB19rklKRLCJRIfF8zs0PFayjMWPodPoWk+5onXRgiryTeyfq49ZcajtLBtKezwJMxtRlSLrgBsDfte6ZEypR4HjloN4waIwJhcmgnAPFi28mOTVF031dmwvY/rfIXjWpnxIu4/SgysjyRDcXpw+K7zTh630d6mp9nSm2qzxF5nilsKWAC8DpKpGMqWK5Lf5igkR3/xbA9NhgMnZ8YkY070sg04lvSnwABSXdiQp0ejMalPEpOeh5PequSehSqjy0GZ/8MmH+xLMF6O94F/Fp1lrU5kZQl77uhpFhH0M6cEeDQCIL8RADBJtI8AzToKDBXWi2M6j1Np8yLRObYKYwvLVlSqUaxdi59cGWvHwbt0ZBL4rKNiGmWjE3uj7mP0qeqNY6vt8plAvR0BPQkrdqM1NnXoPwdN+glyfFUPI/sco4JDl6eryIm9FbbXF65pP6ux2JdBvjFM+SNy1V0JNyJM+yy24YTJXVqyigXMPQquI477v9kmvmzEBJPXhQpITwOu7nTX8Oll1FQg4XZn0n9qXfVWi5YHKZ4o1fvFFD1mlMg1hCXQvWIWDDVYFnURUdiSsNzz6VFBcieS919qSOyoFkPthOx+dCJh2V22xRRAxmXk+atsVoqrMd75P+kJhWYkrKdydylIEBMBxKl934+Xc4aiUU7ldUt9Q1B1nid/zOriURiq1DXh5cyp7aGUv+bVc5pm1Gc0cwoUdf9xsJ3h6mSzcggZ4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(396003)(39850400004)(366004)(136003)(346002)(2616005)(8676002)(44832011)(31696002)(66946007)(166002)(956004)(186003)(966005)(26005)(5660300002)(6486002)(66476007)(478600001)(83380400001)(54906003)(66556008)(2906002)(4326008)(316002)(16576012)(86362001)(53546011)(8936002)(52116002)(33964004)(38100700002)(36756003)(38350700002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bm13aXQrQ0s2a3UxV08vVXpDT1BTeFoxL1VBY3ZGYlZWRTE3dXQ5bmtNS2Uz?= =?utf-8?B?dFAweUVZcTRFWExVSHQrU1FKbjZzVEpaK3IyKzF0SjZTY2dPM24ya2d1N09D?= =?utf-8?B?cEdRRkl0blo2bENEcnhUZE5leEpWdURtZGc1Y0ZLcGZWSHV2cndDOVNMY3Ux?= =?utf-8?B?QVdDMkNvak1tNXlKbGVkNEMrZE1VVHBySHdQbnpscHlvMXh3SFUxamM1WFRS?= =?utf-8?B?R29mZ3JlZ2dUQkNmRkFWK1o4SWtoRVBvekhkY0xwdHJVZTFzNnRyNkdnMlVy?= =?utf-8?B?bjIxTmhSUGRIU3NwbERwanJKcGRNcTZPTkRFSXlvdnB3ZGg4M1hLQTJGY1lH?= =?utf-8?B?b0VuYWlFNHU3QzFMN1F5alhrYnk1RUppL0ZsV3NqVHlucFRyb0VNRmtCWTBJ?= =?utf-8?B?aWYrYjBCMTM0R244TWFsR05sQzVTQ0dMOUdxcmJjQ3ZjT2RTc1VoZmNRQUtP?= =?utf-8?B?OTQ5Tlk2NC96MXdxSWJvSXlwZEpvOEF1ajkwUDNjaXpTdnpLSnhHUDNqaU1W?= =?utf-8?B?ZEVkbGNrMmNpSTNnNjBmZ20yOGUwZ0JCR0laQWtqNjVxMnhqU1NwTjVURENR?= =?utf-8?B?NHRXeUZydThjd09pZXRMMndNb1lqYWR4WHRZVythemZIdS9GaGZuZnBlTFlH?= =?utf-8?B?bzJRU2ZmL09ObnloTkhQV3FGMXAvWFI2TUhOYW9yNkFId2M4L29qeWt6OTMz?= =?utf-8?B?em1HUlViZTVpUlNQZk5DM3E1empVUUVyYmdQWTlLU09XRHJPdXlyTXNDN2xH?= =?utf-8?B?NDBoVlh0Q0FmaFFsTWFJUnp3bTNOTWRRQVQrbm5udGFoSlBmZjBac2V0VVdm?= =?utf-8?B?V2hOT3dyY1NGRGdHSkMxZkUrTEpMUHZFanNsRDA1SFZFdEZOYTNwRERBcSty?= =?utf-8?B?KzNWcWhqb2NuZ0V0WXVVR2o4RzdVdTVGRGt3TTgxVy9GSnh5WUZjckxMbzRj?= =?utf-8?B?bVpkMkxRZ3BnVVBNMC9mQ3o5K0IwVkxvTlhsQUltU0VIbjYyUTJSUEpBYmkx?= =?utf-8?B?Q3FrK21udm1qb1dzbldreVpOdjNDNnowYVl4ZUx5Y2UzamxFR3Iwa0NIK2wy?= =?utf-8?B?OERTc1hpc2FiYnRuNkY0Mi8vTmhtN1JsenhCT2pML0NnNFlEckpoU252YkRL?= =?utf-8?B?cWRlRE5DWmdIK0dIalJOQWtwOGo0WFRFeXU2aFQzcnRvSXMrNFhGYVlUT0U0?= =?utf-8?B?bkRTa0tyS3Fta0U3dGhNNXkrSWxQbTBiNEFUN0JRTHcxNkFyR09HaGFxL1Rn?= =?utf-8?B?Q01wZkJuTGxDQk03TGJicjRPOEc0bHlsL1d5eFVPUDB2Tk05bUFIVU5yTDZT?= =?utf-8?B?eHZVOUNDc08wU2xPSWt4bDdtOFFhTDZyd2h0b0VwN3lsZGs4QUpjUmk5aEg4?= =?utf-8?B?RGdHb1RydytVdW5WSGYxOEZWaFAxL2VmZDZIWkkwQlFaSTBXR09odlV0Ulkz?= =?utf-8?B?VXVpUEY1RUdycjVBOGtYL2N3RUYxajVBODV5TktRTzMxU3RneXo4YXk4YmxF?= =?utf-8?B?K0Z2WCtEYis5NXZwcUJwVXBFeXRCTERZUEtydWRHckZRYWtoT0ZZQzlNUGt3?= =?utf-8?B?bElKQmZyV3Z5VXZJN3JIRWtrbmdTb0hTdFBwS01HUDFwc2Nmc1FCMXZwa0dw?= =?utf-8?B?cFBBTWJUYjhicVpNZzFrL2d4Uld3WGJEeTlFdThiYktScG5GWGxBOENLQ1pN?= =?utf-8?B?QTRjajNRRHJPd1VIaXRtVWIveHlvTDc2Y2tOdlFsbUZ4WXdPT1lJeFMzdjE3?= =?utf-8?Q?muHimjDlQMQdmFp6bqgo0H9PtewBS7lv8dA5D44?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3285 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: de2a1197-8fbd-4c58-c2f0-08d9568d469f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RbhkEy2o36NM9fxNbMaisVYlctpepg4zDJy3ctYIFKb6imjZ0YE3+wIC+Uo05u5bYRQlPIQ0oRNrhkpZlW/CsY88CxhE5J3PuwQ/s2qG8m2LFc9czdUZEs9yNJkvWkrLoPiGABWd3HIbb2EzyFKf1XbO9pVh+ic6JSk9aES6ALHVLCamCl6/fKELQRTR441JoGABLuh01FKTnoC1G4DQ5s5hECA8Ot+XbvMWwiBatp12F0L1xKWHtsDpy3FJE2yRKmcFdsiLS75Bm2e16eujSRDNgtg1FYT8KXJOYDOiPtWEIoDqfLcEUMwNIyeYc5MH4GpDq8hmTY1f/FyItkvagQc9Js4GXWuPOAhSEzkkhAkEDZyMTTjow9YvPG23BQjDfJaFi3D5SoPaCFRkjz2uiIjYKckvXY+ylJGd/YcMZPLspa1x44aDngzEZKH0+WXIPaJjmQKOZqg2+CCN2ZW9hMJUYvDETQsGtfXCl+Cy54ZFm9z4ABqUAcjsoUy4gmQzw9u9dIAPxNYcbub1dWbDdqqQRTgDluV/1FSo/SOvm4w2h/h2suwnCTaFKDk3mzr1Im8yJxcs44XhbxRuuTl5yY33K8Z/kjPVi5Ez7O8IFGAdW+GSjpwQRQFgmLT/E9W5mGdNmWIJLH/nJ/8COncEwfyKsKi7pgTQLhH/R18g7kqowFskjka/gJ1gcszuBQA7AW8ynbciZQb/yd/mwStPN0rps6oz0Eb1gVd6ie15IRFu0T1V43tPfWRd2sxTZzw5SRxHE1m4YADSneOub1dX2G6GHGiKHkh/8z2H8Pspjw4UIB1jktQiED/EoHnWhn67 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(376002)(136003)(396003)(39850400004)(346002)(36840700001)(46966006)(956004)(36860700001)(186003)(2616005)(83380400001)(4326008)(82310400003)(8676002)(336012)(8936002)(54906003)(70206006)(16576012)(316002)(26005)(5660300002)(81166007)(82740400003)(70586007)(86362001)(478600001)(6486002)(44832011)(53546011)(166002)(356005)(47076005)(31686004)(33964004)(966005)(2906002)(31696002)(36756003)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2021 14:45:22.0433 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aed76b47-241f-4dab-c2de-08d9568d5248 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4671 Content-Type: multipart/alternative; boundary="------------89ED3F8D3CA7900BCBAF8379" Content-Language: en-GB --------------89ED3F8D3CA7900BCBAF8379 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hi Omkar, Please find my response below marked [SAMI] Regards, Sami Mujawar On 10/07/2021 05:18 PM, Omkar Anand Kulkarni wrote: > Add the protocol definition of the MM_HEST_ERROR_SOURCE_DESC_PROTOCOL > protocol. This protocol can be implemented by MM drivers to publish > error source descriptors that have to be populated into HEST table. > > Co-authored-by: Thomas Abraham > Signed-off-by: Omkar Anand Kulkarni > --- > ArmPlatformPkg/ArmPlatformPkg.dec | 1 + > ArmPlatformPkg/Include/Protocol/HestErrorSourceInfo.h | 64 ++++++++++++++++++++ > 2 files changed, 65 insertions(+) > > diff --git a/ArmPlatformPkg/ArmPlatformPkg.dec b/ArmPlatformPkg/ArmPlatformPkg.dec > index e4afe5da8e11..4f062292663b 100644 > --- a/ArmPlatformPkg/ArmPlatformPkg.dec > +++ b/ArmPlatformPkg/ArmPlatformPkg.dec > @@ -131,3 +131,4 @@ > [Protocols.common] > ## Arm Platform HEST table generation protocol > gHestTableProtocolGuid = { 0x705bdcd9, 0x8c47, 0x457e, { 0xad, 0x0d, 0xf7, 0x86, 0xf3, 0x4a, 0x0d, 0x63 } } > + gMmHestErrorSourceDescProtocolGuid = { 0x560bf236, 0xa4a8, 0x4d69, { 0xbc, 0xf6, 0xc2, 0x97, 0x24, 0x10, 0x9d, 0x91 } } > diff --git a/ArmPlatformPkg/Include/Protocol/HestErrorSourceInfo.h b/ArmPlatformPkg/Include/Protocol/HestErrorSourceInfo.h > new file mode 100644 > index 000000000000..95afd4dffe9c > --- /dev/null > +++ b/ArmPlatformPkg/Include/Protocol/HestErrorSourceInfo.h > @@ -0,0 +1,64 @@ > +/** @file > + MM protocol to get the secure error source descriptor information. > + > + MM Drivers must implement this protocol in order to publish secure side > + error source descriptor information to OSPM through the HEST ACPI table. > + > + Copyright (c) 2020 - 2021, ARM Limited. All rights reserved. > + SPDX-License-Identifier: BSD-2-Clause-Patent > +**/ > + > +#ifndef MM_HEST_ERROR_SOURCE_DESC_ > +#define MM_HEST_ERROR_SOURCE_DESC_ > + > +#define MM_HEST_ERROR_SOURCE_DESC_PROTOCOL_GUID \ > + { \ > + 0x560bf236, 0xa4a8, 0x4d69, { 0xbc, 0xf6, 0xc2, 0x97, 0x24, 0x10, 0x9d, 0x91 } \ > + } > + > +typedef struct MM_HEST_ERROR_SOURCE_DESC_PROTOCOL_ [SAMI] Not sure if a trailing underscore would be right to use for the name tag. Can MmHestErrorSourceDescProtocol be used as the name tag? Also see https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/5_source_files/56_declarations_and_types#5-6-3-2-structure-declaration-with-forward-reference-or-self-reference > + MM_HEST_ERROR_SOURCE_DESC_PROTOCOL; > + > +/** > + Get HEST Secure Error Source Descriptors. > + > + The MM drivers implementing this protocol must convey the total count and > + total length of the error sources the driver has along with the actual error > + source descriptor(s). > + > + Passing NULL as Buffer parameter shall return EFI_INVALID_PARAMETR with the > + total length and count of the error source descriptor(s) it supports. > + > + @param[in] This MM_HEST_ERROR_SOURCE_DESC_PROTOCOL instance. > + @param[out] Buffer Buffer to be appended with the error > + source descriptors information. > + @param[out] ErrorSourcesLength Total length of all the error source > + descriptors. > + @param[out] ErrorSourceCount Count of total error source descriptors > + supported by the driver. > + > + retval EFI_SUCCESS If the Buffer is valid and is filled with valid > + Error Source descriptor data. > + retval EFI_INVALID_PARAMTER Buffer is NULL. > + retval Other If no error source descriptor information is > + available. > +**/ > +typedef > +EFI_STATUS > +(EFIAPI *MM_HEST_GET_ERROR_SOURCE_DESCRIPTORS) ( > + IN MM_HEST_ERROR_SOURCE_DESC_PROTOCOL *This, > + OUT VOID **Buffer, > + OUT UINTN *ErrorSourcesLength, > + OUT UINTN *ErrorSourcesCount > + ); > + > +// > +// Protocol declaration > +// > +struct MM_HEST_ERROR_SOURCE_DESC_PROTOCOL_ { > + MM_HEST_GET_ERROR_SOURCE_DESCRIPTORS GetHestErrorSourceDescriptors; > +}; > + > +extern EFI_GUID gMmHestErrorSourceDescProtocolGuid; > + > +#endif // MM_HEST_ERROR_SOURCE_DESC_ --------------89ED3F8D3CA7900BCBAF8379 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit

Hi Omkar,

Please find my response below marked [SAMI]

Regards,

Sami Mujawar
On 10/07/2021 05:18 PM, Omkar Anand Kulkarni wrote:
Add the protocol definition of the MM_HEST_ERROR_SOURCE_DESC_PROTOCOL
protocol. This protocol can be implemented by MM drivers to publish
error source descriptors that have to be populated into HEST table.

Co-authored-by: Thomas Abraham <thomas.abraham@arm.com>
Signed-off-by: Omkar Anand Kulkarni <omkar.kulkarni@arm.com>
---
 ArmPlatformPkg/ArmPlatformPkg.dec                     |  1 +
 ArmPlatformPkg/Include/Protocol/HestErrorSourceInfo.h | 64 ++++++++++++++++++++
 2 files changed, 65 insertions(+)

diff --git a/ArmPlatformPkg/ArmPlatformPkg.dec b/ArmPlatformPkg/ArmPlatformPkg.dec
index e4afe5da8e11..4f062292663b 100644
--- a/ArmPlatformPkg/ArmPlatformPkg.dec
+++ b/ArmPlatformPkg/ArmPlatformPkg.dec
@@ -131,3 +131,4 @@
 [Protocols.common]
   ## Arm Platform HEST table generation protocol
   gHestTableProtocolGuid = { 0x705bdcd9, 0x8c47, 0x457e, { 0xad, 0x0d, 0xf7, 0x86, 0xf3, 0x4a, 0x0d, 0x63 } }
+  gMmHestErrorSourceDescProtocolGuid = { 0x560bf236, 0xa4a8, 0x4d69, { 0xbc, 0xf6, 0xc2, 0x97, 0x24, 0x10, 0x9d, 0x91 } }
diff --git a/ArmPlatformPkg/Include/Protocol/HestErrorSourceInfo.h b/ArmPlatformPkg/Include/Protocol/HestErrorSourceInfo.h
new file mode 100644
index 000000000000..95afd4dffe9c
--- /dev/null
+++ b/ArmPlatformPkg/Include/Protocol/HestErrorSourceInfo.h
@@ -0,0 +1,64 @@
+/** @file
+  MM protocol to get the secure error source descriptor information.
+
+  MM Drivers must implement this protocol in order to publish secure side
+  error source descriptor information to OSPM through the HEST ACPI table.
+
+  Copyright (c) 2020 - 2021, ARM Limited. All rights reserved.
+  SPDX-License-Identifier: BSD-2-Clause-Patent
+**/
+
+#ifndef MM_HEST_ERROR_SOURCE_DESC_
+#define MM_HEST_ERROR_SOURCE_DESC_
+
+#define MM_HEST_ERROR_SOURCE_DESC_PROTOCOL_GUID \
+  { \
+    0x560bf236, 0xa4a8, 0x4d69, { 0xbc, 0xf6, 0xc2, 0x97, 0x24, 0x10, 0x9d, 0x91 } \
+  }
+
+typedef struct MM_HEST_ERROR_SOURCE_DESC_PROTOCOL_
[SAMI] Not sure if a trailing underscore would be right to use for the name tag. Can MmHestErrorSourceDescProtocol be used as the name tag?
Also see https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/5_source_files/56_declarations_and_types#5-6-3-2-structure-declaration-with-forward-reference-or-self-reference 
+                 MM_HEST_ERROR_SOURCE_DESC_PROTOCOL;
+
+/**
+  Get HEST Secure Error Source Descriptors.
+
+  The MM drivers implementing this protocol must convey the total count and
+  total length of the error sources the driver has along with the actual error
+  source descriptor(s).
+
+  Passing NULL as Buffer parameter shall return EFI_INVALID_PARAMETR with the
+  total length and count of the error source descriptor(s) it supports.
+
+  @param[in]   This                MM_HEST_ERROR_SOURCE_DESC_PROTOCOL instance.
+  @param[out]  Buffer              Buffer to be appended with the error
+                                   source descriptors information.
+  @param[out]  ErrorSourcesLength  Total length of all the error source
+                                   descriptors.
+  @param[out]  ErrorSourceCount    Count of total error source descriptors
+                                   supported by the driver.
+
+  retval  EFI_SUCCESS           If the Buffer is valid and is filled with valid
+                                Error Source descriptor data.
+  retval  EFI_INVALID_PARAMTER  Buffer is NULL.
+  retval  Other                 If no error source descriptor information is
+                                available.
+**/
+typedef
+EFI_STATUS
+(EFIAPI *MM_HEST_GET_ERROR_SOURCE_DESCRIPTORS) (
+  IN  MM_HEST_ERROR_SOURCE_DESC_PROTOCOL *This,
+  OUT VOID                               **Buffer,
+  OUT UINTN                              *ErrorSourcesLength,
+  OUT UINTN                              *ErrorSourcesCount
+  );
+
+//
+// Protocol declaration
+//
+struct MM_HEST_ERROR_SOURCE_DESC_PROTOCOL_ {
+  MM_HEST_GET_ERROR_SOURCE_DESCRIPTORS GetHestErrorSourceDescriptors;
+};
+
+extern EFI_GUID gMmHestErrorSourceDescProtocolGuid;
+
+#endif // MM_HEST_ERROR_SOURCE_DESC_


--------------89ED3F8D3CA7900BCBAF8379--