Re: [edk2-devel] [PATCH v3 5/5] ArmVirtPkg/ArmVirtQemu: Add support for HotPlug

["Jiahui Cen" <cenjiahui@huawei.com>]

Hi Laszlo,

On 2021/1/6 18:31, Laszlo Ersek wrote:
> On 12/22/20 10:59, Jiahui Cen via groups.io wrote:
>> It is necessary to add padding for hotplugable PCI Devices like
>> pcie-root-port.
>>
>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3059
>>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>> Cc: Leif Lindholm <leif@nuviainc.com>
>> Signed-off-by: Jiahui Cen <cenjiahui@huawei.com>
>> Signed-off-by: Yubo Miao <miaoyubo@huawei.com>
>> ---
>>  ArmVirtPkg/ArmVirtQemu.dsc           | 1 +
>>  ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 1 +
>>  2 files changed, 2 insertions(+)
>>
>> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
>> index a11ffd9ba553..d77c226d80ee 100644
>> --- a/ArmVirtPkg/ArmVirtQemu.dsc
>> +++ b/ArmVirtPkg/ArmVirtQemu.dsc
>> @@ -488,6 +488,7 @@ [Components.common]
>>      <LibraryClasses>
>>        NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf
>>    }
>> +  OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.inf
>>    OvmfPkg/VirtioPciDeviceDxe/VirtioPciDeviceDxe.inf
>>    OvmfPkg/Virtio10Dxe/Virtio10.inf
>>  
>> diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
>> index 1752fee12b79..5b1d10057545 100644
>> --- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
>> +++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
>> @@ -162,6 +162,7 @@ [FV.FvMain]
>>    INF ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf
>>    INF MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf
>>    INF MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf
>> +  INF OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.inf
>>    INF OvmfPkg/VirtioPciDeviceDxe/VirtioPciDeviceDxe.inf
>>    INF OvmfPkg/Virtio10Dxe/Virtio10.inf
>>  
>>
> 
> (1) Please be more diligent / careful. You are modifying an FDF
> *include* file. Obviously, you want to check what includes the file, no?
> 
> ArmVirtPkg/ArmVirtQemu.fdf:!include ArmVirtQemuFvMain.fdf.inc
> ArmVirtPkg/ArmVirtQemuKernel.fdf:!include ArmVirtQemuFvMain.fdf.inc
> 
> Thus, you need to modify "ArmVirtPkg/ArmVirtQemuKernel.dsc" as well;
> otherwise the ArmVirtQemuKernel platform build will break.

Will add it and check more carefully.

Thanks,
Jiahui

> 
> Thanks
> Laszlo
> 
> 
> 
> 
> 
> 
> .
>