From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by mx.groups.io with SMTP id smtpd.web08.4578.1609998446104682363 for ; Wed, 06 Jan 2021 21:47:27 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: huawei.com, ip: 45.249.212.35, mailfrom: cenjiahui@huawei.com) Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4DBFbM3Gblz7RF7; Thu, 7 Jan 2021 13:46:23 +0800 (CST) Received: from [10.174.184.155] (10.174.184.155) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.498.0; Thu, 7 Jan 2021 13:47:10 +0800 Subject: Re: [edk2-devel] [PATCH v3 5/5] ArmVirtPkg/ArmVirtQemu: Add support for HotPlug To: , CC: Jordan Justen , Ard Biesheuvel , Rebecca Cran , Peter Grehan , Anthony Perard , "Julien Grall" , Leif Lindholm , Sami Mujawar , , , "Yubo Miao" References: <20201222095944.8686-1-cenjiahui@huawei.com> <20201222095944.8686-6-cenjiahui@huawei.com> <5c7a1e82-fdc8-b61a-a8c9-010d6bbfc69c@redhat.com> From: "Jiahui Cen" Message-ID: <3be38257-f9a9-0f18-3d37-df320def2e92@huawei.com> Date: Thu, 7 Jan 2021 13:47:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <5c7a1e82-fdc8-b61a-a8c9-010d6bbfc69c@redhat.com> X-Originating-IP: [10.174.184.155] X-CFilter-Loop: Reflected Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Laszlo, On 2021/1/6 18:31, Laszlo Ersek wrote: > On 12/22/20 10:59, Jiahui Cen via groups.io wrote: >> It is necessary to add padding for hotplugable PCI Devices like >> pcie-root-port. >> >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3059 >> >> Cc: Laszlo Ersek >> Cc: Ard Biesheuvel >> Cc: Leif Lindholm >> Signed-off-by: Jiahui Cen >> Signed-off-by: Yubo Miao >> --- >> ArmVirtPkg/ArmVirtQemu.dsc | 1 + >> ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc >> index a11ffd9ba553..d77c226d80ee 100644 >> --- a/ArmVirtPkg/ArmVirtQemu.dsc >> +++ b/ArmVirtPkg/ArmVirtQemu.dsc >> @@ -488,6 +488,7 @@ [Components.common] >> >> NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> } >> + OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.inf >> OvmfPkg/VirtioPciDeviceDxe/VirtioPciDeviceDxe.inf >> OvmfPkg/Virtio10Dxe/Virtio10.inf >> >> diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc >> index 1752fee12b79..5b1d10057545 100644 >> --- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc >> +++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc >> @@ -162,6 +162,7 @@ [FV.FvMain] >> INF ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf >> INF MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf >> INF MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf >> + INF OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.inf >> INF OvmfPkg/VirtioPciDeviceDxe/VirtioPciDeviceDxe.inf >> INF OvmfPkg/Virtio10Dxe/Virtio10.inf >> >> > > (1) Please be more diligent / careful. You are modifying an FDF > *include* file. Obviously, you want to check what includes the file, no? > > ArmVirtPkg/ArmVirtQemu.fdf:!include ArmVirtQemuFvMain.fdf.inc > ArmVirtPkg/ArmVirtQemuKernel.fdf:!include ArmVirtQemuFvMain.fdf.inc > > Thus, you need to modify "ArmVirtPkg/ArmVirtQemuKernel.dsc" as well; > otherwise the ArmVirtQemuKernel platform build will break. Will add it and check more carefully. Thanks, Jiahui > > Thanks > Laszlo > > > > > > > . >