From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (EUR01-VE1-obe.outbound.protection.outlook.com [40.107.14.52]) by mx.groups.io with SMTP id smtpd.web08.20916.1621265653210631394 for ; Mon, 17 May 2021 08:34:13 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=dLOVwU6X; spf=pass (domain: arm.com, ip: 40.107.14.52, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9yuqMXtZySk2YoukJdL1MoSCGkeuXew3BxBhcHA28ek=; b=dLOVwU6XAwhfRuf3OwnHrZwcAgFrt71utN3a4pknAvPL8VbvT0JXwoXUI3AhL4cL2F1rDwPdefrDH4ab6AiwnxFBuSp6wKN494ywtamyMS45j28nztOb/poFuw0Wr4aB7bkDd+7jg6SV7RtOQsJenaWF+KWTkbTcGB5mSM+P1bU= Received: from AS8PR05CA0001.eurprd05.prod.outlook.com (2603:10a6:20b:311::6) by DB6PR0802MB2151.eurprd08.prod.outlook.com (2603:10a6:4:84::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.26; Mon, 17 May 2021 15:34:10 +0000 Received: from AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:311:cafe::e6) by AS8PR05CA0001.outlook.office365.com (2603:10a6:20b:311::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Mon, 17 May 2021 15:34:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT033.mail.protection.outlook.com (10.152.16.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Mon, 17 May 2021 15:34:09 +0000 Received: ("Tessian outbound 2cd7db0b285f:v92"); Mon, 17 May 2021 15:34:09 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 42e1bc393aeed354 X-CR-MTA-TID: 64aa7808 Received: from cf5422f289a9.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0DEF0B6B-4DED-46BD-800F-2FC39EB4780B.1; Mon, 17 May 2021 15:34:03 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cf5422f289a9.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 17 May 2021 15:34:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Su99Cv9z/dMnGPfFY/3nzGr4urnDqZBcjn5FmzdR7lSjAWehj9nabXJ87OgQ7H8DFPOR2LerK7zUEuLuZ+fMTtA91mdc5N/5uos4W58/a5MLrEuDnmnG+LPb0MpcrNlN+7wGAj/t3YnsDg6xkUTfx8Fbn/yZAtDefywh908cnzQ/pRZ3hltE1gQkk5jlA/4UPdUXX+uelJ4nqa6Zo6/825L70THnpm5aK0yNfJJ0B/Eqp5G1Kl142c2+1uxbC4qIbQcL6V6bGDPWXvShunrcpurtoCnv3/itBKRcqkUagULeSfdh0+clXU0ZLGePnGi1yRl1bvOlbZZc0/r1e8sWfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9yuqMXtZySk2YoukJdL1MoSCGkeuXew3BxBhcHA28ek=; b=LzcvyDm38qCe74o7QRCVlbaoDPVSx71H75b1pBWvjbk/rXX22PcocK114yGhDeYxaCDvolLSNj4DH6TVSgCNO4UP2p9vt8VinyWTuhkY7f9pDGIAVTeAURpw+b5O2+33IGFvK7aUSeJ7R2BbMAgXSWPs1WKmPasAEhycgGfuw80BVA7fijJaDg0cRdeXkakR4w4u8J7CEMjA6e9UICFKO7csL9JxZYfs+5yOe7PKrUhS9FUVDlii7rDt/sWOG7BpAzxX8Hedsmtsl83BLNgX7+rkk2xLXSTXEoBiQMt07+x36SPOpfTVijWBYranjv1lbuP1igENxFVf2MEjQVoztg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9yuqMXtZySk2YoukJdL1MoSCGkeuXew3BxBhcHA28ek=; b=dLOVwU6XAwhfRuf3OwnHrZwcAgFrt71utN3a4pknAvPL8VbvT0JXwoXUI3AhL4cL2F1rDwPdefrDH4ab6AiwnxFBuSp6wKN494ywtamyMS45j28nztOb/poFuw0Wr4aB7bkDd+7jg6SV7RtOQsJenaWF+KWTkbTcGB5mSM+P1bU= Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AS8PR08MB6008.eurprd08.prod.outlook.com (2603:10a6:20b:29d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.26; Mon, 17 May 2021 15:34:00 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::80cb:878d:c8f1:2688]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::80cb:878d:c8f1:2688%7]) with mapi id 15.20.4129.031; Mon, 17 May 2021 15:34:00 +0000 Subject: Re: [edk2-platforms][PATCH V2 11/11] Platform/Sgi: Add SMBIOS Type32 Table To: Pranav Madhu , devel@edk2.groups.io Cc: Ard Biesheuvel , nd@arm.com References: <20210516092917.21124-1-pranav.madhu@arm.com> <20210516092917.21124-12-pranav.madhu@arm.com> From: "Sami Mujawar" Message-ID: <3bfc8aa9-ef88-3ba6-9ba6-b0a0ee358ac1@arm.com> Date: Mon, 17 May 2021 16:33:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20210516092917.21124-12-pranav.madhu@arm.com> X-Originating-IP: [217.140.106.52] X-ClientProxiedBy: LO2P265CA0510.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13b::17) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.1.196.43] (217.140.106.52) by LO2P265CA0510.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.37 via Frontend Transport; Mon, 17 May 2021 15:34:00 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fa2e7c0a-a93b-4d4b-6938-08d919493727 X-MS-TrafficTypeDiagnostic: AS8PR08MB6008:|DB6PR0802MB2151: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:1728;OLM:1728; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: oi/hyO6fX5SK3Uw8i5y+TXfQOLDEYNHauwrWwKavixMl3NOlqjj3fizehP5Z/lgG/2lHUOsAzUo5C6HgI6tKqBW7mxtKr7gEsY7CCgZthU72EkIl+4KXg9OvxnnIbE9gAXLcyyatEKDfyl8PurFHpJJjYcvZLuSC80hEymjSjzrxNO5/yQ06rs59mEpBuerT0rqQz0+NIUjf51cSzngFB9TAR63IlgbaTz7acVwWG8/vDU1eM3PS3IHfaKSyauoqxfoTVsdAj2C0WmFN4XJBo7GvBjj4AIFMPtYySwyxoPZhApst37c4RFm5xeAT+oDBzqZ5yIZl9efElt5og56glIoEOOtyHetKoEuHWaLC0SdobAGuxyNowGI9tro/4MbJne0fck65NuDI/NV1SADCI7L5LXMee/OPjSup74okUXQgDRjVWQK0sK8/x0YAfi2y6+F+zrTqqxs/k6/wd5kLh4sAJ5iccY0NhiD+6ORf88t03RiXocefhw9F1+spCZqhg54u3SjyMqy/uhGJeZwvCF9f4aF7xBrEUsQFBWevNTGmFHvxAuoVdKlPrFufGVySJbjbIwE+I6TS8KT5VOwQdonqxypQj0vjzdQDYy7CvEknsDtgU0E9Ed07xfZwcUjgqFRqnOdz4BkLkgXam9g0vNaMnDh2tRc+3Qqh3wiCEyLt+zMGGI3qJ1MZlWvChBLcwFeqdCFcfwioQc9t5Dc7x2G43fYSRQcMpLRY35RMN3Y= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39850400004)(346002)(366004)(376002)(396003)(136003)(2906002)(5660300002)(38100700002)(38350700002)(19627235002)(6486002)(16526019)(36756003)(83380400001)(66476007)(66556008)(31696002)(66946007)(52116002)(4326008)(316002)(16576012)(44832011)(956004)(2616005)(31686004)(8676002)(86362001)(186003)(53546011)(26005)(8936002)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ekZCbk40NHp5Ykg1QWNYQS9RVVh3UDFQSmVhNTlMQUNjeTJJYnRPRWlqK3pL?= =?utf-8?B?aHBPT2dldXJqTHNsSVhKVjVKbDBVcUpHeHRNUGFuTlRMTlJDdkN3eFQ1Slh1?= =?utf-8?B?V0hQMkljWmdRd0JWQnBTcjVGM3MzTzl3RzR5SHVVcDdYdnk0ditQV01DaFlC?= =?utf-8?B?RVZBcVpDZlJaNmw3VXNCMFRKc1d0TFJhMGsyRWE3cXgzQXhQbkI5bzdEaGx3?= =?utf-8?B?MnNXTzFCMDl5V1dUOGVmL2tqVjUxQ3ZEbGUyRlREOUJiazZMVEdpdm04bHY2?= =?utf-8?B?aFh5SGhXcWU4clZKQUpQZFhzNkNQbkNwL1Y4VWRXVVh0VmxiUDFIQzdpdDFI?= =?utf-8?B?dStxd3JnU0xIaXVyR1hzbEZ5elhCRy9LSGcwOXRDdjB5K3o4OGtudDdPZFJr?= =?utf-8?B?UkVhejBPcXBjc2xNaWhQMWJmL2NydFZVUXpnS1AvM3Q5QXhpcHdncENSUUFr?= =?utf-8?B?NW1nMVU5cFRSZW1nbzNVUXJSSENwc0M2SUZMOVBYeGdtLzdhTlhONEdWZGxI?= =?utf-8?B?NnZaY2xSWE9oRFcvTjYrbWJrMWozY3lyNEhjQWNGdmM0THBHZDhhdjBQS0o1?= =?utf-8?B?bWNXZTdINWhBdUcreEdxelNjNWhNeW5KMlFqdzBWdHhCYXJXL0QxYzJRT0FB?= =?utf-8?B?RDBpaG9Xb3A0Q1ZMdDUzSHBrTGVXNjNONDNFUURRM1JnRWxXRDVnTGEzTnlj?= =?utf-8?B?UVR2NEdYcHN6YXlnTlB4bnRFbDJxSVlvcDVIb3dhQUNTYVVaZGFMV3JScHlq?= =?utf-8?B?anlsZUhxUDdVRVR3YUpkQ05mdmxLTloxSldCc2FQQ3BCTGpBTWdKZElvQVUv?= =?utf-8?B?U04wZDNFZEMybkJscERwUHNrQllFdE9yS0RSbWJVMm1qMk1HRnBpQjlBZVBY?= =?utf-8?B?bkxmaUpIcitsOEdHenNhdFJtcWxCRmk0NUk4NHNHOHhMZUpQaUp0emFIeC9m?= =?utf-8?B?UG8wR2JmZ3RTZ2FJRFhoTWhVZVlXNkVwUmtOV1ZORmJYM0tvbDJOcnU0d1dn?= =?utf-8?B?VFNxUzFES1lkZEZwbjZKM0NLNG9USEpzOWc4Z2dkQWFMazlHdDNGWWhESG1Z?= =?utf-8?B?TkorTGIxbVBzMWFBT0EybVRWWkNBL2JXcWtjd2IzNU1CTStNWTMwRkNtUEp3?= =?utf-8?B?ekpLTlU0aHVhRzVyUkpQaW41a3hTVG1nOXFIM0o0eU9HVnE5ZmFpSmdFUkZ2?= =?utf-8?B?ZGM0OEZpNkoxN1FrWm1lZzRMdUVKdS9DMnhPTjk3eWsxY3cwTllUa0ZJcGtD?= =?utf-8?B?bDRVMkZLTUdJR1U4ZVVuSDRoRXhZYVhxNXlXSS83VCtYelh2ODIzbmw0OTZr?= =?utf-8?B?czJYVXR3Y0hmRlQxMEl1dS8wWHhRNy9vb3NmS1FlcGk4NWRMR2xJZFhneFEx?= =?utf-8?B?MmQ0U0YzVlRSYlJhcklzcDZ5ay9tWGVickEySlh4eWNUODY2eWlScFpVS2tq?= =?utf-8?B?VlRleFFYMXpKR1ZUMjFvNlE3WGs2eFRQeVpFYnh4b0ovMmdDTTZyVFFxU0RV?= =?utf-8?B?Z0lTaFVPaW5iV3V2VnNJcjlrZVIyNlVZNExuS25FSUE1ZTEvNEZ0dkN3dVJ3?= =?utf-8?B?emFEYlU0dGhnWTJFc1UxWm5Oa0FZL1VZNTJFNWJyTit2ZWNVUHprTUtFSkxS?= =?utf-8?B?OHByM2d6ZTI0SHBKZS9ac2psOFIzMzdQK1ZkSVJycldDNktqblBFR0xlS1d6?= =?utf-8?B?N1pKZG1EOVA0dno5Z21hbXFraEN4RjhxWHZZYUVxRTdrY2REMW1JN05ESlk5?= =?utf-8?Q?PYd4QMufeHTWmgNwSvqKpAAa2EcQKSTI6mz4nUe?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6008 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 72803fcc-43d0-4758-3c03-08d91949315c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: e43oA31XyVHnUTOjxCXR4G0kxkT6UHlp4Das6yFCyZb4MXe5mGfnTVUtJ935lNCjsEqcK2aDLxKUVuOcucznMnbo3AEazlqezJcppV2R9JbV4Rx02GKAyBg86RR9TQ1GmbVcF054I+QTr++WE2cuBhWwjCBk/7Q5GcT2iRDg/5+OgpJEJZDwM5P9LleWehznC866sFyjcdP6lhz68DstlWjVhI2K0DlJMFB78yDZHX5cLFs+4M9u4h+cnVh0zMB+t8CEzOZWxW0KjuuLm0MckKa+Am5917NMj8hXVnJmihkpsSFxKA9sveKHD5POXnUky9JWOScE0rH4thVQ3T8Zv9nMRBmTm6Za7snsEXGqAWJuWNApMyFVYitaEU59YKbLAR01MsCmyuGnD4sH1exoQh8ZBUuk5IGEqC+CpMc3/9aLj4RpmsWkgRLiQp2rTwb1I45fzMWjcL100H18KNxszf7J8hrKKgdmABox/nfO3zhOpQcu9yDJjc4dfh762x/48j8vN/Q+uN9824Sj6VFkHOxMDbuvfawmaXIhLLQfnyPcsBiO9XsNnOW7iyjzHKrUQjeBH6cWJvJEa83IAp7SL0p6RSlrvOjmBI3U6SuMssJ9Fws5zm8J089QvTLH3mFlPnEyxx/f4clCMDA3K3CGLT2ciisA7+LIceB4pKG/QNC/gwChpiB2PB27TLo+ZEi3 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(39850400004)(396003)(346002)(376002)(136003)(46966006)(36840700001)(83380400001)(47076005)(70586007)(53546011)(26005)(82310400003)(70206006)(86362001)(4326008)(31686004)(44832011)(31696002)(336012)(356005)(81166007)(316002)(2616005)(956004)(82740400003)(6486002)(16576012)(5660300002)(8676002)(19627235002)(2906002)(8936002)(36860700001)(478600001)(16526019)(36756003)(186003)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2021 15:34:09.7532 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fa2e7c0a-a93b-4d4b-6938-08d919493727 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2151 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Hi Pranav, Some comments in previous patches apply here as well and are not mentioned. With those addressed. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 16/05/2021 10:29 AM, Pranav Madhu wrote: > Add the SMBIOS type 32 table (System Boot Information) that includes > information about the System Boot Status. > > Signed-off-by: Pranav Madhu > --- > Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 1 + > Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.h | 6 ++ > Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 1 + > Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type32SystemBootInformation.c | 84 ++++++++++++++++++++ > 4 files changed, 92 insertions(+) > > diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf > index f81494114188..4258eb9deadb 100644 > --- a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf > +++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf > @@ -23,6 +23,7 @@ > Type16PhysicalMemoryArray.c > Type17MemoryDevice.c > Type19MemoryArrayMappedAddress.c > + Type32SystemBootInformation.c > > [Packages] > ArmPkg/ArmPkg.dec > diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.h b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.h > index c6dd72cb6b99..0bbda4b4b45d 100644 > --- a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.h > +++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.h > @@ -59,6 +59,12 @@ InstallMemoryArrayMappedAddress ( > IN EFI_SMBIOS_PROTOCOL *Smbios > ); > > +EFI_STATUS > +EFIAPI > +InstallSystemBootInformation ( > + IN EFI_SMBIOS_PROTOCOL *Smbios > + ); > + > enum SMBIOS_REFRENCE_HANDLES { > SMBIOS_HANDLE_ENCLOSURE = 0x1000, > SMBIOS_HANDLE_CLUSTER1, > diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c > index d5d1e6393184..77b22678f62a 100644 > --- a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c > +++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c > @@ -34,6 +34,7 @@ ARM_RD_SMBIOS_TABLE_INSTALL_FPTR mSmbiosTableList[] = { > &InstallPhysicalMemoryArray, > &InstallMemoryDevice, > &InstallMemoryArrayMappedAddress, > + &InstallSystemBootInformation, > }; > > /** > diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type32SystemBootInformation.c b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type32SystemBootInformation.c > new file mode 100644 > index 000000000000..1d3eaab810eb > --- /dev/null > +++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type32SystemBootInformation.c > @@ -0,0 +1,84 @@ > +/** @file > + SMBIOS Type 32 (System Boot Information) table for ARM RD platforms. > + > + This file installs SMBIOS Type 32 (System Boot Information) table for Arm's > + Reference Design platforms. It includes information about the System Boot > + Status. > + > + Copyright (c) 2021, ARM Limited. All rights reserved. > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > + @par Specification Reference: > + - SMBIOS Reference Specification 3.4.0, Chapter 7.33 > +**/ > + > +#include > +#include > +#include > + > +#include "SmbiosPlatformDxe.h" > + > +#define TYPE32_STRINGS \ > + "\0" /* Null string */ > + > +/* SMBIOS Type32 structure */ > +#pragma pack(1) > +struct ArmRdSmbiosType32 { > + SMBIOS_TABLE_TYPE32 Base; > + UINT8 Strings[sizeof (TYPE32_STRINGS)]; > +}; > +#pragma pack() > + > +/* System Boot Information */ > +static struct ArmRdSmbiosType32 mArmRdSmbiosType32 = { > + { > + { > + // SMBIOS header > + EFI_SMBIOS_TYPE_SYSTEM_BOOT_INFORMATION, // Type 32 > + sizeof (SMBIOS_TABLE_TYPE32), // Length > + SMBIOS_HANDLE_PI_RESERVED > + }, > + {0}, // Reserved field > + BootInformationStatusNoError // Boot status > + }, > + // Text strings (unformatted area) > + TYPE32_STRINGS > +}; > + > +/** > + Install SMBIOS system boot information > + > + Install the SMBIOS system boot information (type 32) table for RD platforms. > + > + @param[in] Smbios SMBIOS protocol. > + > + @retval EFI_SUCCESS Record was added. > + @retval EFI_OUT_OF_RESOURCES Record was not added. > + @retval EFI_ALREADY_STARTED The SmbiosHandle passed in is already in use. > +**/ > +EFI_STATUS > +InstallSystemBootInformation ( > + IN EFI_SMBIOS_PROTOCOL *Smbios > + ) > +{ > + EFI_STATUS Status; > + EFI_SMBIOS_HANDLE SmbiosHandle; > + > + SmbiosHandle = ((EFI_SMBIOS_TABLE_HEADER *)&mArmRdSmbiosType32)->Handle; > + > + /* Install type 32 table */ > + Status = Smbios->Add ( > + Smbios, > + NULL, > + &SmbiosHandle, > + (EFI_SMBIOS_TABLE_HEADER *)&mArmRdSmbiosType32 > + ); > + if (Status != EFI_SUCCESS) { > + DEBUG (( > + DEBUG_ERROR, > + "SMBIOS: Failed to install Type32 SMBIOS table.\n" > + )); > + } > + > + return Status; > +}