From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web12.3346.1587591709903164980 for ; Wed, 22 Apr 2020 14:41:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GgoRTTll; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587591709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vwTMBvK96C3rRrbMZKVfGa+h6nfmFvDoRue1ZNG1Weo=; b=GgoRTTllLrPFZnroN78WYeqijUF3CpYbBY6Lr970TTvM2KPDjkrzotOJFazqLikSgjyG3s 5DAwoNbnNoPqEZFTPChL3Zp75a1y/IFCZzTKSw+V61UqrbxFkYLyKtPTp6Qbx+yeUuj6k/ kD19TIJmABlETU9+A9dDkJQujuyKS4k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-457-1KpwMlaAMGi69NJ4FuyAWg-1; Wed, 22 Apr 2020 17:41:31 -0400 X-MC-Unique: 1KpwMlaAMGi69NJ4FuyAWg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AC8BB100CD01; Wed, 22 Apr 2020 21:41:30 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-154.ams2.redhat.com [10.36.113.154]) by smtp.corp.redhat.com (Postfix) with ESMTP id ADB835C28F; Wed, 22 Apr 2020 21:41:29 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 1/2] UefiCpuPkg/MpInitLib: Restore IDT context for APs. To: devel@edk2.groups.io, eric.dong@intel.com Cc: Ray Ni , Chandana Kumar References: <20200422090111.423-1-eric.dong@intel.com> From: "Laszlo Ersek" Message-ID: <3c028212-e539-53bf-c883-bdbc518ff5fd@redhat.com> Date: Wed, 22 Apr 2020 23:41:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200422090111.423-1-eric.dong@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Eric, On 04/22/20 11:01, Dong, Eric wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2683 I don't know what patches I'm supposed to review now. You seem to have sent 4 (four) versions of this patch set to the list, but you didn't call them {v1, v2, v3, v4}; you called them {v1, v2, v2, v2}. I can only work off of the dates/times at which you sent the paches. To make the confusion worse: - your third (v3?) posting says "0/2" in the cover letter, but I can only see one patch below it. - your last (v4?) posting (that I can see) doesn't even have a cover letter. (a) [edk2-devel] [PATCH 0/2] UefiCpuPkg/MpInitLib: Fix ASSERT in AP procedure. https://edk2.groups.io/g/devel/message/57772 Date: Wed, 22 Apr 2020 09:34:54 +0800 (b) [edk2-devel] [PATCH v2 0/2] UefiCpuPkg/MpInitLib: Fix ASSERT in AP procedure https://edk2.groups.io/g/devel/message/57786 Date: Wed, 22 Apr 2020 16:45:56 +0800 (~7 hours after (a)) (c) [edk2-devel] [PATCH v2 0/2] UefiCpuPkg/MpInitLib: Fix ASSERT in AP procedure https://edk2.groups.io/g/devel/message/57791 Date: Wed, 22 Apr 2020 16:52:51 +0800 (~7 minutes after (b)) (d) [edk2-devel] [PATCH v2 1/2] UefiCpuPkg/MpInitLib: Restore IDT context for APs. https://edk2.groups.io/g/devel/message/57794 Date: Wed, 22 Apr 2020 17:01:10 +0800 (~8 minutes after (c)) And your latest comment on the bugzilla ticket, at , seems to indicate that (b) is what you consider the most up-to-date version. But you send two versions ((c) and (d)) after that. I think I won't review any of these patches now. (I don't even know under which I should send this response.) Thanks Laszlo