Re: [PATCH v1 4/4] OvmfPkg: Do not check VbeShim.h formatting with Uncrustify

["Laszlo Ersek" <lersek@redhat.com>]

On 03/22/22 02:58, mikuback@linux.microsoft.com wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3875
> 
> The following files:
>   OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.h
>   OvmfPkg/QemuVideoDxe/VbeShim.h
> 
> Are auto generated by the following generators:
>   OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.sh
>   OvmfPkg/QemuVideoDxe/VbeShim.sh
> 
> Therefore, Uncrustify causes a file update to produce a very large
> diff due to formatting changes.
> 
> This change does the following:
>   1. Reverts the Uncrustify changes applied to the files in commit
>      ac0a286f4d74.
>   2. Uses a new UncrustifyCheck CI plugin configuration option to
>      exclude the files from future formatting checks.
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Peter Grehan <grehan@freebsd.org>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
>  OvmfPkg/OvmfPkg.ci.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/OvmfPkg/OvmfPkg.ci.yaml b/OvmfPkg/OvmfPkg.ci.yaml
> index 7459b84d8090..ff022242b018 100644
> --- a/OvmfPkg/OvmfPkg.ci.yaml
> +++ b/OvmfPkg/OvmfPkg.ci.yaml
> @@ -97,5 +97,10 @@
>          ],           # words to extend to the dictionary for this package
>          "IgnoreStandardPaths": [],   # Standard Plugin defined paths that should be ignore
>          "AdditionalIncludePaths": [] # Additional paths to spell check (wildcards supported)
> +    },
> +
> +    # options defined in .pytool/Plugin/UncrustifyCheck
> +    "UncrustifyCheck": {
> +      "IgnoreFiles": ["VbeShim.h"]
>      }
>  }
> 

Acked-by: Laszlo Ersek <lersek@redhat.com>

(Didn't expect the plugin / new option to take relative pathnames / last
components as well, but it's very handy in this case.)

Thanks
Laszlo