From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.6692.1647930953829100303 for ; Mon, 21 Mar 2022 23:35:54 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NZdiu35y; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647930953; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qmLz0OX31nKlLKBLdvuknDXlURm1zZcyViobysSEm4M=; b=NZdiu35yK5nlhHZwvQ7Z8baq9X3u6eJ3nczJ+LBhyas7WfKyJMu5hcn8Q7DZEJHvopQX/1 DnjqLDrp3LuKa9fCYQkDdxskpyt+5RF7+qa0kSdawTqWu7anncCbOdt6w1v3syC+37yOfs +zxxA1UGU5UX6lcaDUFU/wwdE/4BSJ4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-142-WfAiOxa6NXe3SEr0mDkYLQ-1; Tue, 22 Mar 2022 02:35:47 -0400 X-MC-Unique: WfAiOxa6NXe3SEr0mDkYLQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D928B811E75; Tue, 22 Mar 2022 06:35:46 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (unknown [10.39.192.71]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C4BE62166B2D; Tue, 22 Mar 2022 06:35:41 +0000 (UTC) Subject: Re: [PATCH v1 4/4] OvmfPkg: Do not check VbeShim.h formatting with Uncrustify To: mikuback@linux.microsoft.com, devel@edk2.groups.io Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann , Rebecca Cran , Peter Grehan References: <20220322015814.9182-1-mikuback@linux.microsoft.com> <20220322015814.9182-5-mikuback@linux.microsoft.com> From: "Laszlo Ersek" Message-ID: <3c0d084f-788f-6737-9df2-a02456c4137d@redhat.com> Date: Tue, 22 Mar 2022 07:35:40 +0100 MIME-Version: 1.0 In-Reply-To: <20220322015814.9182-5-mikuback@linux.microsoft.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 03/22/22 02:58, mikuback@linux.microsoft.com wrote: > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3875 > > The following files: > OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.h > OvmfPkg/QemuVideoDxe/VbeShim.h > > Are auto generated by the following generators: > OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.sh > OvmfPkg/QemuVideoDxe/VbeShim.sh > > Therefore, Uncrustify causes a file update to produce a very large > diff due to formatting changes. > > This change does the following: > 1. Reverts the Uncrustify changes applied to the files in commit > ac0a286f4d74. > 2. Uses a new UncrustifyCheck CI plugin configuration option to > exclude the files from future formatting checks. > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > Cc: Rebecca Cran > Cc: Peter Grehan > Cc: Laszlo Ersek > Signed-off-by: Michael Kubacki > --- > OvmfPkg/OvmfPkg.ci.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/OvmfPkg/OvmfPkg.ci.yaml b/OvmfPkg/OvmfPkg.ci.yaml > index 7459b84d8090..ff022242b018 100644 > --- a/OvmfPkg/OvmfPkg.ci.yaml > +++ b/OvmfPkg/OvmfPkg.ci.yaml > @@ -97,5 +97,10 @@ > ], # words to extend to the dictionary for this package > "IgnoreStandardPaths": [], # Standard Plugin defined paths that should be ignore > "AdditionalIncludePaths": [] # Additional paths to spell check (wildcards supported) > + }, > + > + # options defined in .pytool/Plugin/UncrustifyCheck > + "UncrustifyCheck": { > + "IgnoreFiles": ["VbeShim.h"] > } > } > Acked-by: Laszlo Ersek (Didn't expect the plugin / new option to take relative pathnames / last components as well, but it's very handy in this case.) Thanks Laszlo