From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web10.8401.1615382415617838421 for ; Wed, 10 Mar 2021 05:20:15 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=KfjA0PP8; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615382414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hv7nQOByfCE5yTww6nfr6jDkCT3PxlFlvw+0AqtTMb4=; b=KfjA0PP8CDYInqd0p8rkOiaEQs4VoXjBjuWX2MNnDxPxktlBu0xbf5VPM8+ALCYcK1LBGB Uoiemtqxy98fqmiV6o7SpPhPg/XKTbxgrAHllIeEMa/C3D3PwiI5OfZAkvmNPfhv+6WRfq tS20FZ7UM8VlgReLIu+UH+FVykiEXt8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-473-wbRdJ3f7MUqgowcJajOy4A-1; Wed, 10 Mar 2021 08:20:13 -0500 X-MC-Unique: wbRdJ3f7MUqgowcJajOy4A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7744F1005D4D; Wed, 10 Mar 2021 13:20:11 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-138.ams2.redhat.com [10.36.115.138]) by smtp.corp.redhat.com (Postfix) with ESMTP id 10E0560C13; Wed, 10 Mar 2021 13:20:09 +0000 (UTC) Subject: Re: [PATCH 1/2] Maintainers.txt: Add reviewers for the OvmfPkg TDX-related files From: "Laszlo Ersek" To: Min Xu , devel@edk2.groups.io Cc: Andrew Fish , Leif Lindholm , Michael D Kinney , Jiewen Yao References: <20210310025532.2108-1-min.m.xu@intel.com> <20210310025532.2108-2-min.m.xu@intel.com> Message-ID: <3c11e766-0172-9482-d5a6-268c413fdc01@redhat.com> Date: Wed, 10 Mar 2021 14:20:09 +0100 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 03/10/21 14:12, Laszlo Ersek wrote: > On 03/10/21 03:55, Min Xu wrote: >> Register reviewers for the TDX-related files in OvmfPkg. >> >> Cc: Andrew Fish >> Cc: Laszlo Ersek >> Cc: Leif Lindholm >> Cc: Michael D Kinney >> Cc: Jiewen Yao >> Signed-off-by: Min Xu >> --- >> Maintainers.txt | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Maintainers.txt b/Maintainers.txt >> index e38497123857..7d9fe89d6d28 100644 >> --- a/Maintainers.txt >> +++ b/Maintainers.txt >> @@ -465,6 +465,10 @@ F: OvmfPkg/PlatformPei/AmdSev.c >> R: Tom Lendacky >> R: Brijesh Singh >> >> +OvmfPkg: TDX-related modules >> +R: Jiewen Yao >> +R: Min Xu >> + >> OvmfPkg: TCG- and TPM2-related modules >> F: OvmfPkg/Include/IndustryStandard/QemuTpm.h >> F: OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c >> > > I'm OK with the patch content, however the placement of the new section > is not right. We strive to keep the section headers alphabetically > ordered. Here's an excerpt (pre-patch): > > OvmfPkg: SEV-related modules > OvmfPkg: TCG- and TPM2-related modules > OvmfPkg: Xen-related modules > > I think that the new section belongs between TCG and Xen. Also -- I actually forgot the more important issue -- this patch does not add any pathname patterns that the section is supposed to apply to! Please refer to the "F:" patterns in the "Maintainers.txt" file, both the explanation near the top of the file, and the various OvmfPkg examples. And then, given that there are no TDX-related files in the tree at the moment (so no F: pattern makes sense at the moment), I think adding this section is premature. This patch should become part of your initial TdxLib contribution -- the patch could be the last one in your series, covering the pathnames introduced by the previous patches in your series. So (just an example) we might have something like: OvmfPkg: TDX-related modules F: OvmfPkg/Library/TdxLib/ R: Jiewen Yao R: Min Xu Subsequently to that, every time you introduced a new TDX-related module (library instance, lib class header, driver, ...), you'd add matching "F:" patterns to the above subsystem. Thanks Laszlo