From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.81]) by mx.groups.io with SMTP id smtpd.web10.1374.1585071732213010365 for ; Tue, 24 Mar 2020 10:42:12 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector2-amdcloud-onmicrosoft-com header.b=D+/Kj4ek; spf=none, err=SPF record not found (domain: amd.com, ip: 40.107.237.81, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e1lPyJEf4vD+3TVf1YPLJPiyzjaMB0nx3/nGvdgC2NpH7O+h86AmCrqD4eAC+Qi4UAvetIv4tDewHyCNkn7z42Vq2WZ7LT6t7WN7eQLXB4vFWXx01d8KQsEu6oC1Ud7RjGa1m2FDGIl+9SchypFSV6cy0G62EcUFaH63rH3biLQXDS7z11C6eTOTumErucOp3TBC8aRkmZq16TfSVaoYgGIZ42YlHSkPxUFGms5x57WsK2MdZRI2jrA03RhKWgeOei7xwIZUhuz6tm7R81i/i1eb2BRPxnVpbespbHhImxey8PvXxPp0+qmzTE8H+2v9fQv8XDUCr/MXjsc9CfwHFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fM6URT25KJh4c4drGE22greSIOsEkDgdgfMADFSiomg=; b=l5c3sAgumdFNw9P4Ix1vJ4dV5sf63t+TuiU9dBpu5V/jYuHoj0cbNLPpFuAdL+ZiUp0a6IGx7UfVCUkykqfgQ5Z3I+HtKhWuEfpUOV98Ohhq6PvqScoArdM5H8L4y7pXzRHfMMDlSkHMIM8bqq+rX6dl3ba7nxNGj2tpiR4OTNNxU/uPdSj2nJxPuF68MJYgOMGfMHGOGrNw8H7LaxmbrfPobW5s+k9bYtCHFbd0DTQeOM4e8FCiECUqKjZiFuWIKpO3Km+zhinWjRm0Ww6wsW3e7nzBtB9Xg3aQby+4rtpyxmVaHR8iQNaeDfFJFSRdU7KUejxrnngqnGfltXtRZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fM6URT25KJh4c4drGE22greSIOsEkDgdgfMADFSiomg=; b=D+/Kj4ekEMuY+EqHYK3fbQbadG6GrWVGDAvKQjy6W0cH749yCoElAVpb1fBVs1TC85yFFKhhWkUNawcZXxObZewIrTlxISrPb+4/kcUIUg78zr2OPC0gRB+3OmdFPdVEOgozSpu8tE5vVIDuXE3AwtjVax+scnbJmIYg68jZoao= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Thomas.Lendacky@amd.com; Received: from DM6PR12MB3163.namprd12.prod.outlook.com (2603:10b6:5:15e::26) by DM6PR12MB4027.namprd12.prod.outlook.com (2603:10b6:5:148::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.20; Tue, 24 Mar 2020 17:42:09 +0000 Received: from DM6PR12MB3163.namprd12.prod.outlook.com ([fe80::f0f9:a88f:f840:2733]) by DM6PR12MB3163.namprd12.prod.outlook.com ([fe80::f0f9:a88f:f840:2733%7]) with mapi id 15.20.2835.023; Tue, 24 Mar 2020 17:42:09 +0000 From: "Lendacky, Thomas" To: devel@edk2.groups.io Cc: Jordan Justen , Laszlo Ersek , Ard Biesheuvel , Michael D Kinney , Liming Gao , Eric Dong , Ray Ni , Brijesh Singh Subject: [PATCH v6 30/42] OvmfPkg/PlatformPei: Move early GDT into ram when SEV-ES is enabled Date: Tue, 24 Mar 2020 12:40:44 -0500 Message-Id: <3c220a38a12977009288735501fe4db0105b468a.1585071656.git.thomas.lendacky@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: X-ClientProxiedBy: DM5PR06CA0025.namprd06.prod.outlook.com (2603:10b6:3:5d::11) To DM6PR12MB3163.namprd12.prod.outlook.com (2603:10b6:5:15e::26) Return-Path: thomas.lendacky@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from tlendack-t1.amd.com (165.204.77.1) by DM5PR06CA0025.namprd06.prod.outlook.com (2603:10b6:3:5d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.19 via Frontend Transport; Tue, 24 Mar 2020 17:41:38 +0000 X-Mailer: git-send-email 2.17.1 X-Originating-IP: [165.204.77.1] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 6b0fff27-c034-401c-2da2-08d7d01a9b27 X-MS-TrafficTypeDiagnostic: DM6PR12MB4027:|DM6PR12MB4027: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-Forefront-PRVS: 03524FBD26 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4636009)(366004)(376002)(396003)(346002)(136003)(39860400002)(2906002)(956004)(6666004)(2616005)(5660300002)(8676002)(6916009)(8936002)(966005)(81156014)(478600001)(81166006)(316002)(36756003)(86362001)(54906003)(52116002)(186003)(6486002)(16526019)(66556008)(66946007)(4326008)(26005)(66476007)(7696005)(136400200001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM6PR12MB4027;H:DM6PR12MB3163.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 70ZpD5mRQQBzppnUrfUrZajU1IaWMEqucD1E3AjZHgx4qn/BEvKhdo5gBduKCp1XfG36qYSp2hoX3CTUS7LstQIIfref8HiQjN4RPlizecAwGszChGS0IYUlmMBbXB5/pdJK/fB42yPIUlTb+Np2oVdFb4YvOTuDJeNMt7PX7r9uOpyBKq8hq5X+JmrPfARk0sf/hghBXtIdROQ60+7aKvvBYLcHuMfPUlWcCzCCEahGSVe++ny9CzwaEX6X7aIFZ/ztrWo24KWCrgoL/CQvCt/hkf1YAWXot4OmBjPKR3sK5ahCfMWfvGrLqJXezSqpoLX/TnFHGeYzYs6HllNI4PKwc6QS0NSHZSUO53CHIdBEqTIvUrv4WHnVfwUPF8F4QkzrxYNWoONiGy59TmLTZTd+Lzv1DRY9JRKH/ItPjXSZUh5QA7cPml1CsicqGUSWlVx+o2OSnGn4sHrrAQXRlU+Pr04xp1HOKp069rRXWnCDNH3NR0rJG2C3fM0hIySLWDP8l07O9eDzJyyvTi9fuTeOoazNurCtjqVF1d6vpRXMI0iEgXDJpv6n0gIng4zul4RqTGxtUDQX8YnniLITxA== X-MS-Exchange-AntiSpam-MessageData: yMxCDA8n9dPEhVEKlVTAbrr12fuS79qyUkB1RKGEVAlHBKBqJ2ZQpVTwErp6Gb8eCC0ykXUYp7XK/HZxYCylq6N2sFsyG8oKwbQrnluVWlpq1ugvElkYvyc62vRqimZaT32KWVqpZIste3sng0BLIQ== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b0fff27-c034-401c-2da2-08d7d01a9b27 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2020 17:41:38.9506 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aKMvbZTU+LLKvogoBdvc7OJRhZeMgAXJzJ4F1HiReuyxJFRfTwFtV9oUb4smobgf4tYGpCy8NOv20GF9zwwGBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4027 Content-Type: text/plain BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 The SEV support will clear the C-bit from non-RAM areas. The early GDT lives in a non-RAM area, so when an exception occurs (like a #VC) the GDT will be read as un-encrypted even though it is encrypted. This will result in a failure to be able to handle the exception. Move the GDT into RAM so it can be accessed without error when running as an SEV-ES guest. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Reviewed-by: Laszlo Ersek Signed-off-by: Tom Lendacky --- OvmfPkg/PlatformPei/AmdSev.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/OvmfPkg/PlatformPei/AmdSev.c b/OvmfPkg/PlatformPei/AmdSev.c index 5f0946763507..38885de359af 100644 --- a/OvmfPkg/PlatformPei/AmdSev.c +++ b/OvmfPkg/PlatformPei/AmdSev.c @@ -39,6 +39,8 @@ AmdSevEsInitialize ( PHYSICAL_ADDRESS GhcbBasePa; UINTN GhcbPageCount; RETURN_STATUS PcdStatus, DecryptStatus; + IA32_DESCRIPTOR Gdtr; + VOID *Gdt; if (!MemEncryptSevEsIsEnabled ()) { return; @@ -76,6 +78,22 @@ AmdSevEsInitialize ( (UINT64)GhcbPageCount, GhcbBase)); AsmWriteMsr64 (MSR_SEV_ES_GHCB, GhcbBasePa); + + // + // The SEV support will clear the C-bit from non-RAM areas. The early GDT + // lives in a non-RAM area, so when an exception occurs (like a #VC) the GDT + // will be read as un-encrypted even though it was created before the C-bit + // was cleared (encrypted). This will result in a failure to be able to + // handle the exception. + // + AsmReadGdtr (&Gdtr); + + Gdt = AllocatePages (EFI_SIZE_TO_PAGES ((UINTN) Gdtr.Limit + 1)); + ASSERT (Gdt != NULL); + + CopyMem (Gdt, (VOID *) Gdtr.Base, Gdtr.Limit + 1); + Gdtr.Base = (UINTN) Gdt; + AsmWriteGdtr (&Gdtr); } /** -- 2.17.1